feat(census-spotlight): update navbar to new layout #677
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #677 +/- ##
=======================================
Coverage 77.67% 77.67%
=======================================
Files 88 88
Lines 6772 6772
=======================================
Hits 5260 5260
Misses 1512 1512
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -50,7 +50,8 @@ export enum EVENTS { | |||
| EXPLORER_GENE_INFO_BUTTON_CLICKED = "EXPLORER_GENE_INFO_BUTTON_CLICKED", | |||
| WMG_CLICK_NAV = "WMG_CLICK_NAV", | |||
| COLLECTIONS_CLICK_NAV = "COLLECTIONS_CLICK_NAV", | |||
| CENSUS_CLICK_NAV = "CENSUS_CLICK_NAV", | |||
There was a problem hiding this comment.
Yep! This was my request, thanks @tihuan for checking 🙏
There was a problem hiding this comment.
Awesome thanks for confirming!
| CENSUS_DOCUMENTATION_CLICK_NAV = "CENSUS_DOCUMENTATION_CLICK_NAV", | ||
| CENSUS_DIRECTORY_CLICK_NAV = "CENSUS_DIRECTORY_CLICK_NAV", |
There was a problem hiding this comment.
I assume she knows about the addition of these two events and safe to assume these are in Plausible too?
| export const spacesXxl = (props: CommonThemeProps) => getSpaces(props)?.xxl; | ||
| export const spacesXl = (props: CommonThemeProps) => getSpaces(props)?.xl; | ||
| export const spacesL = (props: CommonThemeProps) => getSpaces(props)?.l; | ||
| export const spacesM = (props: CommonThemeProps) => getSpaces(props)?.m; | ||
| export const spacesS = (props: CommonThemeProps) => getSpaces(props)?.s; | ||
| export const spacesXs = (props: CommonThemeProps) => getSpaces(props)?.xs; | ||
| export const spacesXxs = (props: CommonThemeProps) => getSpaces(props)?.xxs; | ||
| export const spacesXxxs = (props: CommonThemeProps) => getSpaces(props)?.xxxs; | ||
| export const spacesDefault = (props: CommonThemeProps) => | ||
| getSpaces(props)?.default; | ||
|
|
There was a problem hiding this comment.
thank you SO much for adding these!! Too bad SDS Hackday didn't add these in SDS library, so we don't have to duplicate the work in both Data Portal and Explorer. Hopefully it will be done in 2024!
Change:
Note: I think something is wrong with my fonts locally for explorer, I'm seeing the same thing when pulling dev