Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix local development #584

Merged
merged 2 commits into from
Apr 10, 2023
Merged

chore: fix local development #584

merged 2 commits into from
Apr 10, 2023

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky commented Apr 10, 2023

Fixes local development bug introduced in #500

Debug mode wasn't set properly as the CLI was updated to use the default config, in which debug is set to false. I updated launch_dev_server.sh to use -d flag to set debug.

I also added localhost as an allowed origin when debug is true.

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #584 (5561f31) into main (22d59fd) will not change coverage.
The diff coverage is n/a.

❗ Current head 5561f31 differs from pull request most recent head 611cec5. Consider uploading reports for the commit 611cec5 to get more accurate results

@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   78.40%   78.40%           
=======================================
  Files          84       84           
  Lines        6594     6594           
=======================================
  Hits         5170     5170           
  Misses       1424     1424           
Flag Coverage Δ
frontend 78.40% <ø> (ø)
javascript 78.40% <ø> (ø)
smokeTest ?
unitTest 78.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atarashansky atarashansky enabled auto-merge (squash) April 10, 2023 16:54
@atarashansky atarashansky merged commit f52be5a into main Apr 10, 2023
@atarashansky atarashansky deleted the atar-fix-local-dev branch April 10, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants