Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Assume navbar present by default and only remove padding if dataset metadata errors #517

Merged
merged 5 commits into from
Oct 25, 2022

Conversation

atarashansky
Copy link
Contributor

@atarashansky atarashansky marked this pull request as ready for review October 24, 2022 17:21
@atarashansky atarashansky changed the title issue: 501 fix: Assume navbar present by default and only remove padding if dataset metadata errors Oct 24, 2022
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #517 (863a5e0) into main (31ce63c) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 863a5e0 differs from pull request most recent head 1aa7dc1. Consider uploading reports for the commit 1aa7dc1 to get more accurate results

@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   74.30%   74.31%           
=======================================
  Files          97       97           
  Lines        7621     7647   +26     
=======================================
+ Hits         5663     5683   +20     
- Misses       1958     1964    +6     
Flag Coverage Δ
frontend 74.30% <ø> (+<0.01%) ⬆️
javascript 74.30% <ø> (+<0.01%) ⬆️
smokeTest ?
unitTest 74.30% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
common/rest.py 80.15% <0.00%> (-0.56%) ⬇️
server/common/rest.py 80.15% <0.00%> (-0.56%) ⬇️
app/api/v3.py 94.40% <0.00%> (+0.20%) ⬆️
server/app/api/v3.py 94.40% <0.00%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@atarashansky atarashansky enabled auto-merge (squash) October 25, 2022 17:08
@atarashansky atarashansky merged commit fde15ae into main Oct 25, 2022
@atarashansky atarashansky deleted the atar/501-fixv2 branch October 25, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants