Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move src/components/utils into src/utils #1109

Merged
merged 8 commits into from
Sep 19, 2024

Conversation

rainandbare
Copy link
Contributor

This is a little one to more Truncate and the other utils files. Hopefully you can merge this one into your branch without too much pain!

Copy link
Contributor

@kaloster kaloster Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DiffexNoticeTempFolder is this from interim renaming?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DatasetSelectorTempFolder

Copy link
Contributor

@kaloster kaloster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, LGTM otherwise! 🚀 🎉

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.60%. Comparing base (0d204de) to head (bac7c2f).
Report is 132 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1109      +/-   ##
==========================================
+ Coverage   77.47%   77.60%   +0.12%     
==========================================
  Files          88       92       +4     
  Lines        6856     7162     +306     
==========================================
+ Hits         5312     5558     +246     
- Misses       1544     1604      +60     
Flag Coverage Δ
frontend 77.60% <ø> (+0.12%) ⬆️
javascript 77.60% <ø> (+0.12%) ⬆️
smokeTest ?
unitTest 77.60% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rainandbare rainandbare merged commit 1dfdbf7 into main Sep 19, 2024
29 checks passed
@rainandbare rainandbare deleted the rainandbare/move-utils branch September 19, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants