From 8032f930372604f9e7e8ee9f351326b9bb6d98f6 Mon Sep 17 00:00:00 2001
From: kaloster <kaloster@users.noreply.github.com>
Date: Mon, 23 Sep 2024 21:04:15 +0000
Subject: [PATCH] chore: Add e2e test

---
 .infra/rdev/values.yaml                       |  2 +-
 client/__tests__/e2e/e2e.test.ts              | 24 +++++++++++++++++++
 .../components/BottomBanner/BottomBanner.tsx  |  2 +-
 ...wsletterModal.tsx => NewsletterSignup.tsx} |  0
 4 files changed, 26 insertions(+), 2 deletions(-)
 rename client/src/components/BottomBanner/components/NewsletterSignup/{NewsletterModal.tsx => NewsletterSignup.tsx} (100%)

diff --git a/.infra/rdev/values.yaml b/.infra/rdev/values.yaml
index 4acb0bdeb..eb24a58b5 100644
--- a/.infra/rdev/values.yaml
+++ b/.infra/rdev/values.yaml
@@ -2,7 +2,7 @@ stack:
   services:
     explorer:
       image:
-        tag: sha-7d92494d
+        tag: sha-4e15df6f
       replicaCount: 1
       env:
         # env vars common to all deployment stages
diff --git a/client/__tests__/e2e/e2e.test.ts b/client/__tests__/e2e/e2e.test.ts
index 9a2472ab6..e62ec69c0 100644
--- a/client/__tests__/e2e/e2e.test.ts
+++ b/client/__tests__/e2e/e2e.test.ts
@@ -236,6 +236,30 @@ for (const testDataset of testDatasets) {
               testInfo
             );
           });
+
+          test("newsletter signup modal opens and closes", async ({ page }) => {
+            await goToPage(page, url);
+
+            await page.getByTestId("newsletter-modal-open-button").click();
+
+            await expect(
+              page.getByTestId("newsletter-modal-content")
+            ).toBeVisible();
+
+            await page.getByTestId("newsletter-email-input").fill("test");
+
+            await page.getByTestId("newsletter-subscribe-button").click();
+
+            await expect(
+              page.getByText("Please provide a valid email address.")
+            ).toBeVisible();
+
+            await page.getByTestId("newsletter-modal-close-button").click();
+
+            await expect(
+              page.getByTestId("newsletter-modal-content")
+            ).not.toBeVisible();
+          });
         });
 
         test("resize graph", async ({ page }, testInfo) => {
diff --git a/client/src/components/BottomBanner/BottomBanner.tsx b/client/src/components/BottomBanner/BottomBanner.tsx
index 50847a28c..c575cdad8 100644
--- a/client/src/components/BottomBanner/BottomBanner.tsx
+++ b/client/src/components/BottomBanner/BottomBanner.tsx
@@ -18,7 +18,7 @@ import {
   BOTTOM_BANNER_NEWSLETTER_TEXT,
   FORM_CONTAINER_ID,
 } from "./constants";
-import { NewsletterSignup } from "./components/NewsletterSignup/NewsletterModal";
+import { NewsletterSignup } from "./components/NewsletterSignup/NewsletterSignup";
 import { useConnect } from "./connect";
 
 export interface BottomBannerProps {
diff --git a/client/src/components/BottomBanner/components/NewsletterSignup/NewsletterModal.tsx b/client/src/components/BottomBanner/components/NewsletterSignup/NewsletterSignup.tsx
similarity index 100%
rename from client/src/components/BottomBanner/components/NewsletterSignup/NewsletterModal.tsx
rename to client/src/components/BottomBanner/components/NewsletterSignup/NewsletterSignup.tsx