From 51086b48ffa5897f55c557b61cd64103a6b2f70e Mon Sep 17 00:00:00 2001 From: atarashansky Date: Mon, 29 Aug 2022 11:32:59 -0700 Subject: [PATCH] chore: typed genesetsUI reducer (#423) * chore: typed genesetsUI reducer * fix tsc error Co-authored-by: atarashansky --- client/__tests__/reducers/genesetsUI.test.ts | 6 +++--- client/src/reducers/genesetsUI.ts | 13 +++++++++---- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/client/__tests__/reducers/genesetsUI.test.ts b/client/__tests__/reducers/genesetsUI.test.ts index 0c0ca6a57..2bb4ce775 100644 --- a/client/__tests__/reducers/genesetsUI.test.ts +++ b/client/__tests__/reducers/genesetsUI.test.ts @@ -1,8 +1,8 @@ -import genesetsUIReducer from "../../src/reducers/genesetsUI"; +import genesetsUIReducer, { GeneSetsUIState } from "../../src/reducers/genesetsUI"; // Format: GeneSetsUI(state,action) -const initialState = { +const initialState: GeneSetsUIState = { createGenesetModeActive: false, isEditingGenesetName: false, isAddingGenesToGeneset: false, @@ -30,7 +30,7 @@ describe("geneset UI states", () => { }); test("geneset: disable create geneset mode", () => { expect( - genesetsUIReducer(undefined, { isEditingGenesetName: false }) + genesetsUIReducer(undefined, { type: "geneset: disable rename geneset mode", isEditingGenesetName: false }) ).toMatchObject(initialState); }); diff --git a/client/src/reducers/genesetsUI.ts b/client/src/reducers/genesetsUI.ts index 6a11a7c10..3abfeaa11 100644 --- a/client/src/reducers/genesetsUI.ts +++ b/client/src/reducers/genesetsUI.ts @@ -1,15 +1,20 @@ +import { AnyAction } from "redux"; + +export interface GeneSetsUIState { + createGenesetModeActive: boolean; + isEditingGenesetName: string | false; + isAddingGenesToGeneset: string | false; +} /* Reducers for geneset UI-state. */ -// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types --- FIXME: disabled temporarily on migrate to TS. const GeneSetsUI = ( - state = { + state: GeneSetsUIState = { createGenesetModeActive: false, isEditingGenesetName: false, isAddingGenesToGeneset: false, }, - // eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types, @typescript-eslint/no-explicit-any -- - FIXME: disabled temporarily on migrate to TS. - action: any + action: AnyAction ) => { switch (action.type) { /**