Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit the number of character to the maximum 32 chars #420

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

jakeyheath
Copy link
Contributor

@jakeyheath jakeyheath commented Sep 6, 2022

Summary

Update to this module to disallow names longer than 32 characters. Here is an example:

> format("%.32s", "blahhhhhhh-blahhhhhh-blahhhhzzzzzzzzzzzzzzzzzzz")
"blahhhhhhh-blahhhhhh-blahhhhzzzz"

Test Plan

Say unittests, or list out steps to verify changes.

References

(Optional) Additional links to provide more context.

@jakeyheath jakeyheath requested a review from a team as a code owner September 6, 2022 18:34
@jakeyheath jakeyheath enabled auto-merge (squash) September 6, 2022 18:36
@jakeyheath jakeyheath merged commit f0aa9d3 into main Sep 6, 2022
@jakeyheath jakeyheath deleted the heathj/name-limit-onservice-fargate branch September 6, 2022 18:36
@jakeyheath jakeyheath restored the heathj/name-limit-onservice-fargate branch March 4, 2023 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants