From 75ebe8bcfab46055ca6d2182bac50493dae2a5d6 Mon Sep 17 00:00:00 2001 From: Jeremy Asuncion Date: Wed, 18 Sep 2024 14:31:11 -0700 Subject: [PATCH] feat: upgrade sds colors (#1078) #747 Depends on #1077 Updates the SDS color names to use the new `sds-color-primitive-*` syntax. In the future we should refactor these colors to use the semantic equivalents ## Demo https://dev-sds-upgrade.cryoet.dev.si.czi.technology --- .../app/components/AnnotatedObjectsList.tsx | 7 +++-- .../app/components/AuthorLegend.tsx | 24 ++++++---------- .../app/components/AuthorLink/AuthorLink.tsx | 4 +-- .../app/components/AuthorList/AuthorList.tsx | 6 +++- .../app/components/Breadcrumbs.tsx | 9 ++++-- .../components/BrowseData/DatasetTable.tsx | 9 +++--- .../components/BrowseData/DepositionTable.tsx | 8 +++--- .../app/components/CollapsibleList.tsx | 4 +-- .../data-portal/app/components/CopyBox.tsx | 2 +- .../app/components/DatabaseEntry.tsx | 11 ++++++-- .../Dataset/DatasetMetadataTable.tsx | 4 +-- .../components/Dataset/DatasetOverview.tsx | 4 +-- .../app/components/Dataset/RunsTable.tsx | 7 ++--- .../components/InfoLink/InfoLink.tsx | 2 +- .../AnnotationMetadataFilterSection.tsx | 2 +- .../IncludedContentsFilterSection.tsx | 3 +- .../components/Deposition/DatasetsTable.tsx | 11 ++++---- .../Deposition/DepositionMetadataTable.tsx | 2 +- .../Deposition/DepositionOverview.tsx | 6 ++-- .../Deposition/MethodLinks/MethodLink.tsx | 2 +- .../MethodLinks/MethodLinksMetadataTable.tsx | 9 +++--- .../MethodLinks/MethodLinksOverview.tsx | 8 +++--- .../components/Download/DirectDownloadTab.tsx | 2 +- .../app/components/Download/DownloadModal.tsx | 4 +-- .../Download/DownloadOptionsContent.tsx | 2 +- .../Download/SelectSaveDestination.tsx | 4 +-- .../Download/TomogramSelectorLabel.tsx | 2 +- .../Download/TomogramSelectorOption.tsx | 8 +++--- .../data-portal/app/components/Drawer.tsx | 2 +- .../Filters/DropdownFilterButton.tsx | 10 +++---- .../app/components/Filters/FilterSection.tsx | 2 +- .../app/components/Filters/Filters.module.css | 27 ++++++++++++++---- .../Filters/GroundTruthAnnotationFilter.tsx | 2 +- .../components/Filters/MultiInputFilter.tsx | 2 +- .../app/components/Filters/RegexFilter.tsx | 2 +- .../app/components/Filters/SelectFilter.tsx | 6 +++- .../components/Filters/TiltRangeFilter.tsx | 2 +- .../data-portal/app/components/I18n.tsx | 2 +- .../app/components/Index/IndexCTA.tsx | 6 ++-- .../app/components/Index/IndexContent.tsx | 4 +-- .../app/components/InlineMetadata.tsx | 6 ++-- .../data-portal/app/components/KeyPhoto.tsx | 6 ++-- .../app/components/Layout/CryoETHomeLink.tsx | 4 +-- .../app/components/Layout/Footer.tsx | 10 +++---- .../app/components/Layout/TopNavigation.tsx | 6 ++-- .../app/components/MDX/MdxPageTitle.tsx | 2 +- .../MLChallenge/MLChallengeHeader.tsx | 6 ++-- .../components/MLChallenge/MainContent.tsx | 28 +++++++++---------- .../app/components/MenuDropdown.tsx | 8 +++--- .../app/components/MetadataDrawer.tsx | 14 +++++++--- .../app/components/ModalSubtitle.tsx | 2 +- .../data-portal/app/components/PageHeader.tsx | 4 +-- .../app/components/Radio/Radio.tsx | 4 +-- .../Run/AnnotationConfidenceTable.tsx | 6 ++-- .../components/ObjectIdLink/ObjectIdLink.tsx | 2 +- .../components/Run/AnnotationOveriewTable.tsx | 6 ++-- .../app/components/Run/AnnotationTable.tsx | 22 +++++---------- .../app/components/Run/RunHeader.tsx | 8 ++++-- .../components/Run/TomogramMetadataDrawer.tsx | 2 +- .../app/components/Run/TomogramTable.tsx | 4 +-- .../data-portal/app/components/Select.tsx | 6 ++-- .../app/components/Table/CellHeader.tsx | 21 +++++++++----- .../app/components/Table/MetadataTable.tsx | 6 ++-- .../app/components/Table/PageTable.tsx | 2 +- .../app/components/Table/TableCell.tsx | 28 +++++++++++++------ .../app/components/Table/TableCount.tsx | 2 +- .../app/components/TablePageLayout.tsx | 13 +++++---- .../data-portal/app/components/Tabs.tsx | 4 +-- .../TiltSeriesQualityScoreBadge.tsx | 9 ++++-- .../data-portal/app/components/Tooltip.tsx | 24 +++++++++++++--- 70 files changed, 283 insertions(+), 215 deletions(-) diff --git a/frontend/packages/data-portal/app/components/AnnotatedObjectsList.tsx b/frontend/packages/data-portal/app/components/AnnotatedObjectsList.tsx index bb81cd214..85a9864a9 100644 --- a/frontend/packages/data-portal/app/components/AnnotatedObjectsList.tsx +++ b/frontend/packages/data-portal/app/components/AnnotatedObjectsList.tsx @@ -1,4 +1,3 @@ -import { Tooltip } from '@czi-sds/components' import Paper from '@mui/material/Paper' import Skeleton from '@mui/material/Skeleton' import { range } from 'lodash-es' @@ -8,6 +7,8 @@ import { ANNOTATED_OBJECTS_MAX } from 'app/constants/pagination' import { i18n } from 'app/i18n' import { cns } from 'app/utils/cns' +import { Tooltip } from './Tooltip' + function List({ className, children, @@ -62,7 +63,7 @@ export function AnnotatedObjectsList({ {nodes} @@ -70,7 +71,7 @@ export function AnnotatedObjectsList({ >
-

+

-
+
- + - + @@ -40,15 +42,7 @@ function Legend() { export function AuthorLegend({ inline = false }: { inline?: boolean }) { return ( - } - classes={{ - tooltip: - // need to specify background color because it's not visible locally - '!p-sds-m !min-w-fit border-solid border border-sds-gray-300 !bg-white', - }} - placement="top-start" - > + } placement="top">
@@ -57,7 +51,7 @@ export function AuthorLegend({ inline = false }: { inline?: boolean }) { sdsSize={inline ? 's' : 'xs'} sdsType="button" className={cns( - '!text-inherit !inline-block !align-baseline !fill-sds-gray-500', + '!text-inherit !inline-block !align-baseline !fill-sds-color-primitive-gray-500', inline && 'absolute bottom-sds-xxxs', )} /> diff --git a/frontend/packages/data-portal/app/components/AuthorLink/AuthorLink.tsx b/frontend/packages/data-portal/app/components/AuthorLink/AuthorLink.tsx index c7660ae96..389d34564 100644 --- a/frontend/packages/data-portal/app/components/AuthorLink/AuthorLink.tsx +++ b/frontend/packages/data-portal/app/components/AuthorLink/AuthorLink.tsx @@ -33,7 +33,7 @@ export function AuthorLink({ author.primary_author_status ? 'border-black' - : 'border-sds-gray-500', + : 'border-sds-color-primitive-gray-500', ] : 'border-transparent', )} @@ -48,7 +48,7 @@ export function AuthorLink({ {author.corresponding_author_status && ( diff --git a/frontend/packages/data-portal/app/components/AuthorList/AuthorList.tsx b/frontend/packages/data-portal/app/components/AuthorList/AuthorList.tsx index 431dd401b..899be473e 100644 --- a/frontend/packages/data-portal/app/components/AuthorList/AuthorList.tsx +++ b/frontend/packages/data-portal/app/components/AuthorList/AuthorList.tsx @@ -80,7 +80,11 @@ export function AuthorList({ ))} - + {compact ? otherCollapsed : authorsOther.map((author, i, arr) => ( diff --git a/frontend/packages/data-portal/app/components/Breadcrumbs.tsx b/frontend/packages/data-portal/app/components/Breadcrumbs.tsx index fdc408ab7..a40a20549 100644 --- a/frontend/packages/data-portal/app/components/Breadcrumbs.tsx +++ b/frontend/packages/data-portal/app/components/Breadcrumbs.tsx @@ -21,7 +21,10 @@ function Breadcrumb({ className?: string }) { return link ? ( - + {text} ) : ( @@ -80,14 +83,14 @@ export function Breadcrumbs({ > {returnToDepositionLink && ( {t('returnToDeposition')} )} -
+

{isLoadingDebounced ? ( @@ -151,7 +151,7 @@ export function DatasetTable() { )}

-

+

{isLoadingDebounced ? ( ) : ( @@ -159,7 +159,7 @@ export function DatasetTable() { )}

-

+

{isLoadingDebounced ? ( <> @@ -240,7 +240,6 @@ export function DatasetTable() { header: () => ( } - arrowPadding={{ right: 270 }} width={DatasetTableWidths.runs} > {t('runs')} diff --git a/frontend/packages/data-portal/app/components/BrowseData/DepositionTable.tsx b/frontend/packages/data-portal/app/components/BrowseData/DepositionTable.tsx index d32bec52e..e1fd8712c 100644 --- a/frontend/packages/data-portal/app/components/BrowseData/DepositionTable.tsx +++ b/frontend/packages/data-portal/app/components/BrowseData/DepositionTable.tsx @@ -100,7 +100,7 @@ export function DepositionTable() {

{isLoadingDebounced ? ( @@ -110,7 +110,7 @@ export function DepositionTable() { )}

-

+

{isLoadingDebounced ? ( ) : ( @@ -120,7 +120,7 @@ export function DepositionTable() { )}

-

+

{isLoadingDebounced ? ( <> @@ -197,7 +197,7 @@ export function DepositionTable() { )}

{/* TODO: (kne42) uncomment this when we can fetch dataset counts properly -

+

{isLoadingDebounced ? ( ) : ( diff --git a/frontend/packages/data-portal/app/components/CollapsibleList.tsx b/frontend/packages/data-portal/app/components/CollapsibleList.tsx index 6c209b499..1ed6b0839 100644 --- a/frontend/packages/data-portal/app/components/CollapsibleList.tsx +++ b/frontend/packages/data-portal/app/components/CollapsibleList.tsx @@ -67,7 +67,7 @@ export function CollapsibleList({

) : ( -

+

{t('notSubmitted')}

) diff --git a/frontend/packages/data-portal/app/components/CopyBox.tsx b/frontend/packages/data-portal/app/components/CopyBox.tsx index af77bee52..7aed8df56 100644 --- a/frontend/packages/data-portal/app/components/CopyBox.tsx +++ b/frontend/packages/data-portal/app/components/CopyBox.tsx @@ -36,7 +36,7 @@ export function CopyBox({
diff --git a/frontend/packages/data-portal/app/components/DatabaseEntry.tsx b/frontend/packages/data-portal/app/components/DatabaseEntry.tsx index add8bd07c..29d190c13 100644 --- a/frontend/packages/data-portal/app/components/DatabaseEntry.tsx +++ b/frontend/packages/data-portal/app/components/DatabaseEntry.tsx @@ -36,13 +36,20 @@ export function DatabaseEntry(props: DatabaseEntryProps) {

{(!inline || dbtype === DatabaseType.DOI) && ( {LABEL_MAP.get(dbtype)}: )} diff --git a/frontend/packages/data-portal/app/components/Dataset/DatasetMetadataTable.tsx b/frontend/packages/data-portal/app/components/Dataset/DatasetMetadataTable.tsx index 7c97577fc..ae440cfe0 100644 --- a/frontend/packages/data-portal/app/components/Dataset/DatasetMetadataTable.tsx +++ b/frontend/packages/data-portal/app/components/Dataset/DatasetMetadataTable.tsx @@ -30,7 +30,7 @@ export function DatasetMetadataTable({ renderValue: (value) => { return ( @@ -39,7 +39,7 @@ export function DatasetMetadataTable({ sdsIcon="ChevronRight" sdsSize="xs" sdsType="iconButton" - className="!w-[10px] !h-[10px] !fill-sds-primary-400" + className="!w-[10px] !h-[10px] !fill-sds-color-primitive-blue-400" /> ) diff --git a/frontend/packages/data-portal/app/components/Dataset/DatasetOverview.tsx b/frontend/packages/data-portal/app/components/Dataset/DatasetOverview.tsx index 5173ccf89..dda14b68b 100644 --- a/frontend/packages/data-portal/app/components/Dataset/DatasetOverview.tsx +++ b/frontend/packages/data-portal/app/components/Dataset/DatasetOverview.tsx @@ -8,10 +8,10 @@ import { cnsNoMerge } from 'app/utils/cns' import { PageHeaderSubtitle } from '../PageHeaderSubtitle' -// use clsx here instead of cns since it erroneously merges text-sds-gray-500 and text-sds-caps-xxxs +// use clsx here instead of cns since it erroneously merges text-sds-color-primitive-gray-500 and text-sds-caps-xxxs const sectionHeaderStyles = cnsNoMerge( 'font-semibold uppercase', - 'text-sds-gray-black', + 'text-sds-color-primitive-common-black', 'text-sds-caps-xxxs leading-sds-caps-xxxs tracking-sds-caps', 'mb-sds-xs', ) diff --git a/frontend/packages/data-portal/app/components/Dataset/RunsTable.tsx b/frontend/packages/data-portal/app/components/Dataset/RunsTable.tsx index 449bfd8c1..14e34bd3e 100644 --- a/frontend/packages/data-portal/app/components/Dataset/RunsTable.tsx +++ b/frontend/packages/data-portal/app/components/Dataset/RunsTable.tsx @@ -103,7 +103,6 @@ export function RunsTable() { header: () => ( } - arrowPadding={{ right: 260 }} width={RunTableWidths.name} > {t('runName')} @@ -124,9 +123,9 @@ export function RunsTable() { ) : ( @@ -134,7 +133,7 @@ export function RunsTable() { )} -

+

{isLoadingDebounced ? ( ) : ( diff --git a/frontend/packages/data-portal/app/components/Dataset/SampleAndExperimentConditionsTable/components/InfoLink/InfoLink.tsx b/frontend/packages/data-portal/app/components/Dataset/SampleAndExperimentConditionsTable/components/InfoLink/InfoLink.tsx index a6f97ae26..647a3d8e8 100644 --- a/frontend/packages/data-portal/app/components/Dataset/SampleAndExperimentConditionsTable/components/InfoLink/InfoLink.tsx +++ b/frontend/packages/data-portal/app/components/Dataset/SampleAndExperimentConditionsTable/components/InfoLink/InfoLink.tsx @@ -33,7 +33,7 @@ export function InfoLink({ // don't link if no patterns match if (link) { return ( - + {value} ) diff --git a/frontend/packages/data-portal/app/components/DatasetFilter/AnnotationMetadataFilterSection.tsx b/frontend/packages/data-portal/app/components/DatasetFilter/AnnotationMetadataFilterSection.tsx index 74b2c0870..644dc24cd 100644 --- a/frontend/packages/data-portal/app/components/DatasetFilter/AnnotationMetadataFilterSection.tsx +++ b/frontend/packages/data-portal/app/components/DatasetFilter/AnnotationMetadataFilterSection.tsx @@ -19,7 +19,7 @@ export function AnnotationMetadataFilterSection({ return ( {depositionPageVariant && ( -

+

{t('depositionAnnotationsOnly')}

)} diff --git a/frontend/packages/data-portal/app/components/DatasetFilter/IncludedContentsFilterSection.tsx b/frontend/packages/data-portal/app/components/DatasetFilter/IncludedContentsFilterSection.tsx index 2313b52f1..747328beb 100644 --- a/frontend/packages/data-portal/app/components/DatasetFilter/IncludedContentsFilterSection.tsx +++ b/frontend/packages/data-portal/app/components/DatasetFilter/IncludedContentsFilterSection.tsx @@ -113,7 +113,6 @@ export function IncludedContentsFilterSection({ updateValue(QueryParams.AvailableFiles, options) }} title={`${t('resultsMustIncludeAllFileTypes')}:`} - popperClassName="max-w-[244px]" className={AVAILABLE_FILES_CLASS_NAME} /> @@ -129,7 +128,7 @@ export function IncludedContentsFilterSection({ } details={ depositionPageVariant ? ( -

+

{t('withDepositionData')}

) : undefined diff --git a/frontend/packages/data-portal/app/components/Deposition/DatasetsTable.tsx b/frontend/packages/data-portal/app/components/Deposition/DatasetsTable.tsx index 52eafa958..7996449ba 100644 --- a/frontend/packages/data-portal/app/components/Deposition/DatasetsTable.tsx +++ b/frontend/packages/data-portal/app/components/Deposition/DatasetsTable.tsx @@ -135,8 +135,8 @@ export function DatasetsTable() {

{isLoadingDebounced ? ( @@ -146,7 +146,7 @@ export function DatasetsTable() { )}

-

+

{isLoadingDebounced ? ( ) : ( @@ -154,7 +154,7 @@ export function DatasetsTable() { )}

-

+

{isLoadingDebounced ? ( <> @@ -202,12 +202,11 @@ export function DatasetsTable() { {t('symbolPeriod')}

-

+

} - arrowPadding={{ right: 270 }} width={DepositionPageDatasetTableWidths.runs} subHeader={t('withDepositionData')} > diff --git a/frontend/packages/data-portal/app/components/Deposition/DepositionMetadataTable.tsx b/frontend/packages/data-portal/app/components/Deposition/DepositionMetadataTable.tsx index 26cdb804d..e5b8ec580 100644 --- a/frontend/packages/data-portal/app/components/Deposition/DepositionMetadataTable.tsx +++ b/frontend/packages/data-portal/app/components/Deposition/DepositionMetadataTable.tsx @@ -20,7 +20,7 @@ function CollapsibleDescription({ text }: { text: string }) {

{text}

-
+
)} -

+

{t('ifYouEncounterIssuesWithDownloadTime')}

diff --git a/frontend/packages/data-portal/app/components/Download/DownloadModal.tsx b/frontend/packages/data-portal/app/components/Download/DownloadModal.tsx index 59e0ee2ab..517ef3af1 100644 --- a/frontend/packages/data-portal/app/components/Download/DownloadModal.tsx +++ b/frontend/packages/data-portal/app/components/Download/DownloadModal.tsx @@ -87,7 +87,7 @@ function DownloadModalContent() { return (
{modalData.subtitle && ( -

+

{modalData.subtitle}

)} diff --git a/frontend/packages/data-portal/app/components/Download/DownloadOptionsContent.tsx b/frontend/packages/data-portal/app/components/Download/DownloadOptionsContent.tsx index 207e44c32..17b779bd5 100644 --- a/frontend/packages/data-portal/app/components/Download/DownloadOptionsContent.tsx +++ b/frontend/packages/data-portal/app/components/Download/DownloadOptionsContent.tsx @@ -139,7 +139,7 @@ export function DownloadOptionsContent() {

{downloadTab && ( -
+
setDownloadTab({ diff --git a/frontend/packages/data-portal/app/components/Download/SelectSaveDestination.tsx b/frontend/packages/data-portal/app/components/Download/SelectSaveDestination.tsx index 930c6a59a..1aab28e76 100644 --- a/frontend/packages/data-portal/app/components/Download/SelectSaveDestination.tsx +++ b/frontend/packages/data-portal/app/components/Download/SelectSaveDestination.tsx @@ -10,12 +10,12 @@ export function SelectSaveDestination() { 1. {t('selectSaveDestination')}:{' '} - + — {t('optional')}

-

+

{t('downloadWillSaveToCurrentDirectory')}

diff --git a/frontend/packages/data-portal/app/components/Download/TomogramSelectorLabel.tsx b/frontend/packages/data-portal/app/components/Download/TomogramSelectorLabel.tsx index fe539ca39..e57befdcd 100644 --- a/frontend/packages/data-portal/app/components/Download/TomogramSelectorLabel.tsx +++ b/frontend/packages/data-portal/app/components/Download/TomogramSelectorLabel.tsx @@ -22,7 +22,7 @@ export function TomogramSelectorInputLabel({ tomogram.reconstruction_method, tomogram.processing, )} - + {t('unitAngstrom', { value: tomogram.voxel_spacing })}
diff --git a/frontend/packages/data-portal/app/components/Download/TomogramSelectorOption.tsx b/frontend/packages/data-portal/app/components/Download/TomogramSelectorOption.tsx index b938e0f8e..fc8d3a912 100644 --- a/frontend/packages/data-portal/app/components/Download/TomogramSelectorOption.tsx +++ b/frontend/packages/data-portal/app/components/Download/TomogramSelectorOption.tsx @@ -20,18 +20,18 @@ export function TomogramSelectorOption({ tomogram.processing, )}
-
+
{t('tomogramId')}: {tomogram.id}
-
+
{t('tomogramSampling')}:{' '} {t('unitAngstrom', { value: tomogram.voxel_spacing })} ( {tomogram.size_x}, {tomogram.size_y}, {tomogram.size_z})px
-
+
{t('reconstructionMethod')}: {tomogram.reconstruction_method}
-
+
{t('postProcessing')}: {tomogram.processing}
diff --git a/frontend/packages/data-portal/app/components/Drawer.tsx b/frontend/packages/data-portal/app/components/Drawer.tsx index eaad22656..bc572a40e 100644 --- a/frontend/packages/data-portal/app/components/Drawer.tsx +++ b/frontend/packages/data-portal/app/components/Drawer.tsx @@ -28,7 +28,7 @@ export function Drawer({ { @@ -54,7 +54,7 @@ export function DropdownFilterButton({ {label} @@ -63,7 +63,7 @@ export function DropdownFilterButton({ {filter.label && ( -

+

{filter.label}

)}
-
+
{getPrefixedId(filter.value, filter.queryParam)} diff --git a/frontend/packages/data-portal/app/components/Filters/FilterSection.tsx b/frontend/packages/data-portal/app/components/Filters/FilterSection.tsx index d4db34f79..38301a0e9 100644 --- a/frontend/packages/data-portal/app/components/Filters/FilterSection.tsx +++ b/frontend/packages/data-portal/app/components/Filters/FilterSection.tsx @@ -15,7 +15,7 @@ export function FilterSection({

diff --git a/frontend/packages/data-portal/app/components/Filters/Filters.module.css b/frontend/packages/data-portal/app/components/Filters/Filters.module.css index e4176d09f..a96ef3f35 100644 --- a/frontend/packages/data-portal/app/components/Filters/Filters.module.css +++ b/frontend/packages/data-portal/app/components/Filters/Filters.module.css @@ -1,10 +1,13 @@ /* stylelint-disable selector-class-pattern */ .boolean { - :global(.MuiTypography-root) { - font-size: theme('fontSize.sds-body-s') !important; - font-weight: theme('fontWeight.semibold') !important; - color: theme('colors.sds-color-primitive-gray-500') !important; + :global(.MuiFormControlLabel-root) { + @apply !m-0 !items-center; + } + + :global(.MuiTypography-root) span span { + @apply !text-sds-body-s !leading-sds-body-s font-semibold; + @apply !text-sds-color-primitive-gray-500; } } @@ -33,8 +36,22 @@ } .popper { + /* stylelint-disable-next-line no-descending-specificity */ + :global(.MuiPaper-root) { + @apply p-4; + + /* stylelint-disable-next-line scss/selector-no-redundant-nesting-selector, no-descending-specificity */ + & > div > div { + @apply m-0 p-0; + } + } + + :global(.MuiAutocomplete-listbox) { + @apply !p-0; + } + :global(.MuiMenuItem-root) > span:nth-child(1) { - @apply flex items-center justify-center; + @apply flex items-center p-0; } } diff --git a/frontend/packages/data-portal/app/components/Filters/GroundTruthAnnotationFilter.tsx b/frontend/packages/data-portal/app/components/Filters/GroundTruthAnnotationFilter.tsx index c134bf54f..fd93c9052 100644 --- a/frontend/packages/data-portal/app/components/Filters/GroundTruthAnnotationFilter.tsx +++ b/frontend/packages/data-portal/app/components/Filters/GroundTruthAnnotationFilter.tsx @@ -30,7 +30,7 @@ export function GroundTruthAnnotationFilter({ /> {/* FIXME: once sds upgraded to 0.20.x delete below line and remove fragment wrapper */} {depositionPageVariant && ( -

+

{t('depositionAnnotationsOnly')}

)} diff --git a/frontend/packages/data-portal/app/components/Filters/MultiInputFilter.tsx b/frontend/packages/data-portal/app/components/Filters/MultiInputFilter.tsx index 700956ac1..58383a4a0 100644 --- a/frontend/packages/data-portal/app/components/Filters/MultiInputFilter.tsx +++ b/frontend/packages/data-portal/app/components/Filters/MultiInputFilter.tsx @@ -66,7 +66,7 @@ export function MultiInputFilter({ {title ?? i18n.filterByAnyOfTheFollowing}

-

+

{subtitle ?? `(${i18n.limitOneValuePerField})`}

diff --git a/frontend/packages/data-portal/app/components/Filters/RegexFilter.tsx b/frontend/packages/data-portal/app/components/Filters/RegexFilter.tsx index 931de82ee..345304309 100644 --- a/frontend/packages/data-portal/app/components/Filters/RegexFilter.tsx +++ b/frontend/packages/data-portal/app/components/Filters/RegexFilter.tsx @@ -50,7 +50,7 @@ export function RegexFilter({ {title}

-

+

{`(${t('limitOneValuePerField')})`}

diff --git a/frontend/packages/data-portal/app/components/Filters/SelectFilter.tsx b/frontend/packages/data-portal/app/components/Filters/SelectFilter.tsx index 1532774af..3ff5cb2bb 100644 --- a/frontend/packages/data-portal/app/components/Filters/SelectFilter.tsx +++ b/frontend/packages/data-portal/app/components/Filters/SelectFilter.tsx @@ -123,7 +123,11 @@ export function SelectFilter< groupBy, title, PopperBaseProps: { - className: cns(popperClassName, multiple && styles.popper), + className: cns( + '!w-full max-w-[240px]', + popperClassName, + styles.popper, + ), }, }} InputDropdownProps={ diff --git a/frontend/packages/data-portal/app/components/Filters/TiltRangeFilter.tsx b/frontend/packages/data-portal/app/components/Filters/TiltRangeFilter.tsx index 436959a4c..13f30ba4e 100644 --- a/frontend/packages/data-portal/app/components/Filters/TiltRangeFilter.tsx +++ b/frontend/packages/data-portal/app/components/Filters/TiltRangeFilter.tsx @@ -136,7 +136,7 @@ export function TiltRangeFilter() { />
-

+

{t('tiltRangeFilterDescription')}

diff --git a/frontend/packages/data-portal/app/components/I18n.tsx b/frontend/packages/data-portal/app/components/I18n.tsx index 3ae713518..3c475a55a 100644 --- a/frontend/packages/data-portal/app/components/I18n.tsx +++ b/frontend/packages/data-portal/app/components/I18n.tsx @@ -37,7 +37,7 @@ export function I18n({ i18nKey, components, linkProps, ...props }: Props) { url: ( , 'to'>)} > {/* This will get replaced by I18next */} diff --git a/frontend/packages/data-portal/app/components/Index/IndexCTA.tsx b/frontend/packages/data-portal/app/components/Index/IndexCTA.tsx index e287c6a4d..060a69d98 100644 --- a/frontend/packages/data-portal/app/components/Index/IndexCTA.tsx +++ b/frontend/packages/data-portal/app/components/Index/IndexCTA.tsx @@ -39,7 +39,7 @@ export function IndexCTA() { const { t } = useI18n() return ( -
+

@@ -55,14 +55,14 @@ export function IndexCTA() { buttonText={t('browseData')} url="/browse-data/datasets" /> -
+
-
+
-
-

+

+

diff --git a/frontend/packages/data-portal/app/components/InlineMetadata.tsx b/frontend/packages/data-portal/app/components/InlineMetadata.tsx index 9426bdc4c..b4dc920cf 100644 --- a/frontend/packages/data-portal/app/components/InlineMetadata.tsx +++ b/frontend/packages/data-portal/app/components/InlineMetadata.tsx @@ -24,7 +24,7 @@ export function InlineMetadata({
  • @@ -32,7 +32,7 @@ export function InlineMetadata({ className={cnsNoMerge( 'font-semibold', subheader - ? 'text-sds-gray-600 tracking-sds-body-xxs text-sds-caps-xxs leading-sds-caps-xxs' + ? 'text-sds-color-primitive-gray-600 tracking-sds-body-xxs text-sds-caps-xxs leading-sds-caps-xxs' : 'text-sds-body-xxs leading-sds-body-xxs', uppercase && 'uppercase', subheader && uppercase && 'tracking-sds-caps', @@ -59,7 +59,7 @@ export function InlineMetadata({ if (label) { return ( -
    +
    {label} diff --git a/frontend/packages/data-portal/app/components/KeyPhoto.tsx b/frontend/packages/data-portal/app/components/KeyPhoto.tsx index 91de3e2dd..2c1a80ead 100644 --- a/frontend/packages/data-portal/app/components/KeyPhoto.tsx +++ b/frontend/packages/data-portal/app/components/KeyPhoto.tsx @@ -25,7 +25,7 @@ export function KeyPhoto({
    )) .otherwise(() => ( - + ))}
    ) diff --git a/frontend/packages/data-portal/app/components/Layout/CryoETHomeLink.tsx b/frontend/packages/data-portal/app/components/Layout/CryoETHomeLink.tsx index 940aa45f5..84631b7a9 100644 --- a/frontend/packages/data-portal/app/components/Layout/CryoETHomeLink.tsx +++ b/frontend/packages/data-portal/app/components/Layout/CryoETHomeLink.tsx @@ -3,11 +3,11 @@ import { i18n } from 'app/i18n' export function CryoETHomeLink() { return ( -
    +
    {i18n.title} -
    +
    {i18n.beta}
    diff --git a/frontend/packages/data-portal/app/components/Layout/Footer.tsx b/frontend/packages/data-portal/app/components/Layout/Footer.tsx index fc02995be..055e422d9 100644 --- a/frontend/packages/data-portal/app/components/Layout/Footer.tsx +++ b/frontend/packages/data-portal/app/components/Layout/Footer.tsx @@ -47,14 +47,14 @@ export function Footer() { {LEGAL_LINKS.map(({ label, href }, idx) => ( {label} {idx !== LEGAL_LINKS.length - 1 && ( -
    +
    )} ))} @@ -67,7 +67,7 @@ export function Footer() { -
    +
    @@ -76,7 +76,7 @@ export function Footer() { ) return ( -
    +
    @@ -93,7 +93,7 @@ export function Footer() { {DEV_LINKS.map(({ label, href }) => ( {label} diff --git a/frontend/packages/data-portal/app/components/Layout/TopNavigation.tsx b/frontend/packages/data-portal/app/components/Layout/TopNavigation.tsx index 8c00fb849..b204cd1f9 100644 --- a/frontend/packages/data-portal/app/components/Layout/TopNavigation.tsx +++ b/frontend/packages/data-portal/app/components/Layout/TopNavigation.tsx @@ -39,7 +39,7 @@ export function TopNavigation() { return (
  • ))} ) : ( -

    +

    {t('notSubmitted')}

    ), diff --git a/frontend/packages/data-portal/app/components/Run/AnnotationTable.tsx b/frontend/packages/data-portal/app/components/Run/AnnotationTable.tsx index ebd1e874b..36e3fe67f 100644 --- a/frontend/packages/data-portal/app/components/Run/AnnotationTable.tsx +++ b/frontend/packages/data-portal/app/components/Run/AnnotationTable.tsx @@ -63,7 +63,7 @@ function ConfidenceValue({ value }: { value: number }) { return (

    {value}%

    -

    +

    {t('confidence')}

    @@ -124,7 +124,7 @@ export function AnnotationTable() { {typeof value === 'number' ? ( ) : ( -

    +

    {t('na')}

    )} @@ -168,8 +168,8 @@ export function AnnotationTable() { className={cnsNoMerge( 'px-sds-xs py-sds-xxxs', 'flex items-center justify-center', - 'rounded-sds-m bg-sds-info-200', - 'text-sds-body-xxxs leading-sds-body-xxxs text-sds-info-600 whitespace-nowrap', + 'rounded-sds-m bg-sds-color-primitive-blue-200', + 'text-sds-body-xxxs leading-sds-body-xxxs text-sds-color-primitive-blue-600 whitespace-nowrap', )} > {t('groundTruth')} @@ -178,7 +178,7 @@ export function AnnotationTable() { )}
    -
    +
    @@ -280,20 +280,12 @@ export function AnnotationTable() { key: 'confidence_precision', header: t('precision'), tooltipI18nKey: 'precisionTooltip', - - cellHeaderProps: { - arrowPadding: { left: 100 }, - }, }), getConfidenceCell({ key: 'confidence_recall', header: t('recall'), tooltipI18nKey: 'recallTooltip', - - cellHeaderProps: { - arrowPadding: { left: 120 }, - }, }), columnHelper.display({ @@ -452,11 +444,11 @@ function RowDivider({ return ( {t(groundTruth ? 'groundTruthAnnotations' : 'otherAnnotations', { diff --git a/frontend/packages/data-portal/app/components/Run/RunHeader.tsx b/frontend/packages/data-portal/app/components/Run/RunHeader.tsx index 704df9741..f6114f149 100644 --- a/frontend/packages/data-portal/app/components/Run/RunHeader.tsx +++ b/frontend/packages/data-portal/app/components/Run/RunHeader.tsx @@ -128,14 +128,18 @@ export function RunHeader() { key: t('frames'), value: framesCount > 0 ? t('available') : t('notSubmitted'), valueClass: - framesCount > 0 ? undefined : 'text-sds-gray-500', + framesCount > 0 + ? undefined + : 'text-sds-color-primitive-gray-500', }, { key: t('tiltSeries'), value: tiltSeriesCount > 0 ? t('available') : t('notSubmitted'), valueClass: - tiltSeriesCount > 0 ? undefined : 'text-sds-gray-500', + tiltSeriesCount > 0 + ? undefined + : 'text-sds-color-primitive-gray-500', }, { key: t('alignmentFile'), diff --git a/frontend/packages/data-portal/app/components/Run/TomogramMetadataDrawer.tsx b/frontend/packages/data-portal/app/components/Run/TomogramMetadataDrawer.tsx index f1253aee0..bd8a71ef6 100644 --- a/frontend/packages/data-portal/app/components/Run/TomogramMetadataDrawer.tsx +++ b/frontend/packages/data-portal/app/components/Run/TomogramMetadataDrawer.tsx @@ -65,7 +65,7 @@ export function TomogramMetadataDrawer() { values: [tomogram.deposition?.title ?? ''], renderValue: (value: string) => ( {value} diff --git a/frontend/packages/data-portal/app/components/Run/TomogramTable.tsx b/frontend/packages/data-portal/app/components/Run/TomogramTable.tsx index 8bd7d8067..2c220315b 100644 --- a/frontend/packages/data-portal/app/components/Run/TomogramTable.tsx +++ b/frontend/packages/data-portal/app/components/Run/TomogramTable.tsx @@ -77,7 +77,7 @@ export function TomogramsTable() {
    {t('tomogramId')}: {original.id}
    -
    +
    @@ -120,7 +120,7 @@ export function TomogramsTable() { cell: ({ getValue, row: { original } }) => ( {t('unitAngstrom', { value: getValue() })} -
    +
    ({original.size_x}, {original.size_y}, {original.size_z})px
    diff --git a/frontend/packages/data-portal/app/components/Select.tsx b/frontend/packages/data-portal/app/components/Select.tsx index 2e2217d26..f81ea0f38 100644 --- a/frontend/packages/data-portal/app/components/Select.tsx +++ b/frontend/packages/data-portal/app/components/Select.tsx @@ -115,7 +115,7 @@ export function Select({ {tooltip && ( & { arrowPadding?: TooltipArrowPadding children?: ReactNode @@ -41,11 +42,6 @@ export function CellHeader({ -

    {children}

    +

    + + {children} + +

    + {subHeader && (

    {subHeader} diff --git a/frontend/packages/data-portal/app/components/Table/MetadataTable.tsx b/frontend/packages/data-portal/app/components/Table/MetadataTable.tsx index 9eedb9cbc..1366933b6 100644 --- a/frontend/packages/data-portal/app/components/Table/MetadataTable.tsx +++ b/frontend/packages/data-portal/app/components/Table/MetadataTable.tsx @@ -38,7 +38,9 @@ export function MetadataTable({ return ( ({ hoverType, ...props }: PageTableProps) { container: '!min-w-fit !overflow-x-visible px-sds-xl', row: cns( hoverType === 'group' && - 'group hover:!bg-sds-gray-100 hover:cursor-pointer', + 'group hover:!bg-sds-color-primitive-gray-100 hover:cursor-pointer', hoverType === 'none' && 'hover:!bg-inherit', ), }} diff --git a/frontend/packages/data-portal/app/components/Table/TableCell.tsx b/frontend/packages/data-portal/app/components/Table/TableCell.tsx index 2abe31d86..d7963351f 100644 --- a/frontend/packages/data-portal/app/components/Table/TableCell.tsx +++ b/frontend/packages/data-portal/app/components/Table/TableCell.tsx @@ -1,9 +1,9 @@ -import { CellBasic, CellComponent } from '@czi-sds/components' +import { CellComponent } from '@czi-sds/components' import Skeleton from '@mui/material/Skeleton' import { ReactNode } from 'react' import { match } from 'ts-pattern' -import { getTooltipProps, Tooltip, TooltipProps } from 'app/components/Tooltip' +import { Tooltip, TooltipProps } from 'app/components/Tooltip' import { TableColumnWidth } from 'app/constants/table' import { useIsLoading } from 'app/hooks/useIsLoading' import { cns } from 'app/utils/cns' @@ -54,11 +54,21 @@ export function TableCell({ if (primaryText) { return ( - + +

    + + {primaryText} + +

    + ) } @@ -72,8 +82,8 @@ export function TableCell({ if (tooltip) { content = ( - -
    {content}
    + + {content} ) } diff --git a/frontend/packages/data-portal/app/components/Table/TableCount.tsx b/frontend/packages/data-portal/app/components/Table/TableCount.tsx index 114c399ce..7024aa291 100644 --- a/frontend/packages/data-portal/app/components/Table/TableCount.tsx +++ b/frontend/packages/data-portal/app/components/Table/TableCount.tsx @@ -15,7 +15,7 @@ export function TableCount({ const { isLoadingDebounced } = useIsLoading() return ( -

    +

    {isLoadingDebounced ? ( ) : ( diff --git a/frontend/packages/data-portal/app/components/TablePageLayout.tsx b/frontend/packages/data-portal/app/components/TablePageLayout.tsx index d3e964820..1a9b68bc2 100644 --- a/frontend/packages/data-portal/app/components/TablePageLayout.tsx +++ b/frontend/packages/data-portal/app/components/TablePageLayout.tsx @@ -83,7 +83,7 @@ export function TablePageLayout({ label: (

    {tab.title} - + {tab.filteredCount}
    @@ -153,7 +153,7 @@ function TablePageTabContent({
    {filterPanel} @@ -164,8 +164,9 @@ function TablePageTabContent({ className={cns( 'flex flex-col flex-auto screen-2040:items-center', 'pb-sds-xxl', - 'border-t border-sds-gray-300', + 'border-t border-sds-color-primitive-gray-300', 'overflow-x-scroll max-w-full', + !banner && 'pt-sds-xl', )} >
    -
    {banner}
    + {banner &&
    {banner}
    }

    @@ -200,7 +201,7 @@ function TablePageTabContent({ {learnMoreLink && ( {t('learnMore')} diff --git a/frontend/packages/data-portal/app/components/Tabs.tsx b/frontend/packages/data-portal/app/components/Tabs.tsx index d1dcdb242..595716826 100644 --- a/frontend/packages/data-portal/app/components/Tabs.tsx +++ b/frontend/packages/data-portal/app/components/Tabs.tsx @@ -29,7 +29,7 @@ export function Tabs({ // Translate to overlap with bottom gray border used in different places // in the UI. root: 'translate-y-[2px] !min-h-0', - indicator: 'bg-sds-primary-500', + indicator: 'bg-sds-color-primitive-blue-500', flexContainer: 'gap-sds-xl !pb-sds-xxs', }} > @@ -37,7 +37,7 @@ export function Tabs({ 'bg-sds-error-400 text-sds-gray-white', + () => + 'bg-sds-color-primitive-red-400 text-sds-color-primitive-common-white', ) .with( TiltSeriesScore.Poor, - () => 'bg-sds-warning-400 text-sds-gray-white', + () => + 'bg-sds-color-primitive-yellow-400 text-sds-color-primitive-common-white', ) .with( P.union( @@ -36,7 +38,8 @@ export function TiltSeriesQualityScoreBadge({ TiltSeriesScore.Good, TiltSeriesScore.Excellent, ), - () => 'bg-sds-success-400 text-sds-gray-white', + () => + 'bg-sds-color-primitive-green-400 text-sds-color-primitive-common-white', ) .otherwise(() => ''), )} diff --git a/frontend/packages/data-portal/app/components/Tooltip.tsx b/frontend/packages/data-portal/app/components/Tooltip.tsx index 5b362d97f..d63faeeeb 100644 --- a/frontend/packages/data-portal/app/components/Tooltip.tsx +++ b/frontend/packages/data-portal/app/components/Tooltip.tsx @@ -4,7 +4,7 @@ import { } from '@czi-sds/components' import { ReactNode } from 'react' -import { cnsNoMerge } from 'app/utils/cns' +import { cns, cnsNoMerge } from 'app/utils/cns' export type TooltipOffset = [number, number] @@ -35,16 +35,22 @@ export function getTooltipProps({ sdsStyle, center, size = 'm', + classes, }: Pick< TooltipProps, - 'arrowPadding' | 'offset' | 'sdsStyle' | 'center' | 'size' + 'arrowPadding' | 'offset' | 'sdsStyle' | 'center' | 'size' | 'classes' > = {}) { return { arrow: true, leaveDelay: 0, classes: { - arrow: sdsStyle === 'dark' ? '!text-black' : '!text-white', + ...classes, + + arrow: cns( + sdsStyle === 'dark' ? '!text-black' : '!text-white', + classes?.arrow, + ), tooltip: cnsNoMerge( '!px-sds-l !py-2', @@ -53,6 +59,8 @@ export function getTooltipProps({ '!font-normal !text-sds-body-xs !leading-sds-body-xs', 'shadow-lg', size === 's' && 'w-[200px]', + 'border-solid border border-sds-color-primitive-gray-300', + classes?.tooltip, ), }, @@ -93,12 +101,20 @@ export function Tooltip({ sdsStyle, center, size, + classes, ...props }: TooltipProps) { return (

    {children}