-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests for PyTorch classes #477
Comments
Added unit tests for various batching cases, sparse/dense output, and encoders |
@pablo-gar (cc: @atolopko-czi @ebezzi ) - Is this intentionally left open to serve as a placeholder for unit test tasks for pytorch? I ask because the ticket is was created in May 2023. If so, should we create tickets for specific test cases for |
This is definitely an old ticket! There are two stubbed/ignored tests that are intended to test coverage for cellxgene-census/api/python/cellxgene_census/src/cellxgene_census/experimental/ml/pytorch.py Lines 547 to 555 in 96c0499
Regarding the other two test suggestions, above:
This appears to be implicitly tested by various methods such as
Similarly, this is implicitly tested by tests that assert the ordered values within a row of X, but I would add an explicit test for this. And particularly for sparse tensors, I would test that the expected data at a given var coordinate is correct. |
Census PyTorch ExperimentDataPipe unit test coverage is already substantial. However, there are a few stubbed tests that could implemented.
In addition add tests for:
The text was updated successfully, but these errors were encountered: