Skip to content
This repository has been archived by the owner on Dec 23, 2023. It is now read-only.

Stats: Consider providing a convenient API for recording with SpanContext attachment. #1775

Closed
songy23 opened this issue Feb 28, 2019 · 2 comments
Closed

Stats: Consider providing a convenient API for recording with SpanContext attachment. #1775

songy23 opened this issue Feb 28, 2019 · 2 comments
Assignees
@songy23
Labels
API enhancement stats tracing
Milestone
Release 0.20.0

Comments

@songy23
Copy link
Contributor

songy23 commented Feb 28, 2019 •
edited
Loading

See the original discussion on #1771 (comment).

Currently we only support <String, String> as attachments for Exemplars, and TraceID and SpanID are two separate entries in the attachments. Consider providing a convenient API that takes SpanContext directly a more generic interface.
@songy23 songy23 mentioned this issue Feb 28, 2019
Merged
@bogdandrutu
Copy link
Contributor

Actually I am suggesting to have a <String, LazyString>

@songy23 songy23 mentioned this issue Feb 28, 2019
Merged
@songy23 songy23 self-assigned this Mar 13, 2019
@songy23 songy23 added this to the Release 0.20.0 milestone Mar 13, 2019
@songy23
Copy link
Contributor Author

songy23 commented Mar 13, 2019

Fixed with #1779 and #1791.

@songy23 songy23 closed this as completed Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@songy23 songy23

Labels
API enhancement stats tracing
Projects
None yet
Milestone
Release 0.20.0
Development

No branches or pull requests
2 participants
@bogdandrutu @songy23