-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
service/header: deduplicate Header msgs in pubsub #236
Comments
ContextInterestingly, it turned out there were two reasons why Header msgs were duplicated on HeaderSub:
The duplication issue is not critical and the network can function normally. The only problem is a waste of bandwidth which ideally should be avoided. Solutions
|
Needed Pubsub feature for the second solution: libp2p/go-libp2p-pubsub#465 |
Another attempt in pubsub: libp2p/go-libp2p-pubsub#468 |
libp2p/go-libp2p-pubsub#468 is now merged. The next step would be to wait for a new release and use implement deduplication, but we can not, as the implemented feature goes after Datastore interface update in the PubSub, which requires us to update ourselves to the new interface and subsequently to the new IPLD version, which is laborious(but worth that)(#306). A quick and dirty solution would be to fork PubSub and exclude commit with the interface update and rely on it. |
Aaahhh, I messed up the link. If you see this and coming from the dependabot PRs then I am forwarding you to #306 |
No description provided.
The text was updated successfully, but these errors were encountered: