Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mono models to huggingface model-zoo and incorporate into pipeline #26

Closed
ronakice opened this issue May 22, 2020 · 6 comments
Closed
Labels
good first issue Good for newcomers

Comments

@ronakice
Copy link
Member

As pointed out in hedwig, Huggingface's model-zoo provides a simple way of loading models without having for us to manually download models each time we use it. Besides, adding that would also allow us to track how many times our models are being used. Hence, this will be a great feature to incorporate into pygaggle.

Begin with monoBERT-large (should be simple) (Name choice - monobert-large-msmarco) and then figure out how to do the same with monoT5 (monot5-base-msmarco).

@ronakice ronakice assigned ronakice and unassigned ronakice May 22, 2020
@ronakice ronakice added the good first issue Good for newcomers label May 22, 2020
@ronakice
Copy link
Member Author

ronakice commented Jun 1, 2020

This is done in #29

@ronakice ronakice closed this as completed Jun 1, 2020
@lintool
Copy link
Member

lintool commented Jun 1, 2020

Don't think the counters are working? https://huggingface.co/castorini/monobert-large-msmarco

@MXueguang
Copy link
Member

Don't think the counters are working? https://huggingface.co/castorini/monobert-large-msmarco

weird, maybe because we haven't create README.md model card for the models on hugging face repo. I'll create one and ask them when making PR.

@ronakice
Copy link
Member Author

ronakice commented Jun 1, 2020

@MXueguang run by the content of the card once you are done creating it, I'll note if anything needs changing! Thanks

@ronakice
Copy link
Member Author

ronakice commented Jun 1, 2020

Hey @lintool, can't seem to find any model updated after May 15th. So they might just be updating occasionally...

@lintool
Copy link
Member

lintool commented Jun 1, 2020

haha, okay! thanks for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants