From 12ac2c5aa0f4aa73b058b4bd3758a471f04cf93d Mon Sep 17 00:00:00 2001
From: Randy Levensalor <r.levensalor@cablelabs.com>
Date: Wed, 14 Aug 2024 09:18:33 -0600
Subject: [PATCH 1/4] Updating names of endpoints

---
 code/API_definitions/qos-profiles.yaml | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/code/API_definitions/qos-profiles.yaml b/code/API_definitions/qos-profiles.yaml
index 9ae2132ce..2ecd0b6d8 100644
--- a/code/API_definitions/qos-profiles.yaml
+++ b/code/API_definitions/qos-profiles.yaml
@@ -75,17 +75,21 @@ tags:
     description: Manage QoS Profiles
 
 paths:
-  /qos-profiles:
+  /retrieve-qos-profiles:
     post:
       tags:
         - QoS Profiles
-      summary: Get QoS profiles available for a given device
+      summary: Retrieve QoS profiles
       description: |
         Returns all QoS Profiles that match the given criteria.
         **NOTES:**
         - The access token may be either a 2-legged or 3-legged access token.
         - If the access token is 3-legged, all returned QoS Profiles will be available to all end users associated with the access token.
-      operationId: qosProfilesDevice
+
+      security:
+        - openId:
+            - qos-profiles:read
+      operationId: retrieveQoSProfilesByDevice
       parameters:
         - $ref: "#/components/parameters/x-correlator"
       requestBody:
@@ -124,12 +128,12 @@ paths:
         "503":
           $ref: "#/components/responses/Generic503"
 
-  /qos-profiles/{name}:
+  /retrieve-qos-profile/{name}:
     get:
       tags:
         - QoS Profiles
       summary: "Get QoS Profile for a given name"
-      operationId: getQosProfile
+      operationId: retrieveQosProfile
       description: |
         Returns a QoS Profile that matches the given name.
 
@@ -137,7 +141,7 @@ paths:
 
       security:
         - openId:
-            - qos-profiles:qos-profiles:read
+            - qos-profiles:read
       parameters:
         - name: name
           in: path

From 442e0c399b5041807c4ce12dfc1b26d315223275 Mon Sep 17 00:00:00 2001
From: Randy Levensalor <randymartini@gmail.com>
Date: Tue, 20 Aug 2024 12:57:23 -0600
Subject: [PATCH 2/4] Update code/API_definitions/qos-profiles.yaml

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
---
 code/API_definitions/qos-profiles.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/code/API_definitions/qos-profiles.yaml b/code/API_definitions/qos-profiles.yaml
index 2ecd0b6d8..91af4383f 100644
--- a/code/API_definitions/qos-profiles.yaml
+++ b/code/API_definitions/qos-profiles.yaml
@@ -141,7 +141,7 @@ paths:
 
       security:
         - openId:
-            - qos-profiles:read
+            - qos-profiles:retrieve-qos-profiles
       parameters:
         - name: name
           in: path

From 8cac2199dffdd107cf21f2d37476e93e4fabce0f Mon Sep 17 00:00:00 2001
From: Randy Levensalor <r.levensalor@cablelabs.com>
Date: Thu, 22 Aug 2024 21:25:19 -0600
Subject: [PATCH 3/4] Incorporating feedback

---
 code/API_definitions/qos-profiles.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/code/API_definitions/qos-profiles.yaml b/code/API_definitions/qos-profiles.yaml
index 91af4383f..127fbb9ed 100644
--- a/code/API_definitions/qos-profiles.yaml
+++ b/code/API_definitions/qos-profiles.yaml
@@ -128,7 +128,7 @@ paths:
         "503":
           $ref: "#/components/responses/Generic503"
 
-  /retrieve-qos-profile/{name}:
+  /retrieve-qos-profiles/{name}:
     get:
       tags:
         - QoS Profiles
@@ -141,7 +141,7 @@ paths:
 
       security:
         - openId:
-            - qos-profiles:retrieve-qos-profiles
+            - qos-profiles:read
       parameters:
         - name: name
           in: path

From 0f43a3bed6478aa5443414f1bfa2cab7ecb55313 Mon Sep 17 00:00:00 2001
From: Randy Levensalor <r.levensalor@cablelabs.com>
Date: Fri, 23 Aug 2024 06:04:46 -0600
Subject: [PATCH 4/4] Removing verb from get call

---
 code/API_definitions/qos-profiles.yaml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/code/API_definitions/qos-profiles.yaml b/code/API_definitions/qos-profiles.yaml
index 127fbb9ed..8e6b8c2fd 100644
--- a/code/API_definitions/qos-profiles.yaml
+++ b/code/API_definitions/qos-profiles.yaml
@@ -89,7 +89,7 @@ paths:
       security:
         - openId:
             - qos-profiles:read
-      operationId: retrieveQoSProfilesByDevice
+      operationId: retrieveQoSProfiles
       parameters:
         - $ref: "#/components/parameters/x-correlator"
       requestBody:
@@ -128,12 +128,12 @@ paths:
         "503":
           $ref: "#/components/responses/Generic503"
 
-  /retrieve-qos-profiles/{name}:
+  /qos-profiles/{name}:
     get:
       tags:
         - QoS Profiles
       summary: "Get QoS Profile for a given name"
-      operationId: retrieveQosProfile
+      operationId: getQosProfile
       description: |
         Returns a QoS Profile that matches the given name.