Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send notifications for all qosStatus changes #254

Closed
hdamker opened this issue Jan 11, 2024 Discussed in #242 · 2 comments
Closed

Send notifications for all qosStatus changes #254

hdamker opened this issue Jan 11, 2024 Discussed in #242 · 2 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@hdamker
Copy link
Collaborator

hdamker commented Jan 11, 2024

Problem description

The documentation within v0.10.0 doesn't currently define precisly for which qosStatus changes a developer can expect to receive a notification, see the description below (and which notifications must be implemented by an QoD API provider).

The discussion topic (see below) suggested to send notifications for all changes of the status of the QoS Session resources, including the initial entering of "available" and the ones induced by API calls by the API consumer (e.g. delete of the QoS session). This behaviour was agreed within the QoD call of Dec 15th.

Expected behavior

The documentation describes the expected behaviour. Test cases are defined for all qosStatus changes.

Alternative solution

Additional context

Discussed in #242

Originally posted by shilpa-padgaonkar December 12, 2023
As far as I can understand, if response to create session leads to qosStatus "requested", then the developer can later receive the notification, qosStatus "available". However if the create session response leads directly to qosStatus "available", the notification with status "available" will be skipped. Similarly, before explicit delete session or delete session due to timer expiry, there is no notification sent as qosStatus "unavailable". Is this understanding correct?
If yes, what is the thought around always sending notifications whenever qosStatus becomes available or unavailable (due to whatever conditions).

@hdamker hdamker changed the title Send notifications for all status changes Send notifications for all qosStatus changes Jan 11, 2024
@hdamker hdamker added documentation Improvements or additions to documentation enhancement New feature or request v0.10.0 labels Jan 11, 2024
@hdamker
Copy link
Collaborator Author

hdamker commented Jan 29, 2024

This issue will get fixed by #258

@hdamker
Copy link
Collaborator Author

hdamker commented Feb 7, 2024

#258 is merged and part of v0.10.0-rc2

@hdamker hdamker closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant