-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor corrections in Subscription model before release #84
Comments
I also think that we won't have events without this context specific info. However the CloudEvents spec says that the data field is optional. So to be conform we should keep it optional. But that endpoint is anyway implemented on the client side, which can receive any CloudEvents, not just Camara ones. In the subscription we are free, so there I think we could add the device, since also for me no DeviceStatus use cases is known which doesn't need a device. |
The PR for that should be a simple one, I think, if everybody's agreed, we could close it quickly. @bigludo7 @eric-murray @sachinvodafone @JoachimDahlgren @SyeddR |
Hello @fernandopradocabrillo For |
Regarding "data", what I understood from Camara API Design Guideline that "its occurence can be set to mandatory by given CAMARA API " so I believe, we can set as "mandatory" for device status. |
Hello |
As expressed within #81 there is some urgency to get this issue done as it is blocking the v0.5.0 release candidate.
I understand here, that the
This is agreed as far as I can see. @fernandopradocabrillo @akoshunyadi can one of you asap create the PR for it? In Spain are this week holidays and tomorrow a bridge day, maybe it is faster if @akoshunyadi is taking it. |
Problem description
data
property should be required in callback request bodyIn the operacion "postNotification", the POST /subscriptions callback, we have the property "data" as optional, but shouldn't it be required? Otherwise it exists the posibility of sending an empty notification.
In the Sim Swap Subscriptions yaml we have it as required to avoid this issue.
subscriptionDetail.device
property should be requiredWe have
device
as optional in all subscription endpoints, request body and responses. I think this one should be required too. For the /roaming and /connectivity operations it is required so the system knows what devices are you asking for. It should be the same for the notifications. If we leave it like it is right know a client can create a subscription and not specify for what device. The same for the the GET endpoints, right now, it is allowed to not provide information regarding the device the subscriptions belongs to.The text was updated successfully, but these errors were encountered: