Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include x-correlator header #104

Closed
fernandopradocabrillo opened this issue Feb 6, 2024 · 1 comment · Fixed by #112
Closed

Include x-correlator header #104

fernandopradocabrillo opened this issue Feb 6, 2024 · 1 comment · Fixed by #112
Labels
enhancement New feature or request

Comments

@fernandopradocabrillo
Copy link
Collaborator

Problem description
We need to include the x-correlator header as agreed in commonalities.

Design Guidelines: https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#9-architecture-headers

@fernandopradocabrillo fernandopradocabrillo added the enhancement New feature or request label Feb 6, 2024
@fernandopradocabrillo
Copy link
Collaborator Author

Hi @akoshunyadi
regarding the question that you raised this morning in the meeting about if the value of the x-correlator in the notification call should be the same one as in the subscription creation, we believe that it doesn't need to.
The correlator is used to track all the procceses and executions regarding one operation. But in this case we have two different operations, once being the creation of the subscription and the other one the post of the event.
The relation between the subscription and the event is the subscriptionId

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant