From bc4a30fd44f42f12fe7a6765643a6c5e1fb59819 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Wed, 9 Oct 2024 11:34:24 -0500 Subject: [PATCH] [23.0.x] Fix backtraces through empty sequences of Wasm frames (#9414) * Fix backtraces through empty sequences of Wasm frames This fixes a bug where we would not properly handle contiguous sequences of Wasm frames that are empty. This was mistakenly believed to be an impossible scenario, and before the tail-calls proposal it was impossible, however it can now happen after the following series of events: * Host calls into Wasm, pushing the entry trampoline frame. * Entry trampoline calls the actual Wasm function, pushing a Wasm frame. * Wasm function tail calls to an imported host function, *replacing* the Wasm frame with the exit trampoline's frame. Now we have a stack like `[host, entry trampoline, exit trampoline]`, which has zero Wasm frames between the entry and exit trampolines. If the host function that the exit trampoline calls out to attempts to capture a backtrace, then -- before this commit -- we would fail an internal assertion and panic. That panic would then unwind to the first Rust frame that is called by Wasm. With Rust 1.81 and later, Rust automatically inserts a panic handler that prevents the unwind from continuing into external/foreign code, which is undefined behavior, and aborts the process. Rust versions before 1.81 would attempt to continue unwinding, hitting undefined behavior. This commit fixes the backtrace capturing machinery to handle empty sequences of Wasm frames, passes the assertion, and avoids unwinding into external/foreign code. Co-Authored-By: Alex Crichton * Add release notes * Add more release notes * ignore tail calls tests on s390x, since it didn't implement them in this release * undo accidental submodule commit change --------- Co-authored-by: Nick Fitzgerald --- RELEASES.md | 16 +++ .../src/runtime/vm/traphandlers/backtrace.rs | 20 +++ tests/all/traps.rs | 117 ++++++++++++++++++ 3 files changed, 153 insertions(+) diff --git a/RELEASES.md b/RELEASES.md index db3a245a2bb5..23f1316ec1f3 100644 --- a/RELEASES.md +++ b/RELEASES.md @@ -1,3 +1,19 @@ +## 23.0.3 + +Released 2024-10-09. + +### Fixed + +* Fix a runtime crash when combining tail-calls with host imports that capture a + stack trace or trap. + [GHSA-q8hx-mm92-4wvg](https://github.com/bytecodealliance/wasmtime/security/advisories/GHSA-q8hx-mm92-4wvg) + +* Fix a race condition could lead to WebAssembly control-flow integrity and type + safety violations. + [GHSA-7qmx-3fpx-r45m](https://github.com/bytecodealliance/wasmtime/security/advisories/GHSA-7qmx-3fpx-r45m) + +-------------------------------------------------------------------------------- + ## 23.0.2 Released 2024-08-12. diff --git a/crates/wasmtime/src/runtime/vm/traphandlers/backtrace.rs b/crates/wasmtime/src/runtime/vm/traphandlers/backtrace.rs index cf589aaf3813..0c610a35252c 100644 --- a/crates/wasmtime/src/runtime/vm/traphandlers/backtrace.rs +++ b/crates/wasmtime/src/runtime/vm/traphandlers/backtrace.rs @@ -178,6 +178,26 @@ impl Backtrace { arch::assert_entry_sp_is_aligned(trampoline_sp); + // It is possible that the contiguous sequence of Wasm frames is + // empty. This is rare, but can happen if: + // + // * Host calls into Wasm, pushing the entry trampoline frame + // + // * Entry trampoline calls the actual Wasm function, pushing a Wasm frame + // + // * Wasm function tail calls to an imported host function, *replacing* + // the Wasm frame with the exit trampoline's frame + // + // Now we have a stack like `[host, entry trampoline, exit trampoline]` + // which has a contiguous sequence of Wasm frames that are empty. + // + // Therefore, check if we've reached the entry trampoline's SP as the + // first thing we do. + if arch::reached_entry_sp(fp, trampoline_sp) { + log::trace!("=== Empty contiguous sequence of Wasm frames ==="); + return ControlFlow::Continue(()); + } + loop { // At the start of each iteration of the loop, we know that `fp` is // a frame pointer from Wasm code. Therefore, we know it is not diff --git a/tests/all/traps.rs b/tests/all/traps.rs index 7c356adad086..8fc77391a8d0 100644 --- a/tests/all/traps.rs +++ b/tests/all/traps.rs @@ -6,6 +6,9 @@ use std::process::Command; use std::sync::{Arc, Mutex}; use wasmtime::*; +#[cfg(not(target_arch = "s390x"))] +use wasmtime_test_macros::wasmtime_test; + #[test] fn test_trap_return() -> Result<()> { let mut store = Store::<()>::default(); @@ -1679,3 +1682,117 @@ fn async_stack_size_ignored_if_disabled() -> Result<()> { Ok(()) } + +#[wasmtime_test(wasm_features(tail_call))] +#[cfg(not(target_arch = "s390x"))] +fn tail_call_to_imported_function(config: &mut Config) -> Result<()> { + let engine = Engine::new(config)?; + + let module = Module::new( + &engine, + r#" + (module + (import "" "" (func (result i32))) + + (func (export "run") (result i32) + return_call 0 + ) + ) + "#, + )?; + + let mut store = Store::new(&engine, ()); + let host_func = Func::wrap(&mut store, || -> Result { bail!("whoopsie") }); + let instance = Instance::new(&mut store, &module, &[host_func.into()])?; + + let run = instance.get_typed_func::<(), i32>(&mut store, "run")?; + let err = run.call(&mut store, ()).unwrap_err(); + assert!(err.to_string().contains("whoopsie")); + + Ok(()) +} + +#[wasmtime_test(wasm_features(tail_call))] +#[cfg(not(target_arch = "s390x"))] +fn tail_call_to_imported_function_in_start_function(config: &mut Config) -> Result<()> { + let engine = Engine::new(config)?; + + let module = Module::new( + &engine, + r#" + (module + (import "" "" (func)) + + (func $f + return_call 0 + ) + + (start $f) + ) + "#, + )?; + + let mut store = Store::new(&engine, ()); + let host_func = Func::wrap(&mut store, || -> Result<()> { bail!("whoopsie") }); + let err = Instance::new(&mut store, &module, &[host_func.into()]).unwrap_err(); + assert!(err.to_string().contains("whoopsie")); + + Ok(()) +} + +#[wasmtime_test(wasm_features(tail_call, function_references))] +#[cfg(not(target_arch = "s390x"))] +fn return_call_ref_to_imported_function(config: &mut Config) -> Result<()> { + let engine = Engine::new(config)?; + + let module = Module::new( + &engine, + r#" + (module + (type (func (result i32))) + (func (export "run") (param (ref 0)) (result i32) + (return_call_ref 0 (local.get 0)) + ) + ) + "#, + )?; + + let mut store = Store::new(&engine, ()); + let host_func = Func::wrap(&mut store, || -> Result { bail!("whoopsie") }); + let instance = Instance::new(&mut store, &module, &[])?; + + let run = instance.get_typed_func::(&mut store, "run")?; + let err = run.call(&mut store, host_func).unwrap_err(); + assert!(err.to_string().contains("whoopsie")); + + Ok(()) +} + +#[wasmtime_test(wasm_features(tail_call, function_references))] +#[cfg(not(target_arch = "s390x"))] +fn return_call_indirect_to_imported_function(config: &mut Config) -> Result<()> { + let engine = Engine::new(config)?; + + let module = Module::new( + &engine, + r#" + (module + (import "" "" (func (result i32))) + (table 1 funcref (ref.func 0)) + (func (export "run") (result i32) + (return_call_indirect (result i32) (i32.const 0)) + ) + ) + "#, + )?; + + let mut store = Store::new(&engine, ()); + let host_func = Func::wrap(&mut store, || -> Result { bail!("whoopsie") }); + let instance = Instance::new(&mut store, &module, &[host_func.into()])?; + + let run = instance.get_typed_func::<(), i32>(&mut store, "run")?; + let err = run.call(&mut store, ()).unwrap_err(); + assert!(err.to_string().contains("whoopsie")); + + Ok(()) +}