Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup golangci-lint #987

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Setup golangci-lint #987

merged 2 commits into from
Oct 3, 2023

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Oct 3, 2023

This PR setup golangci-lint:

  • gofmt is replace by gofumpt
  • gci is organising the imports
  • go vet is configured to be used with shadow rule

Supersedes #953

Signed-off-by: Matthieu MOREL matthieu.morel35@gmail.com

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@rodaine rodaine merged commit 53d8355 into bufbuild:main Oct 3, 2023
4 checks passed
@rodaine
Copy link
Member

rodaine commented Oct 3, 2023

Thanks @mmorel-35!

@mmorel-35 mmorel-35 deleted the patch-1 branch October 4, 2023 03:53
trunk-io bot referenced this pull request in ride-app/payments-service Jan 13, 2024
… v1.0.3 (#897)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [github.com/envoyproxy/protoc-gen-validate](https://togithub.com/envoyproxy/protoc-gen-validate) | `v1.0.2` -> `v1.0.3` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fenvoyproxy%2fprotoc-gen-validate/v1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fenvoyproxy%2fprotoc-gen-validate/v1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fenvoyproxy%2fprotoc-gen-validate/v1.0.2/v1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fenvoyproxy%2fprotoc-gen-validate/v1.0.2/v1.0.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>envoyproxy/protoc-gen-validate (github.com/envoyproxy/protoc-gen-validate)</summary>

### [`v1.0.3`](https://togithub.com/bufbuild/protoc-gen-validate/releases/tag/v1.0.3)

[Compare Source](https://togithub.com/envoyproxy/protoc-gen-validate/compare/v1.0.2...v1.0.3)

#### What's Changed

-   Handle github-actions and pip dependencies by [@&#8203;mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/bufbuild/protoc-gen-validate/pull/908](https://togithub.com/bufbuild/protoc-gen-validate/pull/908)
-   Update README.md to include new protovalidate releases by [@&#8203;elliotmjackson](https://togithub.com/elliotmjackson) in [https://github.com/bufbuild/protoc-gen-validate/pull/922](https://togithub.com/bufbuild/protoc-gen-validate/pull/922)
-   Bump google.golang.org/protobuf from 1.30.0 to 1.31.0 by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/906](https://togithub.com/bufbuild/protoc-gen-validate/pull/906)
-   Bump golang.org/x/tools from 0.10.0 to 0.12.0 by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/939](https://togithub.com/bufbuild/protoc-gen-validate/pull/939)
-   Bump golang.org/x/net from 0.11.0 to 0.14.0 in /tests by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/932](https://togithub.com/bufbuild/protoc-gen-validate/pull/932)
-   Trim the readme down by [@&#8203;elliotmjackson](https://togithub.com/elliotmjackson) in [https://github.com/bufbuild/protoc-gen-validate/pull/938](https://togithub.com/bufbuild/protoc-gen-validate/pull/938)
-   Update tibdex/github-app-token by [@&#8203;rubensf](https://togithub.com/rubensf) in [https://github.com/bufbuild/protoc-gen-validate/pull/968](https://togithub.com/bufbuild/protoc-gen-validate/pull/968)
-   Bump actions/checkout from 3 to 4 by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/959](https://togithub.com/bufbuild/protoc-gen-validate/pull/959)
-   Bump google.protobuf.version from 3.23.3 to 3.24.3 in /java by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/955](https://togithub.com/bufbuild/protoc-gen-validate/pull/955)
-   Update Go+GHA deps by [@&#8203;rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/984](https://togithub.com/bufbuild/protoc-gen-validate/pull/984)
-   Bump java deps by [@&#8203;rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/985](https://togithub.com/bufbuild/protoc-gen-validate/pull/985)
-   Setup golangci-lint by [@&#8203;mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/bufbuild/protoc-gen-validate/pull/987](https://togithub.com/bufbuild/protoc-gen-validate/pull/987)
-   Move PGV documentation back into the root README by [@&#8203;nicksnyder](https://togithub.com/nicksnyder) in [https://github.com/bufbuild/protoc-gen-validate/pull/1012](https://togithub.com/bufbuild/protoc-gen-validate/pull/1012)
-   Group dependabot version updates by [@&#8203;rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/1024](https://togithub.com/bufbuild/protoc-gen-validate/pull/1024)
-   Fix dependabot by [@&#8203;rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/1025](https://togithub.com/bufbuild/protoc-gen-validate/pull/1025)
-   Bump the go-tests group in /tests with 1 update by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1030](https://togithub.com/bufbuild/protoc-gen-validate/pull/1030)
-   Bump the java group in /java with 9 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1028](https://togithub.com/bufbuild/protoc-gen-validate/pull/1028)
-   Bump the github-actions group with 2 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1027](https://togithub.com/bufbuild/protoc-gen-validate/pull/1027)
-   Bump the go group with 1 update by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1026](https://togithub.com/bufbuild/protoc-gen-validate/pull/1026)
-   Bump the java group in /java with 1 update by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1032](https://togithub.com/bufbuild/protoc-gen-validate/pull/1032)
-   Enable gocritic linter by [@&#8203;mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/bufbuild/protoc-gen-validate/pull/1000](https://togithub.com/bufbuild/protoc-gen-validate/pull/1000)
-   Fix typos in proto comments by [@&#8203;WineChord](https://togithub.com/WineChord) in [https://github.com/bufbuild/protoc-gen-validate/pull/999](https://togithub.com/bufbuild/protoc-gen-validate/pull/999)
-   Enable unused linter by [@&#8203;mmorel-35](https://togithub.com/mmorel-35) in [https://github.com/bufbuild/protoc-gen-validate/pull/988](https://togithub.com/bufbuild/protoc-gen-validate/pull/988)
-   Bump the go group with 1 update by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1033](https://togithub.com/bufbuild/protoc-gen-validate/pull/1033)
-   Bump the go-tests group in /tests with 1 update by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1036](https://togithub.com/bufbuild/protoc-gen-validate/pull/1036)
-   Bump the java group in /java with 3 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1035](https://togithub.com/bufbuild/protoc-gen-validate/pull/1035)
-   Bump the github-actions group with 3 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1038](https://togithub.com/bufbuild/protoc-gen-validate/pull/1038)
-   Bump the java group in /java with 3 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1040](https://togithub.com/bufbuild/protoc-gen-validate/pull/1040)
-   Bump the github-actions group with 1 update by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1041](https://togithub.com/bufbuild/protoc-gen-validate/pull/1041)
-   Bump the java group in /java with 3 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1047](https://togithub.com/bufbuild/protoc-gen-validate/pull/1047)
-   Bump the go group with 1 update by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1045](https://togithub.com/bufbuild/protoc-gen-validate/pull/1045)
-   Bump the go-tests group in /tests with 1 update by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1046](https://togithub.com/bufbuild/protoc-gen-validate/pull/1046)
-   Bump the java group in /java with 2 updates by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/bufbuild/protoc-gen-validate/pull/1049](https://togithub.com/bufbuild/protoc-gen-validate/pull/1049)
-   Statically build all releases by [@&#8203;rodaine](https://togithub.com/rodaine) in [https://github.com/bufbuild/protoc-gen-validate/pull/1052](https://togithub.com/bufbuild/protoc-gen-validate/pull/1052)

#### New Contributors

-   [@&#8203;mmorel-35](https://togithub.com/mmorel-35) made their first contribution in [https://github.com/bufbuild/protoc-gen-validate/pull/908](https://togithub.com/bufbuild/protoc-gen-validate/pull/908)
-   [@&#8203;nicksnyder](https://togithub.com/nicksnyder) made their first contribution in [https://github.com/bufbuild/protoc-gen-validate/pull/1012](https://togithub.com/bufbuild/protoc-gen-validate/pull/1012)
-   [@&#8203;WineChord](https://togithub.com/WineChord) made their first contribution in [https://github.com/bufbuild/protoc-gen-validate/pull/999](https://togithub.com/bufbuild/protoc-gen-validate/pull/999)

**Full Changelog**: bufbuild/protoc-gen-validate@v1.0.2...v1.0.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ride-app/wallet-service).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjcuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyNy4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants