Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator bug fix, previously results in error: '[Validator] unknown … #834

Closed
wants to merge 1 commit into from

Conversation

ashishdock
Copy link

While running proto buf compiler with --validate_out="lang=go:./proto" was always giving error: '[Validator] unknown lang parameter'. Upon code analysis I found that this condition checks if the langParamValue is not empty and fails with the error message above.
The problem is that it fails even when it should not. Fixed issue, modified this condition to check if the lang parameter value is not equal to the expected language.
Hope this is fine.
Thanks!

…lang parameter'. Condition correction. Bug fixed. It works now.
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2023

CLA assistant check
All committers have signed the CLA.

@pkwarren
Copy link
Member

This behavior is by design - see the discussion here: #717 (comment)

The validate-{cpp,go,java} binaries are meant to be used without specifying a language option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants