Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break dependency on google::protobuf::UTF8FirstLetterNumBytes() #814

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

yanavlasov
Copy link
Contributor

@yanavlasov yanavlasov commented Mar 18, 2023

Remove dependency on the google::protobuf::UTF8FirstLetterNumBytes() to prep for the 22.x upgrade. The UTF8 utilities were removed from protobuf in 22.x.

Jump to 22.x protobuf is needed for the C++20 transition.

Since the needed code was very simple I have copied the functions from the protobuf to the validate.h file.

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@CLAassistant
Copy link

CLAassistant commented Mar 18, 2023

CLA assistant check
All committers have signed the CLA.

@elliotmjackson elliotmjackson merged commit bec8c04 into bufbuild:main Mar 20, 2023
@yanavlasov yanavlasov deleted the break-utf8-protobuf-dep branch March 21, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants