diff --git a/.drone.yml b/.drone.yml index 4dd6099a5151b..80282ce15e9b1 100644 --- a/.drone.yml +++ b/.drone.yml @@ -329,8 +329,35 @@ services: POSTGRES_PASSWORD: joomla_ut POSTGRES_DB: test_joomla +--- +kind: pipeline +name: package + +steps: + - name: packager + image: joomlaprojects/docker-images:packager + environment: + FTP_USERNAME: + from_secret: ftpusername + FTP_PASSWORD: + from_secret: ftppassword + FTP_HOSTNAME: ci.joomla.org + FTP_PORT: "21" + FTP_DEST_DIR: /artifacts + FTP_VERIFY: "false" + FTP_SECURE: "true" + HTTP_ROOT: "https://ci.joomla.org/artifacts" + DRONE_PULL_REQUEST: DRONE_PULL_REQUEST + DRONE_COMMIT: DRONE_COMMIT + GITHUB_TOKEN: + from_secret: github_token + commands: + - if [ $DRONE_REPO_NAME != 'joomla-cms' ]; then echo "The packager only runs on the joomla/joomla-cms repo"; exit 0; fi + - /bin/drone_build.sh + + --- kind: signature -hmac: 06035b7ce5a946d486d499e71b5c80538ae5272929f072b03cfadf4bb3b1fc15 +hmac: a0026c26e94c1443cb0de99edcd5c81a83981c99ea43e5254542c2e4214abe4e ... diff --git a/.github/FUNDING.yml b/.github/FUNDING.yml index 0be9be57ae051..1914e099bd843 100644 --- a/.github/FUNDING.yml +++ b/.github/FUNDING.yml @@ -1 +1,2 @@ +github: joomla custom: https://community.joomla.org/sponsorship-campaigns.html diff --git a/administrator/components/com_actionlogs/forms/filter_actionlogs.xml b/administrator/components/com_actionlogs/forms/filter_actionlogs.xml index c64c591b9274c..12de6deef59f2 100644 --- a/administrator/components/com_actionlogs/forms/filter_actionlogs.xml +++ b/administrator/components/com_actionlogs/forms/filter_actionlogs.xml @@ -12,7 +12,7 @@ @@ -20,7 +20,7 @@ @@ -28,7 +28,7 @@ diff --git a/administrator/components/com_actionlogs/src/Field/PlugininfoField.php b/administrator/components/com_actionlogs/src/Field/PlugininfoField.php index 09e1033921d84..9b96706f8c4fd 100644 --- a/administrator/components/com_actionlogs/src/Field/PlugininfoField.php +++ b/administrator/components/com_actionlogs/src/Field/PlugininfoField.php @@ -9,7 +9,7 @@ namespace Joomla\Component\Actionlogs\Administrator\Field; -defined('JPATH_BASE') or die; +defined('_JEXEC') or die; use Joomla\CMS\Factory; use Joomla\CMS\Form\FormField; diff --git a/administrator/components/com_actionlogs/tmpl/actionlogs/default.php b/administrator/components/com_actionlogs/tmpl/actionlogs/default.php index 5dff1d4205975..efe10ac126c00 100644 --- a/administrator/components/com_actionlogs/tmpl/actionlogs/default.php +++ b/administrator/components/com_actionlogs/tmpl/actionlogs/default.php @@ -36,7 +36,9 @@ diff --git a/administrator/components/com_admin/script.php b/administrator/components/com_admin/script.php index 77c7d2074b0a8..c06955a9a218e 100644 --- a/administrator/components/com_admin/script.php +++ b/administrator/components/com_admin/script.php @@ -6254,11 +6254,13 @@ public function convertTablesToUtf8mb4($doDbFixMsg = false) // Set required conversion status if ($db->hasUTF8mb4Support()) { - $converted = 2; + $convertedStep1 = 2; + $convertedStep2 = 4; } else { - $converted = 1; + $convertedStep1 = 1; + $convertedStep2 = 3; } // Check conversion status in database @@ -6284,73 +6286,123 @@ public function convertTablesToUtf8mb4($doDbFixMsg = false) return; } - // Nothing to do, saved conversion status from DB is equal to required - if ($convertedDB == $converted) + // Nothing to do, saved conversion status from DB is equal to required final status + if ($convertedDB == $convertedStep2) { return; } - // Step 1: Drop indexes later to be added again with column lengths limitations at step 2 - $fileName1 = JPATH_ROOT . '/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-01.sql'; + $converted = $convertedDB; + $hasErrors = false; - if (is_file($fileName1)) + // Steps 1 and 2: Convert core tables if necessary and not to be done at later steps + if ($convertedDB < $convertedStep1) { - $fileContents1 = @file_get_contents($fileName1); - $queries1 = $db->splitSql($fileContents1); + // Step 1: Drop indexes later to be added again with column lengths limitations at step 2 + $fileName1 = JPATH_ROOT . '/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-01.sql'; - if (!empty($queries1)) + if (is_file($fileName1)) { - foreach ($queries1 as $query1) + $fileContents1 = @file_get_contents($fileName1); + $queries1 = $db->splitSql($fileContents1); + + if (!empty($queries1)) { - try + foreach ($queries1 as $query1) { - $db->setQuery($query1)->execute(); + try + { + $db->setQuery($query1)->execute(); + } + catch (Exception $e) + { + // If the query fails we will go on. It just means the index to be dropped does not exist. + } } - catch (Exception $e) + } + } + + // Step 2: Perform the index modifications and conversions + $fileName2 = JPATH_ROOT . '/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-02.sql'; + + if (is_file($fileName2)) + { + $fileContents2 = @file_get_contents($fileName2); + $queries2 = $db->splitSql($fileContents2); + + if (!empty($queries2)) + { + foreach ($queries2 as $query2) { - // If the query fails we will go on. It just means the index to be dropped does not exist. + try + { + $db->setQuery($db->convertUtf8mb4QueryToUtf8($query2))->execute(); + } + catch (Exception $e) + { + $hasErrors = true; + + // Still render the error message from the Exception object + JFactory::getApplication()->enqueueMessage($e->getMessage(), 'error'); + } } } } - } - // Step 2: Perform the index modifications and conversions - $fileName2 = JPATH_ROOT . '/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-02.sql'; + if (!$hasErrors) + { + $converted = $convertedStep1; + } + } - if (is_file($fileName2)) + // Step 3: Convert action logs and privacy suite tables if necessary and conversion hasn't failed before + if (!$hasErrors && $convertedDB < $convertedStep2) { - $fileContents2 = @file_get_contents($fileName2); - $queries2 = $db->splitSql($fileContents2); + $fileName3 = JPATH_ROOT . '/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-03.sql'; - if (!empty($queries2)) + if (is_file($fileName3)) { - foreach ($queries2 as $query2) + $fileContents3 = @file_get_contents($fileName3); + $queries3 = $db->splitSql($fileContents3); + + if (!empty($queries3)) { - try + foreach ($queries3 as $query3) { - $db->setQuery($db->convertUtf8mb4QueryToUtf8($query2))->execute(); - } - catch (Exception $e) - { - $converted = 0; + try + { + $db->setQuery($db->convertUtf8mb4QueryToUtf8($query3))->execute(); + } + catch (Exception $e) + { + $hasErrors = true; - // Still render the error message from the Exception object - Factory::getApplication()->enqueueMessage($e->getMessage(), 'error'); + // Still render the error message from the Exception object + JFactory::getApplication()->enqueueMessage($e->getMessage(), 'error'); + } } } } + + if (!$hasErrors) + { + $converted = $convertedStep2; + } } - if ($doDbFixMsg && $converted == 0) + if ($doDbFixMsg && $hasErrors) { // Show an error message telling to check database problems Factory::getApplication()->enqueueMessage(Text::_('JLIB_DATABASE_ERROR_DATABASE_UPGRADE_FAILED'), 'error'); } - // Set flag in database if the update is done. - $db->setQuery('UPDATE ' . $db->quoteName('#__utf8_conversion') - . ' SET ' . $db->quoteName('converted') . ' = ' . $converted . ';' - )->execute(); + // Set flag in database if the conversion status has changed. + if ($converted != $convertedDB) + { + $db->setQuery('UPDATE ' . $db->quoteName('#__utf8_conversion') + . ' SET ' . $db->quoteName('converted') . ' = ' . $converted . ';' + )->execute(); + } } /** diff --git a/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-02.sql b/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-02.sql index 3edcbd3e7978a..022f77c4a40eb 100644 --- a/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-02.sql +++ b/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-02.sql @@ -41,12 +41,12 @@ ALTER TABLE `#__newsfeeds` MODIFY `alias` varchar(400) NOT NULL DEFAULT ''; ALTER TABLE `#__tags` MODIFY `path` varchar(400) NOT NULL DEFAULT ''; ALTER TABLE `#__tags` MODIFY `alias` varchar(400) NOT NULL DEFAULT ''; ALTER TABLE `#__ucm_content` MODIFY `core_type_alias` varchar(400) NOT NULL DEFAULT '' COMMENT 'FK to the content types table'; -ALTER TABLE `#__ucm_content` MODIFY `core_title` varchar(400) NOT NULL; +ALTER TABLE `#__ucm_content` MODIFY `core_title` varchar(400) NOT NULL DEFAULT ''; ALTER TABLE `#__ucm_content` MODIFY `core_alias` varchar(400) NOT NULL DEFAULT ''; ALTER TABLE `#__users` MODIFY `name` varchar(400) NOT NULL DEFAULT ''; -- --- Step 2.2: Convert all tables to utf8mb4 chracter set with utf8mb4_unicode_ci collation +-- Step 2.2: Convert all tables to utf8mb4 character set with utf8mb4_unicode_ci collation -- except #__finder_xxx tables, those will have utf8mb4_general_ci collation. -- Note: The database driver for mysql will change utf8mb4 to utf8 if utf8mb4 is not supported -- diff --git a/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-03.sql b/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-03.sql new file mode 100644 index 0000000000000..93fcf9ee3d18d --- /dev/null +++ b/administrator/components/com_admin/sql/others/mysql/utf8mb4-conversion-03.sql @@ -0,0 +1,33 @@ +-- +-- Step 3 of the UTF-8 Multibyte (utf8mb4) conversion for MySQL +-- +-- Convert the tables for action logs and the privacy suite which have been +-- forgotten to be added to the utf8mb4 conversion before. +-- +-- This file here will be processed with reporting exceptions, in opposite +-- to the file for step 1. +-- + +-- +-- Step 3.1: Convert action logs and privacy suite tables to utf8mb4 character set with +-- utf8mb4_unicode_ci collation +-- Note: The database driver for mysql will change utf8mb4 to utf8 if utf8mb4 is not supported +-- + +ALTER TABLE `#__action_logs` CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__action_logs_extensions` CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__action_logs_users` CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__action_log_config` CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__privacy_consents` CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__privacy_requests` CONVERT TO CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; + +-- +-- Step 3.2: Set default character set and collation for previously converted tables +-- + +ALTER TABLE `#__action_logs` DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__action_logs_extensions` DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__action_logs_users` DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__action_log_config` DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__privacy_consents` DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; +ALTER TABLE `#__privacy_requests` DEFAULT CHARACTER SET utf8mb4 COLLATE utf8mb4_unicode_ci; diff --git a/administrator/components/com_associations/forms/filter_associations.xml b/administrator/components/com_associations/forms/filter_associations.xml index 99bd94918208d..f723b314f800f 100644 --- a/administrator/components/com_associations/forms/filter_associations.xml +++ b/administrator/components/com_associations/forms/filter_associations.xml @@ -33,7 +33,7 @@ @@ -42,7 +42,7 @@ @@ -63,7 +63,7 @@ @@ -72,7 +72,7 @@ sef); + $text = $language->lang_code; $tooltip = '' . htmlspecialchars($language->title, ENT_QUOTES, 'UTF-8') . '
' . htmlspecialchars($title, ENT_QUOTES, 'UTF-8') . '

' . $additional; diff --git a/administrator/components/com_associations/tmpl/associations/default.php b/administrator/components/com_associations/tmpl/associations/default.php index bde3655c35088..d357e80d170d8 100644 --- a/administrator/components/com_associations/tmpl/associations/default.php +++ b/administrator/components/com_associations/tmpl/associations/default.php @@ -50,25 +50,27 @@
- , + , + , +
typeSupports['state'])) : ?> - - - typeFields['menutype'])) : ?> @@ -81,7 +83,7 @@ - diff --git a/administrator/components/com_associations/tmpl/associations/modal.php b/administrator/components/com_associations/tmpl/associations/modal.php index 9aa4b337a4762..4e44a2f858f32 100644 --- a/administrator/components/com_associations/tmpl/associations/modal.php +++ b/administrator/components/com_associations/tmpl/associations/modal.php @@ -53,19 +53,21 @@
- , + , + , +
+ + + +
typeSupports['state'])) : ?> - - - diff --git a/administrator/components/com_banners/forms/filter_banners.xml b/administrator/components/com_banners/forms/filter_banners.xml index 338ae85cc3568..980b0c354b0eb 100644 --- a/administrator/components/com_banners/forms/filter_banners.xml +++ b/administrator/components/com_banners/forms/filter_banners.xml @@ -13,7 +13,7 @@ @@ -22,7 +22,7 @@ @@ -43,7 +43,7 @@ @@ -53,7 +53,7 @@ @@ -22,7 +22,7 @@ @@ -34,7 +34,7 @@ @@ -46,7 +46,7 @@ getState('filter.search')) { - $search = '%' . strtolower($search) . '%'; + $search = '%' . StringHelper::strtolower($search) . '%'; $query->where('(LOWER(' . $db->quoteName('b.name') . ') LIKE :search1 OR LOWER(' . $db->quoteName('cl.name') . ') LIKE :search2)') ->bind([':search1', ':search2'], $search); } diff --git a/administrator/components/com_banners/src/Service/Html/Banner.php b/administrator/components/com_banners/src/Service/Html/Banner.php index 59d2bcaac3d7f..95227d09a61d1 100644 --- a/administrator/components/com_banners/src/Service/Html/Banner.php +++ b/administrator/components/com_banners/src/Service/Html/Banner.php @@ -9,7 +9,7 @@ namespace Joomla\Component\Banners\Administrator\Service\Html; -defined('JPATH_BASE') or die; +defined('_JEXEC') or die; use Joomla\CMS\Factory; use Joomla\CMS\HTML\HTMLHelper; diff --git a/administrator/components/com_banners/tmpl/banners/default.php b/administrator/components/com_banners/tmpl/banners/default.php index ff799818f1d60..817616f4c30ee 100644 --- a/administrator/components/com_banners/tmpl/banners/default.php +++ b/administrator/components/com_banners/tmpl/banners/default.php @@ -49,17 +49,19 @@
- , + , + , +
+ + @@ -81,7 +83,7 @@ +
- - -
- , + , + , +
+ + + diff --git a/administrator/components/com_banners/tmpl/clients/default.php b/administrator/components/com_banners/tmpl/clients/default.php index e61267574f472..707adc538b509 100644 --- a/administrator/components/com_banners/tmpl/clients/default.php +++ b/administrator/components/com_banners/tmpl/clients/default.php @@ -50,20 +50,22 @@ - - -
- , + , + , +
+ + + diff --git a/administrator/components/com_banners/tmpl/tracks/default.php b/administrator/components/com_banners/tmpl/tracks/default.php index 8e870a0779dc7..b90f91877e090 100644 --- a/administrator/components/com_banners/tmpl/tracks/default.php +++ b/administrator/components/com_banners/tmpl/tracks/default.php @@ -32,14 +32,16 @@ -
- , + , + , +
+ diff --git a/administrator/components/com_cache/tmpl/cache/default.php b/administrator/components/com_cache/tmpl/cache/default.php index 0068affab2f3a..95bf9146438ee 100644 --- a/administrator/components/com_cache/tmpl/cache/default.php +++ b/administrator/components/com_cache/tmpl/cache/default.php @@ -39,11 +39,13 @@ -
- , + , + , +
+ diff --git a/administrator/components/com_categories/forms/filter_categories.xml b/administrator/components/com_categories/forms/filter_categories.xml index 0f45caadedf85..c5eaf7c42b37e 100644 --- a/administrator/components/com_categories/forms/filter_categories.xml +++ b/administrator/components/com_categories/forms/filter_categories.xml @@ -15,7 +15,7 @@ @@ -24,7 +24,7 @@ @@ -33,7 +33,7 @@ @@ -43,7 +43,7 @@ setState($this->getName() . '.id', $table->id); + if (Factory::getApplication()->input->get('task') == 'editAssociations') + { + return $this->redirectToAssociations($data); + } + // Clear the cache $this->cleanCache(); diff --git a/administrator/components/com_categories/src/Service/HTML/AdministratorService.php b/administrator/components/com_categories/src/Service/HTML/AdministratorService.php index d2070e2ba7136..d78cbba80b3a4 100644 --- a/administrator/components/com_categories/src/Service/HTML/AdministratorService.php +++ b/administrator/components/com_categories/src/Service/HTML/AdministratorService.php @@ -90,7 +90,7 @@ public function association($catid, $extension = 'com_content') { if (in_array($item->lang_code, $content_languages)) { - $text = $item->lang_sef ? strtoupper($item->lang_sef) : 'XX'; + $text = $item->lang_code; $url = Route::_('index.php?option=com_categories&task=category.edit&id=' . (int) $item->id . '&extension=' . $extension); $tooltip = '' . htmlspecialchars($item->language_title, ENT_QUOTES, 'UTF-8') . '
' . htmlspecialchars($item->title, ENT_QUOTES, 'UTF-8'); diff --git a/administrator/components/com_categories/tmpl/categories/default.php b/administrator/components/com_categories/tmpl/categories/default.php index 9647d730084b8..a0a8e5a6e6239 100644 --- a/administrator/components/com_categories/tmpl/categories/default.php +++ b/administrator/components/com_categories/tmpl/categories/default.php @@ -65,17 +65,19 @@ - - -
- , + , + , +
+ + + diff --git a/administrator/components/com_categories/tmpl/categories/modal.php b/administrator/components/com_categories/tmpl/categories/modal.php index a848e7b8b8563..d110c26de0f64 100644 --- a/administrator/components/com_categories/tmpl/categories/modal.php +++ b/administrator/components/com_categories/tmpl/categories/modal.php @@ -46,11 +46,13 @@ - - - diff --git a/administrator/components/com_checkin/tmpl/checkin/default.php b/administrator/components/com_checkin/tmpl/checkin/default.php index 00bf5b222cda5..86a6b22221b65 100644 --- a/administrator/components/com_checkin/tmpl/checkin/default.php +++ b/administrator/components/com_checkin/tmpl/checkin/default.php @@ -27,11 +27,13 @@ total > 0) : ?>
- , + , + , +
+ @@ -59,10 +61,10 @@ + +
-
- , + , + , +
+ diff --git a/administrator/components/com_config/src/Field/ConfigComponentsField.php b/administrator/components/com_config/src/Field/ConfigComponentsField.php index 03123ac2e688e..5476a127f228c 100644 --- a/administrator/components/com_config/src/Field/ConfigComponentsField.php +++ b/administrator/components/com_config/src/Field/ConfigComponentsField.php @@ -9,7 +9,7 @@ namespace Joomla\Component\Config\Administrator\Field; -defined('JPATH_BASE') or die; +defined('_JEXEC') or die; use Joomla\CMS\Factory; use Joomla\CMS\Filesystem\File; diff --git a/administrator/components/com_config/src/Field/FiltersField.php b/administrator/components/com_config/src/Field/FiltersField.php index 663ff5cf2dbbe..b42e7818a4606 100644 --- a/administrator/components/com_config/src/Field/FiltersField.php +++ b/administrator/components/com_config/src/Field/FiltersField.php @@ -9,7 +9,7 @@ namespace Joomla\Component\Config\Administrator\Field; -defined('JPATH_BASE') or die; +defined('_JEXEC') or die; use Joomla\CMS\Factory; use Joomla\CMS\Form\FormField; diff --git a/administrator/components/com_config/src/View/Component/HtmlView.php b/administrator/components/com_config/src/View/Component/HtmlView.php index e0732347d0219..03a0bf5a3169d 100644 --- a/administrator/components/com_config/src/View/Component/HtmlView.php +++ b/administrator/components/com_config/src/View/Component/HtmlView.php @@ -127,6 +127,10 @@ protected function addToolbar() ToolbarHelper::divider(); ToolbarHelper::cancel('component.cancel', 'JTOOLBAR_CLOSE'); ToolbarHelper::divider(); - ToolbarHelper::help('JHELP_COMPONENTS_' . $this->currentComponent . '_OPTIONS'); + + $helpUrl = $this->form->getData()->get('helpURL'); + $helpKey = (string) $this->form->getXml()->config->help['key']; + $helpKey = $helpKey ?: 'JHELP_COMPONENTS_' . strtoupper($this->currentComponent) . '_OPTIONS'; + ToolbarHelper::help($helpKey, (boolean) $helpUrl, null, $this->currentComponent); } } diff --git a/administrator/components/com_contact/forms/filter_contacts.xml b/administrator/components/com_contact/forms/filter_contacts.xml index acf7e4c3df266..6daff8121058a 100644 --- a/administrator/components/com_contact/forms/filter_contacts.xml +++ b/administrator/components/com_contact/forms/filter_contacts.xml @@ -15,7 +15,7 @@ @@ -37,7 +37,7 @@ @@ -57,7 +57,7 @@ @@ -67,7 +67,7 @@ lang_code, $content_languages)) { - $text = strtoupper($item->lang_sef); + $text = $item->lang_code; $url = Route::_('index.php?option=com_contact&task=contact.edit&id=' . (int) $item->id); $tooltip = '' . htmlspecialchars($item->language_title, ENT_QUOTES, 'UTF-8') . '
' . htmlspecialchars($item->title, ENT_QUOTES, 'UTF-8') . '
' . Text::sprintf('JCATEGORY_SPRINTF', $item->category_title); diff --git a/administrator/components/com_contact/tmpl/contacts/default.php b/administrator/components/com_contact/tmpl/contacts/default.php index a2b5e0c6294fe..f3a841b834ac8 100644 --- a/administrator/components/com_contact/tmpl/contacts/default.php +++ b/administrator/components/com_contact/tmpl/contacts/default.php @@ -46,20 +46,22 @@ - - - -
- , + , + , +
+ + + + diff --git a/administrator/components/com_contact/tmpl/contacts/modal.php b/administrator/components/com_contact/tmpl/contacts/modal.php index bc2fd1ea4c455..f2020fb9ae933 100644 --- a/administrator/components/com_contact/tmpl/contacts/modal.php +++ b/administrator/components/com_contact/tmpl/contacts/modal.php @@ -56,10 +56,12 @@ - -
- , + , + , +
+ @@ -68,7 +70,7 @@ + diff --git a/administrator/components/com_content/forms/filter_articles.xml b/administrator/components/com_content/forms/filter_articles.xml index 9401ab96a5bc4..7629cc2ad3900 100644 --- a/administrator/components/com_content/forms/filter_articles.xml +++ b/administrator/components/com_content/forms/filter_articles.xml @@ -13,7 +13,7 @@ @@ -92,7 +92,7 @@ name="tag" type="tag" multiple="true" - label="JOPTION_SELECT_TAG" + label="JTAG" hint="JOPTION_SELECT_TAG" mode="nested" custom="false" @@ -102,7 +102,7 @@ @@ -77,7 +77,7 @@ id . "(id, title, catid, object, url, languag $class = $this->required ? ' class="required modal-value"' : ''; $html .= ''; + . '" data-text="' . htmlspecialchars(Text::_('COM_CONTENT_SELECT_AN_ARTICLE'), ENT_COMPAT, 'UTF-8') . '" value="' . $value . '">'; return $html; } diff --git a/administrator/components/com_content/src/Service/HTML/AdministratorService.php b/administrator/components/com_content/src/Service/HTML/AdministratorService.php index dd5f06e2adf23..98295295fb0aa 100644 --- a/administrator/components/com_content/src/Service/HTML/AdministratorService.php +++ b/administrator/components/com_content/src/Service/HTML/AdministratorService.php @@ -89,7 +89,7 @@ public function association($articleid) { if (in_array($item->lang_code, $content_languages)) { - $text = $item->lang_sef ? strtoupper($item->lang_sef) : 'XX'; + $text = $item->lang_code; $url = Route::_('index.php?option=com_content&task=article.edit&id=' . (int) $item->id); $tooltip = '' . htmlspecialchars($item->language_title, ENT_QUOTES, 'UTF-8') . '
' . htmlspecialchars($item->title, ENT_QUOTES, 'UTF-8') . '
' . Text::sprintf('JCATEGORY_SPRINTF', $item->category_title); diff --git a/administrator/components/com_content/tmpl/articles/default.php b/administrator/components/com_content/tmpl/articles/default.php index 7569abf32ee93..dac644ddec12f 100644 --- a/administrator/components/com_content/tmpl/articles/default.php +++ b/administrator/components/com_content/tmpl/articles/default.php @@ -99,20 +99,22 @@ - - - -
- , + , + , +
+ + + + diff --git a/administrator/components/com_content/tmpl/articles/modal.php b/administrator/components/com_content/tmpl/articles/modal.php index 60ff3bae12ec4..3e51c9b281d65 100644 --- a/administrator/components/com_content/tmpl/articles/modal.php +++ b/administrator/components/com_content/tmpl/articles/modal.php @@ -56,11 +56,13 @@ - - - diff --git a/administrator/components/com_content/tmpl/featured/default.php b/administrator/components/com_content/tmpl/featured/default.php index 34ea936023277..981771af1dcdf 100644 --- a/administrator/components/com_content/tmpl/featured/default.php +++ b/administrator/components/com_content/tmpl/featured/default.php @@ -86,20 +86,22 @@
- , + , + , +
+ @@ -69,13 +71,13 @@ + +
- - - - - - - -
- , + , + , +
+ + + + diff --git a/administrator/components/com_contenthistory/tmpl/history/modal.php b/administrator/components/com_contenthistory/tmpl/history/modal.php index 965452ef952f6..30049696e08b8 100644 --- a/administrator/components/com_contenthistory/tmpl/history/modal.php +++ b/administrator/components/com_contenthistory/tmpl/history/modal.php @@ -74,19 +74,19 @@
+ + + + diff --git a/administrator/components/com_csp/forms/filter_reports.xml b/administrator/components/com_csp/forms/filter_reports.xml index d63e24b43ef3e..72d1722e0e194 100644 --- a/administrator/components/com_csp/forms/filter_reports.xml +++ b/administrator/components/com_csp/forms/filter_reports.xml @@ -13,7 +13,7 @@ @@ -23,7 +23,7 @@ diff --git a/administrator/components/com_fields/forms/filter_fields.xml b/administrator/components/com_fields/forms/filter_fields.xml index e82c536760b92..71962f9641073 100644 --- a/administrator/components/com_fields/forms/filter_fields.xml +++ b/administrator/components/com_fields/forms/filter_fields.xml @@ -22,7 +22,7 @@ @@ -31,7 +31,7 @@ @@ -41,7 +41,7 @@ @@ -51,7 +51,7 @@ @@ -60,7 +60,7 @@ diff --git a/administrator/components/com_fields/forms/filter_groups.xml b/administrator/components/com_fields/forms/filter_groups.xml index 5251d595419ad..ea7095cfc80f8 100644 --- a/administrator/components/com_fields/forms/filter_groups.xml +++ b/administrator/components/com_fields/forms/filter_groups.xml @@ -21,7 +21,7 @@ @@ -30,7 +30,7 @@ @@ -39,7 +39,7 @@ diff --git a/administrator/components/com_fields/src/Plugin/FieldsPlugin.php b/administrator/components/com_fields/src/Plugin/FieldsPlugin.php index b5bfa1a8f0cd7..817cea59ba11e 100644 --- a/administrator/components/com_fields/src/Plugin/FieldsPlugin.php +++ b/administrator/components/com_fields/src/Plugin/FieldsPlugin.php @@ -148,6 +148,11 @@ public function onCustomFieldsPrepareField($context, $item, $field) // Get the path for the layout file $path = PluginHelper::getLayoutPath('fields', $this->_name, $field->type); + if (!file_exists($path)) + { + $path = JPluginHelper::getLayoutPath('fields', $this->_name, $field->type); + } + // Render the layout ob_start(); include $path; diff --git a/administrator/components/com_fields/tmpl/fields/default.php b/administrator/components/com_fields/tmpl/fields/default.php index 6bb56c1cd586c..bf66169e066b1 100644 --- a/administrator/components/com_fields/tmpl/fields/default.php +++ b/administrator/components/com_fields/tmpl/fields/default.php @@ -60,17 +60,19 @@
- , + , + , +
- - -
- , + , + , +
+ + + diff --git a/administrator/components/com_fields/tmpl/fields/modal.php b/administrator/components/com_fields/tmpl/fields/modal.php index 7695b5d2f78fe..817fbb9572539 100644 --- a/administrator/components/com_fields/tmpl/fields/modal.php +++ b/administrator/components/com_fields/tmpl/fields/modal.php @@ -40,17 +40,19 @@ - - - diff --git a/administrator/components/com_fields/tmpl/groups/default.php b/administrator/components/com_fields/tmpl/groups/default.php index 1b0c2e9ec0234..eb2be85f2db06 100644 --- a/administrator/components/com_fields/tmpl/groups/default.php +++ b/administrator/components/com_fields/tmpl/groups/default.php @@ -58,17 +58,19 @@
- , + , + , +
+ + @@ -62,7 +64,7 @@ +
- - - - diff --git a/administrator/components/com_finder/forms/filter_filters.xml b/administrator/components/com_finder/forms/filter_filters.xml index f6ece73a8ddda..a473121d38da1 100644 --- a/administrator/components/com_finder/forms/filter_filters.xml +++ b/administrator/components/com_finder/forms/filter_filters.xml @@ -13,7 +13,7 @@ diff --git a/administrator/components/com_finder/forms/filter_index.xml b/administrator/components/com_finder/forms/filter_index.xml index acc1c4cd1b446..a4d7f578a696e 100644 --- a/administrator/components/com_finder/forms/filter_index.xml +++ b/administrator/components/com_finder/forms/filter_index.xml @@ -13,7 +13,7 @@ @@ -23,7 +23,7 @@ @@ -32,7 +32,7 @@ @@ -41,7 +41,7 @@ diff --git a/administrator/components/com_finder/forms/filter_maps.xml b/administrator/components/com_finder/forms/filter_maps.xml index b37a0f14427b7..5269029a5bdec 100644 --- a/administrator/components/com_finder/forms/filter_maps.xml +++ b/administrator/components/com_finder/forms/filter_maps.xml @@ -13,7 +13,7 @@ @@ -23,7 +23,7 @@ @@ -31,7 +31,7 @@
- , + , + , +
+ + + @@ -82,7 +84,7 @@ +
- - - diff --git a/administrator/components/com_finder/tmpl/index/default.php b/administrator/components/com_finder/tmpl/index/default.php index 2a0657986edd8..fc1f7e81d8c58 100644 --- a/administrator/components/com_finder/tmpl/index/default.php +++ b/administrator/components/com_finder/tmpl/index/default.php @@ -38,14 +38,16 @@
- , + , + , +
+ + @@ -58,7 +60,7 @@ +
- - - - diff --git a/administrator/components/com_finder/tmpl/maps/default.php b/administrator/components/com_finder/tmpl/maps/default.php index 50ec98956756e..ea4d7b2186520 100644 --- a/administrator/components/com_finder/tmpl/maps/default.php +++ b/administrator/components/com_finder/tmpl/maps/default.php @@ -37,29 +37,31 @@
- , + , + , +
+ + @@ -62,10 +64,10 @@ + +
- - - - - diff --git a/administrator/components/com_finder/tmpl/searches/default.php b/administrator/components/com_finder/tmpl/searches/default.php index 5593d811b00bc..8a8f04f49300f 100644 --- a/administrator/components/com_finder/tmpl/searches/default.php +++ b/administrator/components/com_finder/tmpl/searches/default.php @@ -33,17 +33,19 @@
- , + , + , +
+ + + + +
- - diff --git a/administrator/components/com_installer/forms/filter_database.xml b/administrator/components/com_installer/forms/filter_database.xml index be47f97e80212..1bb857c1e8638 100644 --- a/administrator/components/com_installer/forms/filter_database.xml +++ b/administrator/components/com_installer/forms/filter_database.xml @@ -13,7 +13,7 @@ @@ -22,7 +22,7 @@ @@ -31,7 +31,7 @@ diff --git a/administrator/components/com_installer/forms/filter_discover.xml b/administrator/components/com_installer/forms/filter_discover.xml index 96645b8f6d70b..886077e816614 100644 --- a/administrator/components/com_installer/forms/filter_discover.xml +++ b/administrator/components/com_installer/forms/filter_discover.xml @@ -13,7 +13,7 @@ @@ -22,7 +22,7 @@ @@ -31,7 +31,7 @@ diff --git a/administrator/components/com_installer/forms/filter_manage.xml b/administrator/components/com_installer/forms/filter_manage.xml index 13e7d76fe4d0d..950370ea07c6a 100644 --- a/administrator/components/com_installer/forms/filter_manage.xml +++ b/administrator/components/com_installer/forms/filter_manage.xml @@ -13,7 +13,7 @@ @@ -22,7 +22,7 @@ @@ -31,7 +31,7 @@ @@ -40,7 +40,7 @@ @@ -49,7 +49,7 @@ diff --git a/administrator/components/com_installer/forms/filter_update.xml b/administrator/components/com_installer/forms/filter_update.xml index 8ac32ca3da59e..1f2cc40d172ae 100644 --- a/administrator/components/com_installer/forms/filter_update.xml +++ b/administrator/components/com_installer/forms/filter_update.xml @@ -12,7 +12,7 @@ @@ -20,7 +20,7 @@ @@ -28,7 +28,7 @@ diff --git a/administrator/components/com_installer/forms/filter_updatesites.xml b/administrator/components/com_installer/forms/filter_updatesites.xml index 42c5d1f0dca57..f3f10f16b51e3 100644 --- a/administrator/components/com_installer/forms/filter_updatesites.xml +++ b/administrator/components/com_installer/forms/filter_updatesites.xml @@ -12,7 +12,7 @@ @@ -23,7 +23,7 @@ @@ -31,7 +31,7 @@ @@ -39,7 +39,7 @@ diff --git a/administrator/components/com_installer/tmpl/database/default.php b/administrator/components/com_installer/tmpl/database/default.php index 905ae2f7c77b4..d9f0b55a072ec 100644 --- a/administrator/components/com_installer/tmpl/database/default.php +++ b/administrator/components/com_installer/tmpl/database/default.php @@ -35,11 +35,13 @@
- , + , + , +
+ +
- - diff --git a/administrator/components/com_installer/tmpl/discover/default.php b/administrator/components/com_installer/tmpl/discover/default.php index 6f2c7b02623de..83bc2a03bc0db 100644 --- a/administrator/components/com_installer/tmpl/discover/default.php +++ b/administrator/components/com_installer/tmpl/discover/default.php @@ -43,11 +43,13 @@
- , + , + , +
+ @@ -63,7 +65,7 @@ +
- - - diff --git a/administrator/components/com_installer/tmpl/install/default.php b/administrator/components/com_installer/tmpl/install/default.php index d3b37aa8649f9..51aadaaa40953 100644 --- a/administrator/components/com_installer/tmpl/install/default.php +++ b/administrator/components/com_installer/tmpl/install/default.php @@ -23,6 +23,9 @@ HTMLHelper::_('stylesheet', 'com_installer/installer.css', ['version' => 'auto', 'relative' => true]); HTMLHelper::_('script', 'com_installer/installer.js', ['version' => 'auto', 'relative' => true]); +$this->document->getWebAssetManager() + ->useScript('webcomponent.core-loader'); + $app = Factory::getApplication(); ?> diff --git a/administrator/components/com_installer/tmpl/languages/default.php b/administrator/components/com_installer/tmpl/languages/default.php index c45b461d790b9..4c5390644f001 100644 --- a/administrator/components/com_installer/tmpl/languages/default.php +++ b/administrator/components/com_installer/tmpl/languages/default.php @@ -34,7 +34,9 @@
- , + , + , +
+ @@ -65,13 +67,13 @@ + +
@@ -45,7 +47,7 @@ -
- , + , + , +
+ diff --git a/administrator/components/com_installer/tmpl/manage/default.php b/administrator/components/com_installer/tmpl/manage/default.php index e331a8203674e..e14659ee973b6 100644 --- a/administrator/components/com_installer/tmpl/manage/default.php +++ b/administrator/components/com_installer/tmpl/manage/default.php @@ -40,14 +40,16 @@ - - - - diff --git a/administrator/components/com_installer/tmpl/update/default.php b/administrator/components/com_installer/tmpl/update/default.php index 7d3f2ef46221a..5c041f39c24b4 100644 --- a/administrator/components/com_installer/tmpl/update/default.php +++ b/administrator/components/com_installer/tmpl/update/default.php @@ -40,11 +40,13 @@
- , + , + , +
+ + @@ -71,13 +73,13 @@ + +
- - diff --git a/administrator/components/com_installer/tmpl/updatesites/default.php b/administrator/components/com_installer/tmpl/updatesites/default.php index d8dc554c5537a..15c579d107dcd 100644 --- a/administrator/components/com_installer/tmpl/updatesites/default.php +++ b/administrator/components/com_installer/tmpl/updatesites/default.php @@ -38,20 +38,22 @@
- , + , + , +
+ @@ -71,7 +73,7 @@ +
- - -
- , + , + , +
+ + + diff --git a/administrator/components/com_joomlaupdate/tmpl/update/finaliseconfirm.php b/administrator/components/com_joomlaupdate/tmpl/update/finaliseconfirm.php index 5611736ccc41e..4f467741d2f6a 100644 --- a/administrator/components/com_joomlaupdate/tmpl/update/finaliseconfirm.php +++ b/administrator/components/com_joomlaupdate/tmpl/update/finaliseconfirm.php @@ -69,7 +69,7 @@
- + diff --git a/administrator/components/com_joomlaupdate/tmpl/upload/captive.php b/administrator/components/com_joomlaupdate/tmpl/upload/captive.php index 7ac8fa4c04f5b..a8c9a0abe4303 100644 --- a/administrator/components/com_joomlaupdate/tmpl/upload/captive.php +++ b/administrator/components/com_joomlaupdate/tmpl/upload/captive.php @@ -69,7 +69,7 @@
- + diff --git a/administrator/components/com_languages/forms/filter_languages.xml b/administrator/components/com_languages/forms/filter_languages.xml index 3ff87af4bfaa8..d42d0f6a6c8ad 100644 --- a/administrator/components/com_languages/forms/filter_languages.xml +++ b/administrator/components/com_languages/forms/filter_languages.xml @@ -12,7 +12,7 @@ @@ -21,7 +21,7 @@ diff --git a/administrator/components/com_languages/forms/filter_overrides.xml b/administrator/components/com_languages/forms/filter_overrides.xml index f370d2d53b285..eeb5c68cefc31 100644 --- a/administrator/components/com_languages/forms/filter_overrides.xml +++ b/administrator/components/com_languages/forms/filter_overrides.xml @@ -16,7 +16,7 @@ type="text" inputmode="search" label="JSEARCH_FILTER" - description="COM_LANGUAGES_SEARCH_IN_TITLE" + description="COM_LANGUAGES_VIEW_OVERRIDES_FILTER_SEARCH_DESC" hint="JSEARCH_FILTER" /> diff --git a/administrator/components/com_languages/src/Field/LanguageclientField.php b/administrator/components/com_languages/src/Field/LanguageclientField.php index a625202f6cdba..4edcc8ce2ef79 100644 --- a/administrator/components/com_languages/src/Field/LanguageclientField.php +++ b/administrator/components/com_languages/src/Field/LanguageclientField.php @@ -9,7 +9,7 @@ namespace Joomla\Component\Languages\Administrator\Field; -defined('JPATH_BASE') or die; +defined('_JEXEC') or die; use Joomla\CMS\Form\Field\ListField; use Joomla\CMS\Language\LanguageHelper; diff --git a/administrator/components/com_languages/tmpl/installed/default.php b/administrator/components/com_languages/tmpl/installed/default.php index 2e8afa3884171..a8aa2a1cc57b8 100644 --- a/administrator/components/com_languages/tmpl/installed/default.php +++ b/administrator/components/com_languages/tmpl/installed/default.php @@ -34,17 +34,19 @@ - - -
- , + , + , +
+   + + diff --git a/administrator/components/com_languages/tmpl/languages/default.php b/administrator/components/com_languages/tmpl/languages/default.php index af197ec2c56e4..a25dc7dd1d73c 100644 --- a/administrator/components/com_languages/tmpl/languages/default.php +++ b/administrator/components/com_languages/tmpl/languages/default.php @@ -43,17 +43,19 @@ - - -
- , + , + , +
+ + + diff --git a/administrator/components/com_languages/tmpl/overrides/default.php b/administrator/components/com_languages/tmpl/overrides/default.php index 223dcfd36ac9f..8dcc80cfa1878 100644 --- a/administrator/components/com_languages/tmpl/overrides/default.php +++ b/administrator/components/com_languages/tmpl/overrides/default.php @@ -41,14 +41,16 @@ - -
- , + , + , +
+ + diff --git a/administrator/components/com_mails/forms/filter_templates.xml b/administrator/components/com_mails/forms/filter_templates.xml index 17f85dc9d3c51..429ee29cc8ed2 100644 --- a/administrator/components/com_mails/forms/filter_templates.xml +++ b/administrator/components/com_mails/forms/filter_templates.xml @@ -13,7 +13,7 @@ @@ -23,7 +23,7 @@ - - - - -
- , + , + , +
+ @@ -46,7 +48,7 @@ + @@ -86,7 +88,7 @@ image) : ?> image . '.gif', $language->title_native, array('title' => $language->title_native), true); ?> - sef); ?> + lang_code; ?> @@ -97,7 +99,7 @@ image) : ?> image . '.gif', $language->title_native, array('title' => $language->title_native), true); ?> - sef); ?> + lang_code; ?> diff --git a/administrator/components/com_menus/forms/filter_items.xml b/administrator/components/com_menus/forms/filter_items.xml index 6713db83c60dc..99d6d0feed7e7 100644 --- a/administrator/components/com_menus/forms/filter_items.xml +++ b/administrator/components/com_menus/forms/filter_items.xml @@ -34,7 +34,7 @@ @@ -43,7 +43,7 @@ @@ -51,7 +51,7 @@ @@ -60,7 +60,7 @@ @@ -46,7 +46,7 @@ input->get('task') === 'editAssociations') + { + return $this->redirectToAssociations($data); + } + return true; } diff --git a/administrator/components/com_menus/src/Service/HTML/Menus.php b/administrator/components/com_menus/src/Service/HTML/Menus.php index 3276f2918cf42..3a1d66177bb1d 100644 --- a/administrator/components/com_menus/src/Service/HTML/Menus.php +++ b/administrator/components/com_menus/src/Service/HTML/Menus.php @@ -89,7 +89,7 @@ public function association($itemid) { if (in_array($item->lang_code, $content_languages)) { - $text = strtoupper($item->lang_sef); + $text = $item->lang_code; $url = Route::_('index.php?option=com_menus&task=item.edit&id=' . (int) $item->id); $tooltip = '' . htmlspecialchars($item->language_title, ENT_QUOTES, 'UTF-8') . '
' . htmlspecialchars($item->title, ENT_QUOTES, 'UTF-8') . '
' . Text::sprintf('COM_MENUS_MENU_SPRINTF', $item->menu_title); diff --git a/administrator/components/com_menus/tmpl/item/edit_modules.php b/administrator/components/com_menus/tmpl/item/edit_modules.php index 176e17b62d6d8..e849f02f71adf 100644 --- a/administrator/components/com_menus/tmpl/item/edit_modules.php +++ b/administrator/components/com_menus/tmpl/item/edit_modules.php @@ -57,13 +57,13 @@
+ + + diff --git a/administrator/components/com_menus/tmpl/items/default.php b/administrator/components/com_menus/tmpl/items/default.php index aff952d26e218..cba045182e68a 100644 --- a/administrator/components/com_menus/tmpl/items/default.php +++ b/administrator/components/com_menus/tmpl/items/default.php @@ -48,19 +48,21 @@ items)) : ?> - - -
- , + , + , +
+ + + @@ -216,7 +218,7 @@ language_image . '.gif', $item->language_title, array('title' => Text::sprintf('COM_MENUS_GRID_UNSET_LANGUAGE', $item->language_title)), true); ?> language_sef; ?> + title="language_title); ?>">language; ?> @@ -224,7 +226,7 @@ language_image . '.gif', $item->language_title, array('title' => $item->language_title), true); ?> language_sef; ?> + title="language_title; ?>">language; ?> diff --git a/administrator/components/com_menus/tmpl/items/modal.php b/administrator/components/com_menus/tmpl/items/modal.php index 59afccaff7928..a6746f94f3593 100644 --- a/administrator/components/com_menus/tmpl/items/modal.php +++ b/administrator/components/com_menus/tmpl/items/modal.php @@ -54,11 +54,13 @@ - - - @@ -145,7 +147,7 @@ language_image) : ?> language_image . '.gif', $item->language_title, array('title' => $item->language_title), true); ?> - language_sef; ?> + language; ?> diff --git a/administrator/components/com_menus/tmpl/menus/default.php b/administrator/components/com_menus/tmpl/menus/default.php index 7c45f2aade97d..4cdc8773a6a34 100644 --- a/administrator/components/com_menus/tmpl/menus/default.php +++ b/administrator/components/com_menus/tmpl/menus/default.php @@ -50,11 +50,13 @@
- , + , + , +
+ @@ -73,10 +75,10 @@ + +
-