Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Nested bookmark folders listed beyond the toolbar is not properly shown when Window size is changed #4381

Closed
srirambv opened this issue Sep 29, 2016 · 8 comments

Comments

@srirambv
Copy link
Collaborator

srirambv commented Sep 29, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Nested bookmark folders listed beyond the toolbar is not properly shown when Window size is changed

Expected behavior:
Should show the nested folder properly irrespecitve of browser window size

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.3 RC3
  • Steps to reproduce:
    1. Have lots of bookmarks to overflow the bookmark toolbar.
    2. Ensure Nested bookmark folders are beyond the toolbar region
    3. Click on >> to list all bookmarks
    4. Navigate to folder to show the nested folders/bookmark items. Should show properly next to the folder
    5. Resize the window to a smaller resolution
    6. Repeat steps 3 & 4, the nested folders/bookmark items are way off. Doesn't show next to the parent folder.
  • Screenshot if needed:
    bookmark1
  • Any related issues:
    Bookmarks toolbar render is off when '>>' expander is used. #4272
@srirambv srirambv added this to the 0.12.3dev milestone Sep 29, 2016
@alexwykoff alexwykoff modified the milestones: 0.12.4dev, 0.12.3dev Sep 29, 2016
@bbondy bbondy modified the milestones: 0.12.5dev, 0.12.4dev Oct 4, 2016
@bbondy
Copy link
Member

bbondy commented Oct 10, 2016

This has to do with the scroll offset not being taken into account.

@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 10, 2016
@jkup jkup self-assigned this Oct 13, 2016
@jkup
Copy link
Contributor

jkup commented Oct 13, 2016

Having trouble reproducing. Could it maybe be a Windows issue?

@jkup
Copy link
Contributor

jkup commented Oct 13, 2016

I can't reproduce this on Windows either. Is there a chance it was fixed by something else? @srirambv can you still repro?

@bsclifton
Copy link
Member

This is somewhat similar to #1589; I wonder if it's the same issue?

@jkup
Copy link
Contributor

jkup commented Oct 17, 2016

Should we close this out if we can't reproduce it? That other issue worries me because the user says they can still repro it even though we can't. Either way I think we should bump out of 12.6 for now because I'm not sure how to get started.

@jkup jkup modified the milestones: 0.12.7dev, 0.12.6dev Oct 18, 2016
@bbondy
Copy link
Member

bbondy commented Oct 24, 2016

@srirambv please answer @jkup from last week's comment. Thanks.

@bbondy bbondy removed this from the 0.12.7dev milestone Oct 24, 2016
@bsclifton
Copy link
Member

@srirambv can you please try to repro this? If you're not able to, let's close it out. Thanks 😄

@srirambv
Copy link
Collaborator Author

srirambv commented Dec 5, 2016

Issue still exist. This is on 0.12.12. Nested folder is not selectable if the browser window is small
4381

@luixxiul luixxiul added the bug label May 31, 2017
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants