From 4ed8adbc17f6301fc6c271bdbb1c953c4c786e32 Mon Sep 17 00:00:00 2001 From: Anthony Tseng Date: Mon, 19 Sep 2016 16:03:43 +0800 Subject: [PATCH] Fix sortableTable hover effect and searchTab onClick fix #4099 Auditors: @bbondy Test Plan: 1. Go to "about:preferences#search" 2. There should be hover effect when hovering on row 3. Should be able to swtch default search engine --- js/about/preferences.js | 2 +- js/components/sortableTable.js | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/js/about/preferences.js b/js/about/preferences.js index a133e654b0f..543396a89bc 100644 --- a/js/about/preferences.js +++ b/js/about/preferences.js @@ -616,7 +616,7 @@ class SearchTab extends ImmutableComponent { } hoverCallback (rows) { - this.props.onChangeSetting(settings.DEFAULT_SEARCH_ENGINE, rows[1].props.children.props.name) + this.props.onChangeSetting(settings.DEFAULT_SEARCH_ENGINE, rows[1].value) } render () { diff --git a/js/components/sortableTable.js b/js/components/sortableTable.js index 34b12b1af2a..1b0e7ebaa1b 100644 --- a/js/components/sortableTable.js +++ b/js/components/sortableTable.js @@ -99,7 +99,8 @@ class SortableTable extends ImmutableComponent { const rowAttributes = this.getRowAttributes(row, i) return {entry} + className={this.hasRowClassNames ? this.props.rowClassNames[i] + ' ' + rowAttributes.className + : rowAttributes.className}>{entry} }) }