Wrap copy clean link hotkey replacement to a feature flag

[spylogsster]

We replace default ctrl+c hotkey to copy sanitized links by default, need to add a feature flag to let users use default logic if needed.

[spylogsster]

cc @rebron @fmarier @bsclifton

[kaliy]

Yes, please! That would solve the issue #29128 :)

[kamrandotpk]

We replace default ctrl+c hotkey to copy sanitized links by default, need to add a feature flag to let users use default logic if needed.

I would argue it should be the other way around: 'ctrl+c' should copy by default, and the feature flag should enable switching to 'copy sanitized links' - thanks!

[LaurenWags]

@brave/qa-team should verify this on Win, Linux and macOS. On macOS should verify on both Intel and M1.

[kjozwiak]

The above requires 1.49.127 or higher for 1.49.x verification 👍

[LaurenWags]

Verified with

Brave | 1.49.128 Chromium: 111.0.5563.110 (Official Build) (x86_64)
-- | --
Revision | 3da375c9e9e5ad9b556af5df708a6e6c01d8cfb1-refs/branch-heads/5563@{#1202}
OS | macOS Version 12.6.3 (Build 21G419)

Confirmed flag is available with 1.49.128. Note, flag name/title is different than PR description. Confirmed what is shown in browser is correct:

Default - PASSED

Ran through the below steps to confirm expected locations of "Copy clean link" option from macOS app menu, context menu, share menu, and keyboard shortcut (Cmd + C on macOS):

0. Confirmed value of "Default" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu and has the cmd + C keyboard shortcut (⌘C) listed next to it
3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Cmd + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Used "Cmd + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Step 0	Step 2	Step 3	Step 4	Step 7	Step 8	Step 11

Disabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Cmd + C on macOS) is not used for "Copy clean link":

0. Confirmed value of "Disabled" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu and it does NOT have the cmd + C keyboard shortcut (⌘C) listed next to it, this is listed next to "Copy" as expected
3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Cmd + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link pasted is the original URL with all parameters: https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Used "Cmd + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is the original URL with all parameters https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw

Step 0	Step 2	Step 3	Step 4	Step 7	Step 8	Step 11

Enabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality works as expected with the keyboard shortcut enabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Cmd + C on macOS) is used for "Copy clean link":

0. Confirmed value of "Default" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu and has the cmd + C keyboard shortcut (⌘C) listed next to it
3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Cmd + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Used "Cmd + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Step 0	Step 2	Step 3	Step 4	Step 7	Step 8	Step 11

[btlechowski]

Verification passed on

Brave	1.49.128 Chromium: 111.0.5563.110 (Official Build) (64-bit)
Revision	3da375c9e9e5ad9b556af5df708a6e6c01d8cfb1-refs/branch-heads/5563@{#1202}
OS	Ubuntu 18.04 LTS

Default - PASSED

Ran through the below steps to confirm expected locations of "Copy clean link" option from, context menu, share menu, and keyboard shortcut:

0. Confirmed value of "Default" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "Cmd + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "Cmd + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Disabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut is not used for "Copy clean link":

0. Confirmed value of "Disabled" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "control + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link pasted is the original URL with all parameters: https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "control + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is the original URL with all parameters https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw

Enabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality works as expected with the keyboard shortcut enabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut is used for "Copy clean link":

0. Confirmed value of "Default" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "Cmd + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "Cmd + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

||||
--|--|--|--|--|--

[LaurenWags]

Verified with

Brave | 1.49.128 Chromium: 111.0.5563.110 (Official Build) (arm64)
-- | --
Revision | 3da375c9e9e5ad9b556af5df708a6e6c01d8cfb1-refs/branch-heads/5563@{#1202}
OS | macOS Version 12.6.3 (Build 21G419)

Confirmed flag is available with 1.49.128. Note, flag name/title is different than PR description. Confirmed what is shown in browser is correct:

Default - PASSED

Ran through the below steps to confirm expected locations of "Copy clean link" option from macOS app menu, context menu, share menu, and keyboard shortcut (Cmd + C on macOS):

0. Confirmed value of "Default" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu and has the cmd + C keyboard shortcut (⌘C) listed next to it
3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Cmd + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Used "Cmd + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Step 0	Step 2	Step 3	Step 4	Step 7	Step 8	Step 11

Disabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Cmd + C on macOS) is not used for "Copy clean link":

0. Confirmed value of "Disabled" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu and it does NOT have the cmd + C keyboard shortcut (⌘C) listed next to it, this is listed next to "Copy" as expected
3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Cmd + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link pasted is the original URL with all parameters: https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Used "Cmd + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is the original URL with all parameters https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw

Step 0	Step 2	Step 3	Step 4	Step 7	Step 8	Step 11

Enabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality works as expected with the keyboard shortcut enabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Cmd + C on macOS) is used for "Copy clean link":

0. Confirmed value of "Default" for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu and has the cmd + C keyboard shortcut (⌘C) listed next to it
3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Cmd + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Used "Cmd + C" while the URL bar is in focus to copy the URL
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Step 0	Step 2	Step 3	Step 4	Step 7	Step 8	Step 11

[stephendonner]

Verification PASSED using

Brave	1.49.128 Chromium: 111.0.5563.110 (Official Build) (64-bit)
Revision	3da375c9e9e5ad9b556af5df708a6e6c01d8cfb1-refs/branch-heads/5563@{#1202}
OS	Windows 10 Version 22H2 (Build 19045.2728)

Confirmed flag is available with 1.49.128. Note, flag name/title is different than PR description. Confirmed what is shown in browser is correct:

Default - PASSED

Ran through the below steps to confirm expected locations of "Copy clean link" option from context menu, share menu, and keyboard shortcut (Ctrl + C on Windows):

0. Confirmed value of Default for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" with Ctrl +C as the shortcut in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "Ctrl + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "Ctrl + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Step 0	Step 2	Step 3	Step 6	Step 7	Step 10

Disabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality still works with the keyboard shortcut disabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Ctrl + C on Windows) is not used for "Copy clean link":

0. Confirmed value of Disabled for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "Ctrl + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link pasted is the original URL with all parameters: https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "Ctrl + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is the original URL with all parameters https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw

Step 0	Step 2	Step 3	Step 6	Step 7	Step 10

Enabled - PASSED

Case A: Ran through appropriate cases on https://fmarier.github.io/brave-testing/copy-clean-link.html to confirm functionality works as expected with the keyboard shortcut enabled. (spot check of "Copy clean link" functionality)

Case B: Ran through the below steps to confirm expected locations of "Copy clean link" option and confirm that keyboard shortcut (Ctrl + C on Windows) is used for "Copy clean link":

0. Confirmed value of Default for brave://flags/#brave-copy-clean-link-by-default
1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
3. Confirmed "Copy clean link" is displayed in the share menu from URL bar
4. Used "Ctrl + C" while the URL bar is in focus to copy the URL
5. Opened a new tab and pasted the copied URL
6. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
7. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
8. Used "Ctrl + C" while the URL bar is in focus to copy the URL
9. Opened a new tab and pasted the copied link
10. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Step 0	Step 2	Step 3	Step 6	Step 7	Step 10

[umeditor]

We replace default ctrl+c hotkey to copy sanitized links by default, need to add a feature flag to let users use default logic if needed.

I would argue it should be the other way around: 'ctrl+c' should copy by default, and the feature flag should enable switching to 'copy sanitized links' - thanks!

100% We've already had multiple users ditch Brave because of this change.

[dextart]

We replace default ctrl+c hotkey to copy sanitized links by default, need to add a feature flag to let users use default logic if needed.

I would argue it should be the other way around: 'ctrl+c' should copy by default, and the feature flag should enable switching to 'copy sanitized links' - thanks!

100% We've already had multiple users ditch Brave because of this change.

Totally agree. You can't just switch universally used shortcut to something only a handful people find useful. I lost productive time and sanity and almost switched back to Chrome before finding this thread and the flag. Whoever thought this was a good idea didn't have their brightest moment.

[fmarier]

I would argue it should be the other way around: 'ctrl+c' should copy by default, and the feature flag should enable switching to 'copy sanitized links' - thanks!

This is coming in a follow-up PR: brave/brave-core#17752