Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor component updater to use crx id instead of public key #28007

Open
aseren opened this issue Jan 24, 2023 · 1 comment
Open

Refactor component updater to use crx id instead of public key #28007

aseren opened this issue Jan 24, 2023 · 1 comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop

Comments

@aseren
Copy link

aseren commented Jan 24, 2023 •
edited
Loading

Currently, the component updater stores/operates with public keys which can be changed to component CRX id because we use the publisher proof, and each component is already signed by Chromium or Google key.

https://github.com/brave/brave-core/blob/master/components/brave_ads/browser/component_updater/components.h#L16
https://github.com/brave/brave-core/blob/master/components/ntp_background_images/browser/sponsored_images_component_data.cc
@aseren aseren added OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 24, 2023
@aseren
Copy link
Author

aseren commented Jan 24, 2023

cc @atuchin-m @goodov @iefremov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aseren