Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 106.0.5249.61 to Chromium 106.0.5249.65 #25629

Closed
mkarolin opened this issue Sep 26, 2022 · 7 comments · Fixed by brave/brave-core#15227
Closed

Upgrade from Chromium 106.0.5249.61 to Chromium 106.0.5249.65 #25629

mkarolin opened this issue Sep 26, 2022 · 7 comments · Fixed by brave/brave-core#15227

Comments

@mkarolin
Copy link
Contributor

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/106.0.5249.61..106.0.5249.65?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@kjozwiak
Copy link
Member

The above requires 1.44.101 or higher for 1.44.x verification 👍

@kjozwiak
Copy link
Member

With the above, the only platform that still needs to check the affected area's mentioned via #24517 (comment) in Linux. The other platforms have already completed the checks re: the affected area's and will just need to run through a quick spot check. Specifically doing an upgrade to make sure everything is working as expected.

@kjozwiak
Copy link
Member

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.44.101 Chromium: 106.0.5249.65 (Official Build) (32-bit)
--- | ---
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS	Android 13; Build/T1B1.220819.006
Example Example
Screenshot_20220927-032907 Screenshot_20220927-032914

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 10 Version 21H2 (Build 19044.2006)

image

@btlechowski
Copy link

Verification passed on

Brave 1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS Ubuntu 18.04 LTS

image

Verified #24517 (comment)

Color scheme (omnibox)_PASSED
  • Verified that omnibox color scheme is shown as expected in focused/not focused in light theme
  • Verified that omnibox color scheme is shown as expected in focused/not focused in dark theme

Light theme
image
image

Dark theme

image
image

History page_PASSED
  • Confirmed that history of all the visited websites is listed in brave://history
  • Confirmed that brave://history UI looks expected
  • Confirmed that user can search the specific brave history via Search option
  • Confirmed that imported browser history is shown in brave is as expected

image

Content settings_PASSED
  • Confirmed content settings are working as expected

1. Block cookies content settings

  • Open a site cnn.com
  • Open content settings for cnn.com
  • Block content settings for Location and Window management
  • Reload cnn.com
  • Ensured that Location and Window management permission are blocked for cnn.com
  • Open brave://settings/cookies and Block all cookies
  • Reload cnn.com and ensured that all cookies are blocked on cnn.com

image
image
image
image

2. Block scripts content settings

  • Block the java scripts for a site via brave://settings/content/javascript
  • Open the site ensured Javascripts blocked for the site
  • Open a bunch of websited and ensured javascript is not blocked

image

3. Block autoplay global settings

  • Block the autoplay content global settings via brave://settings/content/autoplay
  • Open youtube.com and ensured no videos are autoplayed
  • Click on a video and play the video manully, wait till the 1st video ends
  • Ensured 2nd video is not autoplayed

image
image
image

Bookmarks_PASSED
  • Confirmed user can add/edit/delete the bookmarks
  • Confirmed bookmarks can be imported via NTP, brave://settings/importData, Hamburger menu - import bookmarks option and brave://bookmarks/ - Import bookmarks
  • Confirmed imported bookmarks can be opened in PT, new window, new tab and in a regular window
  • Confirmed that imported bookmarks are shown in Private and Tor window new tabs

image
image
image
image

Settings UI_PASSED
  • Verified that click on each settings in brave://settings redirected to the intended page
  • Verified the brave://settings UI and ensured UI looks good
  • Verified the icons in the brave://settings page and ensured icons are shown as expected in each settings page
  • Additional testing on settings is covered in "Settings comparision" section
Cookies_PASSED
  • Ensured that cookies are retained in an upgraded profile
  • Ensured cookies settings are working as expected
  • Ensured local and global cookies shield settings are working as expected

Case 1:

  • Open a site cnn.com
  • Open content settings for cnn.com
  • Open brave://settings/cookies and Block all cookies
  • Reload cnn.com and ensured that all cookies are blocked on cnn.com
  • Open brave://settings/cookies and Allow all cookies
  • Reload cnn.com and ensured that all cookies are allowed on cnn.com

image
image
image

Multiple profiles_PASSED
  • Confirmed that user can create the multiple profiles (e.g Profile 1 and Profile 2)
  • Change the brave://settings and import bookmarks and add extensions in Profile 1
  • Ensured that changes made in settings in Profile 1 are NOT reflected in Profile 2
  • Ensured that the bookmarks and extensions are NOT reflected in Profile 2
  • Enable rewards and update the rewards settings in brave://rewards in Profile 1
  • Ensured that updated rewards settings are specific to profile 1 and are not reflected in Profile 2
    image
First run dialog_PASSED
  • Confirmed first run dialog is shown when brave is launched in a clean install
  • Confirmed that the dialog content is as expected
  • Confirmed click on Set Brave as default button in first-run dialog set the brave as the default browser and Make Default is removed from the brave://settings/getStarted
  • Confirmed click on the Maybe later button in the first-run dialog doesn't set the brave as the default browser and the Make Default option is shown in the brave://settings/getStarted
  • Confirmed click on x close button in first-run dialog and doesn't set the brave as the default browser and Make Default is shown in the brave://settings/getStarted
  • Confirmed that the user can set the brave as default browser by clicking on the Make Default option is shown in the brave://settings/getStarted

image
image
image

Side panel_PASSED
  • Confirmed that sidebar is shown by default in the nightly channel
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list

image
image
image
image

New tab page_PASSED
  • Ensured Tops sites can be edit/delete via NTP
  • Ensured that NTP stats can be hidden/shown
  • Ensured that a site can be added via NTP
  • Ensured NTP Widget cards can be added/removed
  • Ensured NTP SI works as expected
  • Ensured that click on settings (bookmarks, history, settings and brave talk) shortcuts works as expected
  • Ensured that the existing features upload your own and Brave background works as expected
  • Confirmed that NTP SI are shown in the order 2, 4, 8 tabs
  • Confirmed that user can select the solid background for NTP
  • Confirmed that user can choose the induvidual solid background via NTP
  • Confirmed that same solid background is shown on each the NTP when the induvidual solid background is selected
  • Confirmed that the differenet solid background is shown on each the NTP when Refresh on every new tab switch is ON
  • Confirmed that user can select the gradient background for NTP
  • Confirmed that user can choose the induvidual gradient background via NTP
  • Confirmed that same gradient background is shown on each the NTP when the induvidual gradient background is selected
  • Confirmed that the differenet gradient background is shown on each the NTP when Refresh on every new tab switch is ON
    image
    image
    image

Settings comparison

Verified that the Language settings are updated as part of CR 106
image
Verified that content additional setting is renamed as Windows management as part of CR 106
image
New settings Tab hover mode and Side panel settings are added as part of Brave in nightly (1.45.x) which are already merged in Beta (1.44.x)
image
Verified that Reading list sync data is been added in brave://sync as part of brave
image

Verified the each settings in brave://settings page and ensured each settings works as expected

Components updater

image

Brave startup calls

  • Confirmed that only brave domains are listed in the Charles when the nightly build is launched with a clean profile
  • Confirmed no calls to google, gstatic, etc domains when the nightly build is launched with a clean profile

@stephendonner
Copy link

Verified PASSED using

Brave 1.44.101 Chromium: 106.0.5249.65 (Official Build) (x86_64)
Revision 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS macOS Version 11.7 (Build 20G817)

Screen Shot 2022-09-27 at 9 31 55 AM

@Uni-verse
Copy link
Contributor

Uni-verse commented Sep 27, 2022

Verified on Samsung Galaxy Tab S7 using the following build(s):

Brave	1.44.101 Chromium: 106.0.5249.65 (Official Build) (64-bit) 
Revision	3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS	Android 12; Build/SP1A.210812.016

Checked versioning and branding items on clean profile installs and upgraded profile. Also performed sanity checks on the affected Android items mentioned in #24517 (comment)

  • Autoplay setting
  • Verified Autoplay is enabled by default
  • User is able to add exceptions to allow or block URLs
  • Colors of controls in settings
  • Verified different selectors, focus highlighting and buttons appear in light/dark mode
Example Example Example Example
screenshot-1664291485867 screenshot-1664291598889 screenshot-1664291636389 screenshot-1664291825128
screenshot-1664291499891 screenshot-1664291589414 screenshot-1664291691687 screenshot-1664291835343
  • Sharing hub
  • Verified sharing hub is enabled by default
  • Verified sharing hub shows up via the share menu

screenshot-1664293735480

  • Send tab to another device
  • Verified sharing tab by using send to your device via share menu once connect to sync chain
Example Example Example Example
screenshot-1664291903840 screenshot-1664291910846 screenshot-1664291918298 Screen Shot 2022-09-27 at 11 19 33 AM

General

Example Example Example
screenshot-1664291065910 screenshot-1664291077684 screenshot-1664291310393

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants