Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect address for ENS domains without eth address record. #25308

Closed
supermassive opened this issue Sep 9, 2022 · 2 comments · Fixed by brave/brave-core#15169
Closed

Incorrect address for ENS domains without eth address record. #25308

supermassive opened this issue Sep 9, 2022 · 2 comments · Fixed by brave/brave-core#15169
Assignees
@supermassive
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@supermassive
Copy link

If ens domain does not have eth wallet address we report it is as 0x000...00, but should report as no address.

https://app.ens.domains/name/haimoura.eth/details

image

image
@supermassive supermassive self-assigned this Sep 9, 2022
@supermassive supermassive changed the title Incorrect address for ENS domains without eth wallet address. Incorrect address for ENS domains without eth address record. Sep 9, 2022
@supermassive supermassive mentioned this issue Sep 22, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Sep 22, 2022
@supermassive supermassive mentioned this issue Sep 22, 2022
Merged
7 tasks
@yrliou yrliou mentioned this issue Sep 22, 2022
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.44.98 or higher for 1.44.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.99 Chromium: 106.0.5249.55 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Linux
  • Verified steps from brave/brave-core#15169
  • Verified entering haimoura.eth in Send to on wallet panel shows Domain haimoura.eth is not registered message instead of zero address
  • Verified on both Panel and widget
25308.mp4

Verification passed on

Brave 1.44.99 Chromium: 106.0.5249.55 (Official Build) (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Windows 11 Version 21H2 (Build 22000.978)
  • Verified steps from brave/brave-core#15169
  • Verified entering haimoura.eth in Send to on wallet panel shows Domain haimoura.eth is not registered message instead of zero address
  • Verified on both Panel and widget
25308.mp4

Verification passed on

Brave 1.44.99 Chromium: 106.0.5249.55 (Official Build) (arm64)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#15169
  • Verified entering haimoura.eth in Send to on wallet panel shows Domain haimoura.eth is not registered message instead of zero address
  • Verified on both Panel and widget
25308.mov

@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Fix zero address handling for EnsGetEthAddr brave/brave-core
4 participants
@supermassive @kjozwiak @srirambv @brave-builds