Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When disconnected from the network interface, VPN should gracefully go to Disconnected state, rather than Try again error dialogs #23924

Closed
stephendonner opened this issue Jul 7, 2022 · 1 comment

Comments

@stephendonner
Copy link

stephendonner commented Jul 7, 2022

Description

When disconnected from the network interface, VPN should gracefully go to Disconnected state, rather than Try again error dialogs

This is essentially just #22883 continued (fix made things better, but it still happens).

Steps to Reproduce

  1. install 1.43.3
  2. launch Brave
  3. purchase and set up BraveVPN
  4. connect to BraveVPN
  5. disconnect Wi-Fi (or Ethernet)
  6. click on the (currently showing as Connected) VPN button
  7. wait

Actual result:

Can't connect to server / Try again

image

Expected result:

The VPN dialog should just toggle to Disconnected

image

Reproduces how often:

100%, eventually

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? No

cc @simonhong @spylogsster @mattmcalister @rebron @bsclifton @MadhaviSeelam @GeetaSarvadnya @srirambv

@stephendonner
Copy link
Author

Talked this over with @spylogsster - this is fine as-is, and makes sense to users. Marking as INVALID.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants