Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adblock redesign follow-up to #8838 #23194

Closed
rebron opened this issue Jun 1, 2022 · 2 comments · Fixed by brave/brave-core#13670
Closed

Adblock redesign follow-up to #8838 #23194

rebron opened this issue Jun 1, 2022 · 2 comments · Fixed by brave/brave-core#13670
Assignees
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented Jun 1, 2022

Description

Remove "Brave Ad block" item from the app menu as it is already available in Shields UI as "Filter lists" and available in settings
Change Shields UI "Filter lists" link from brave://adblock to brave://settings/shields/content-filters

Expected result:

  1. Go to hamburger/app menu and notice that Brave Ad Block is no longer listed.
  2. Go to Shields and notice that link link for Filter list goes to brave://settings/shields/content-filters

Reproduces how often:

n/a

Brave version (brave://version info)

Target release 1.41.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Related issue:
#8838

@rebron rebron added feature/shields/adblock Blocking ads & trackers with Shields QA/Yes release-notes/exclude priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 1, 2022
@nullhook nullhook added this to the 1.41.x - Nightly milestone Jun 13, 2022
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.41.65 Chromium: 103.0.5060.42 (Official Build) nightly (64-bit)
-- | --
Revision | de0d840bf9439c31bd86bf74f065c31fdf9b208d-refs/branch-heads/5060@{#667}
OS | Windows 11 Version 21H2 (Build 22000.739)
  1. Confirmed Brave Ad Block no longer listed in the hamburger/app menu
  2. Confirmed Shields-->Filter List link opens to brave://settings/shields/filters in NTP
  3. Confirmed brave://adblock redirected to brave://settings/shields/filters

Note: As per #23222, the new URL is brave://settings/shields/filters Not brave://settings/shields/content-filters as the PR mentioned.

Step1 Step2 Step2A&Step3
image image image

@stephendonner
Copy link

Verified PASSED using

Brave 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (x86_64)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS macOS Version 11.6.7 (Build 20G630)
  1. Confirmed Brave Ad Block no longer listed in the "hamburger" menu
  2. Confirmed Shields -> Filter lists link opens brave://settings/shields/filters in a new-tab page
  3. Confirmed brave://adblock redirected to brave://settings/shields/filters

Note: As per #23222, the new URL is brave://settings/shields/filters Not brave://settings/shields/content-filters as the PR mentioned.

Step 1 Step 2 Step 3
Screen Shot 2022-06-21 at 10 00 40 AM Screen Shot 2022-06-21 at 10 00 59 AM Screen Shot 2022-06-21 at 10 03 39 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields/adblock Blocking ads & trackers with Shields OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants