Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove on toolbar in Hide Brave Wallet icon on toolbar in its context-menu text #23033

Closed
stephendonner opened this issue May 24, 2022 · 4 comments · Fixed by brave/brave-core#13457
Closed

Remove on toolbar in Hide Brave Wallet icon on toolbar in its context-menu text #23033

stephendonner opened this issue May 24, 2022 · 4 comments · Fixed by brave/brave-core#13457
Assignees
@spylogsster
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.41.x - Release

Comments

@stephendonner
Copy link

Description

Remove on toolbar in Hide Brave Wallet icon on toolbar in its context-menu text

Steps to Reproduce

  1. install 1.41.11
  2. launch Brave
  3. context/right-click on the Brave Wallet icon on the toolbar
  4. note its descriptive text

Actual result:

Hide Brave Wallet icon on toolbar

Screen Shot 2022-05-24 at 3 57 15 PM

Expected result:

Should shorten it to at least Hide Brave Wallet icon a la Rewards?

Screen Shot 2022-05-24 at 4 06 42 PM

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.41.11 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 12.5 (Build 21G5027d)

cc @spylogsster @rebron @rmcfadden3 @jamesmudgett
@stephendonner stephendonner added bug needs-text-change This change requires some careful wording. QA/Yes QA/Test-Plan-Specified feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels May 24, 2022
@spylogsster spylogsster self-assigned this May 25, 2022
@spylogsster spylogsster mentioned this issue May 25, 2022
Merged
25 tasks
@spylogsster spylogsster added this to the 1.41.x - Nightly milestone May 25, 2022
@stephendonner
Copy link
Author

cc @srirambv to keep in the loop

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.41.21 Chromium: 102.0.5005.61 (Official Build) nightly (x86_64)
Revision 0e59bcc00cc4985ce39ad31c150065f159d95ad3-refs/branch-heads/5005@{#819}
OS macOS Version 12.5 (Build 21G5027d)

Confirmed it now reads Hide Brave Wallet icon

Screen Shot 2022-05-27 at 5 13 44 PM

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jun 8, 2022 •
edited
Loading

Verification PASSED using

Brave | 1.41.47 Chromium: 102.0.5005.78 (Official Build) nightly (64-bit)
-- | --
Revision | df6dbb5a9fd82af3f567198af2eb5fb4876ef99c-refs/branch-heads/5005_59@{#3}
OS | Windows 11 Version 21H2 (Build 22000.675)

Confirmed it now reads Hide Brave Wallet icon

Light Dark
image1 image2

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.41.74 Chromium: 103.0.5060.53 (Official Build) beta (64-bit)
Revision a1711811edd74ff1cf2150f36ffa3b0dae40b17f-refs/branch-heads/5060@{#853}
OS Linux
  • Verified tool tip now reads Hide Brave Wallet Icon
    Screenshot from 2022-06-22 09-13-31

@LaurenWags LaurenWags mentioned this issue Jul 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.41.x - Release
Development

Successfully merging a pull request may close this issue.

Fix title for wallet menu brave/brave-core
4 participants
@stephendonner @spylogsster @srirambv @MadhaviSeelam