Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct routes to specific Wallet Onboarding pages #22589

Closed
josheleonard opened this issue Apr 27, 2022 · 1 comment · Fixed by brave/brave-core#13068
Closed

Add direct routes to specific Wallet Onboarding pages #22589

josheleonard opened this issue Apr 27, 2022 · 1 comment · Fixed by brave/brave-core#13068

Comments

@josheleonard
Copy link

josheleonard commented Apr 27, 2022

Description

Add routes to directly open a specific Wallet onboarding step, so that the user can continue where they left off.

Expected result:

All wallet onboarding steps of wallet/crypto/onboarding should have a corresponding URL

  • Create password: /crypto/onboarding/create-password
  • Backup wallet: /crypto/onboarding/backup-wallet
  • Onboarding import from MetaMask = /crypto/onboarding/import-metamask-wallet
  • Onboarding import from legacy crypto wallet = /crypto/onboarding/import-legacy-wallet

Test Plan

  • Reset Brave Wallet

  • Click on the wallet Icon

  • Click Learn More in the panel popup

  • Verify that the Onboarding welcome screen was opened

    • The browser URL should be: brave://wallet/crypto/onboarding
  • Continue to create wallet step

    • The URL should be: brave://wallet/crypto/onboarding/create-password
  • Continue to backup wallet step

    • The URL Should be: brave://wallet/crypto/onboarding/backup-wallet
  • Reset Brave Wallet

  • Install and setup MetaMask extension

  • Click on the wallet Icon

  • Click Learn More in the panel popup

  • Verify that the Onboarding welcome screen was opened

    • The browser URL should be: brave://wallet/crypto/onboarding
  • Continue to restore from MetaMask step

    • URL should be brave://wallet/crypto/onboarding/import-metamask-wallet
  • Reset Brave Wallet

  • Install legacy crypto wallet extension

  • Click on the wallet Icon

  • Click Learn More in the panel popup

  • Verify that the Onboarding welcome screen was opened

    • The browser URL should be: brave://wallet/crypto/onboarding
  • Continue to create wallet step

    • URL should be brave://wallet/crypto/onboarding/import-legacy-wallet
@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2022

Brave 1.41.93 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue
  • Verified direct routes to Onboarding and Importing works fine
22589-Linux.mp4
22589-Windows.mp4
22589-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants