Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add direct routes to specific Account management modals in Wallet #22588

Closed
josheleonard opened this issue Apr 27, 2022 · 1 comment · Fixed by brave/brave-core#13068
Closed
Assignees

Comments

@josheleonard
Copy link

josheleonard commented Apr 27, 2022

Description

Adds routes to directly open a page to specific account management modals in wallet

Expected result:

All tabs of wallet/crypto/accounts/add-account should have a corresponding URL

  • add account modal: /crypto/accounts/add-account/create/:accountTypeName?
  • import account modals: /crypto/accounts/add-account/import/:accountTypeName?
  • hardware wallet import modals: /crypto/accounts/add-account/hardware/:accountTypeName?

Test Plan

  • Enable filecoin flag
  • Create/Restore and unlock the crypto wallet
  • Open the wallet page

- add account modal

  • click on the Accounts tab
  • click Create account
  • click Ethereum
  • verify that that browser URL is: brave://wallet/crypto/accounts/add-account/create/ETH
  • repeat for SOL & FIL

- Import account modal

  • click on the Accounts tab
  • click Import account
  • click Ethereum
  • verify that that browser URL is: brave://wallet/crypto/accounts/add-account/import/ethereum
  • repeat for Solana & Filecoin

- Import Hardware Account modal

  • click on the Accounts tab
  • click Import account
  • click Ethereum
  • verify that that browser URL is: brave://wallet/crypto/accounts/add-account/hardware/ethereum
  • repeat for Solana & Filecoin
@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2022

Brave 1.41.93 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue
  • Verified direct routes to specific Account management modals in wallet work
  • Verified manually typing the direct routes also work
22588-Linux.mp4
22588-Windows.mp4
22588-macOS.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants