Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React-Router for page routing/redirects in Wallet pages #22402

Closed
josheleonard opened this issue Apr 19, 2022 · 1 comment · Fixed by brave/brave-core#13068
Closed

Use React-Router for page routing/redirects in Wallet pages #22402

josheleonard opened this issue Apr 19, 2022 · 1 comment · Fixed by brave/brave-core#13068

Comments

@josheleonard
Copy link

josheleonard commented Apr 19, 2022

Description

Non-standard routing logic is used in the Wallet UI pages, causing development slowdowns. Use React-Router to handle routing and redirects.

Test Plan

  • Check that the following wallet page screens are accessible when the wallet has not yet been created:

    • Onboarding screens
  • Check that the following wallet page screens are accessible when the wallet is unlocked:

    • Portfolio screen
    • Accounts screen
    • Account details screen
    • Assets screen
    • Asset details screen
    • Backup wallet screen
    • Add account modal
    • Add visible asset modal
  • Check that the following wallet page screens are accessible when the wallet is locked:

    • Unlock screen
    • Restore wallet screen
  • Check that the wallet redirects to the last viewed page on session restore (wallet unlock)

    • Exceptions: (Restore wallet screen, unlock wallet screen)
@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2022

Brave 1.41.93 Chromium: 103.0.5060.114 (Official Build) (64-bit)
Revision a1c2360c5b02a6d4d6ab33796ad8a268a6128226-refs/branch-heads/5060@{#1124}
OS ☑️ Linux ☑️ Windows 11 Version 21H2
(Build 22000.708)
☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from issue description
  • Verified when wallet is not created, loading a direct route for portfolio/accounts automatically redirects to onboarding
  • Verified loading a direct route without wallet created and then redirecting to onboarding and continuing allows to create the account and complete onboarding
  • Verified Portfolio/Accounts/Account Detail/Assets/Backup Wallet/Add Account/Add visible asset screens are only accessible when wallet is unlocked
  • Verified loading direct route for any of the above with wallet locked shows brave://wallet/crypto/unlock. Once unlocked loads the direct route that was entered
  • Verified with wallet locked only Unlock and Restore wallet routes are accessible
  • Verified wallet redirects to the last viewed page on session restore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants