Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable rewards via NTP doesn't enable AC switch, reload page also doesn't enable AC #22022

Closed
GeetaSarvadnya opened this issue Mar 31, 2022 · 2 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 31, 2022

Description

Found while testing #22003
Re-enable rewards via NTP doesn't enable AC switch, reload page also doesn't enable AC

Steps to Reproduce

  1. Clean profile 1.37.109 or 1.38.x
  2. Enable rewards via BR panel/NTP/Hamburger menu
  3. Make sure Ads and AC switches are turned ON in brave://rewards
  4. Turn OFF both the switches manually
  5. Open an NTP or existing NTP
  6. Click on Start using rewards
  7. Ads switch is enabled AC switch is in OFF state

Actual result:

Re-enable rewards via NTP doesn't enable AC switch, reload page also doesn't enable AC

Expected result:

Looks like AC switch also needs to be enabled

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.37.109 Chromium: 100.0.4896.60 (Official Build) (64-bit)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS Windows 10 Version 21H2 (Build 19044.1586)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/qa-team @Miyayes @emerick

@emerick
Copy link
Contributor

emerick commented Apr 4, 2022

@GeetaSarvadnya I think this was an intentional choice, to make it less likely for users to enable auto-contribute accidentally.

cc: @zenparsing

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 6, 2022

This is intentional behavior to avoid unsuspecting A-C re-enablement. Thanks!

@Miyayes Miyayes closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants