Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields' toggle buttons are different colors #22004

Closed
stephendonner opened this issue Mar 31, 2022 · 3 comments · Fixed by brave/brave-core#12885 or brave/brave-core#12894
Closed

Shields' toggle buttons are different colors #22004

stephendonner opened this issue Mar 31, 2022 · 3 comments · Fixed by brave/brave-core#12885 or brave/brave-core#12894
Assignees
@nullhook
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Milestone
1.38.x - Release

Comments

@stephendonner
Copy link

stephendonner commented Mar 31, 2022 •
edited by petemill
Loading

Description

Shields' toggle buttons are different colors Small toggles have animated gradients but shouldn't.

Steps to Reproduce

  1. install 1.39.18
  2. launch Brave
  3. load any website
  4. click on the Shields icon in the URL bar
  5. toggle both Block Scripts and Upgrade connections to HTTPS to ON

Actual result:

Both are...different colors?

Screen Shot 2022-03-30 at 6 14 42 PM

Expected result:

Same color?

Reproduces how often:

Brave version (brave://version info)

Brave 1.39.18 Chromium: 100.0.4896.60 (Official Build) nightly (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 11.6.5 (Build 20G527)

cc @MadhaviSeelam @LaurenWags @GeetaSarvadnya @jenn-rhim
@stephendonner stephendonner added bug feature/shields The overall Shields feature in Brave. QA/Yes feature/shields/panel Front-end design and functionality of the Shields panel. OS/Desktop labels Mar 31, 2022
@aguscruiz
Copy link

Updated designs address the issue:
https://www.figma.com/file/3A6F6VrxVahiZFxLr7j7FO/Desktop-Brave-Shields?node-id=1220%3A26674

@rebron rebron added priority/P3 The next thing for us to work on. It'll ride the trains. release-notes/exclude labels Apr 4, 2022
@nullhook nullhook mentioned this issue Apr 4, 2022
Merged
25 tasks
@nullhook nullhook mentioned this issue Apr 5, 2022
Merged
7 tasks
@nullhook nullhook added this to the 1.39.x - Nightly milestone Apr 6, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Above requires 1.38.85 or higher for 1.38.x verification.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.38.88 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Followed my original steps to reproduce, and confirmed the small toggle buttons are blurple, and match the Figma spec.

Light theme

example example
Screen Shot 2022-04-11 at 11 44 47 AM Screen Shot 2022-04-11 at 11 44 58 AM

Dark theme

example example
Screen Shot 2022-04-11 at 11 49 44 AM Screen Shot 2022-04-11 at 11 49 51 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullhook nullhook

Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. feature/shields The overall Shields feature in Brave. OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.38.x - Release
Development

Successfully merging a pull request may close this issue.

Shields UI follow ups brave/brave-core
Shields UI fixes (uplift to 1.38x) brave/brave-core
5 participants
@stephendonner @kjozwiak @rebron @nullhook @aguscruiz