Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet backup sends user to verify recovery phrase page the first time after reset #20532

Closed
wchen342 opened this issue Jan 17, 2022 · 1 comment · Fixed by brave/brave-core#11925
Closed

Wallet backup sends user to verify recovery phrase page the first time after reset #20532

wchen342 opened this issue Jan 17, 2022 · 1 comment · Fixed by brave/brave-core#11925
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support good first issue OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@wchen342
Copy link

wchen342 commented Jan 17, 2022 •
edited
Loading

Description

The first time Backup fragment is displayed after a reset, it will go directly to Verify recovery phrase page. From the second time it will display the correct page.

Steps to reproduce

  1. Create a new wallet then reset.
  2. Create a new wallet again, skip backup during onboarding.
  3. Tap the backup banner, the Verify recovery phrase page is shown.

Version/Channel Information:

1.36.41 Nightly

Device details

Android 7.1.1, ARM64
@wchen342 wchen342 added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jan 17, 2022
@SergeyZhukovsky SergeyZhukovsky added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 17, 2022
@wchen342 wchen342 mentioned this issue Jan 20, 2022
Merged
25 tasks
@wchen342 wchen342 added this to the 1.36.x - Nightly milestone Jan 20, 2022
@srirambv
Copy link
Contributor

srirambv commented Feb 7, 2022

Verification passed on Samsung Tab A with Android 10 running 1.36.85 x64 beta build

  • Verified steps from issue description
  • Verified tapping on the backup banner doesn't show verify seed but rather shows the backup seed message

Verification passed on Samsung Tab A with Android 10 running 1.36.85 x64 beta build

  • Verified steps from issue description
  • Verified tapping on the backup banner doesn't show verify seed but rather shows the backup seed message

@bbondy bbondy changed the title Wallet backup sends user to Verify recovery phrase page the first time after reset Wallet backup sends user to verify recovery phrase page the first time after reset Mar 1, 2022
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support good first issue OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Fix wallet backup starts from wrong page brave/brave-core
4 participants
@bbondy @wchen342 @SergeyZhukovsky @srirambv