Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow selecting which custom URL is the active RPC URL #20516

Closed
spylogsster opened this issue Jan 15, 2022 · 4 comments · Fixed by brave/brave-core#14104
Closed

Allow selecting which custom URL is the active RPC URL #20516

spylogsster opened this issue Jan 15, 2022 · 4 comments · Fixed by brave/brave-core#14104
Assignees
@supermassive
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Jan 15, 2022 •
edited by bbondy
Loading

We allow multiple URL selections when configuring networks in brave://settings/wallet/networks. But the user no control for which one will be used.
@bbondy
Copy link
Member

bbondy commented Jan 15, 2022

Cc @jamesmudgett

@spylogsster spylogsster added the front-end-change This task is a front end task and doesn't need any C++ changes label Jan 18, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 3, 2022
@bbondy bbondy added front-end-change This task is a front end task and doesn't need any C++ changes and removed front-end-change This task is a front end task and doesn't need any C++ changes labels Feb 3, 2022
@bbondy
Copy link
Member

bbondy commented Feb 3, 2022

Is this in JS front end or in settings? I would think settings?

@spylogsster
Copy link
Author

on last call with @jamesmudgett decided to keep panel/page UI as simple as possible and move low level options to wallet settings, yes.

@bbondy bbondy changed the title Update the UI for network switching to select RPC URL for chain ID Allow selecting which custom URL is the active RPC URL Feb 14, 2022
@bbondy bbondy mentioned this issue Feb 14, 2022
Closed
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Mar 3, 2022
@bbondy bbondy added feature/web3/wallet/core and removed front-end-change This task is a front end task and doesn't need any C++ changes labels Mar 16, 2022
@supermassive supermassive mentioned this issue Jul 18, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 19, 2022
@nuo-xu nuo-xu mentioned this issue Aug 22, 2022
Closed
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.44.92 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS Linux
  • Verified steps from brave/brave-core#14104
  • Verified able to choose a specific RPC URL as the active one for a selected network
  • Verified able to change the active RPC URL even when the network is set as active
20516-Linux.mp4

Verification passed on

Brave 1.44.92 Chromium: 105.0.5195.136 (Official Build) beta (64-bit)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS Windows 11 Version 21H2 (Build 22000.795)
  • Verified steps from brave/brave-core#14104
  • Verified able to choose a specific RPC URL as the active one for a selected network
  • Verified able to change the active RPC URL even when the network is set as active
20516-Windows.mp4

Verification passed on

Brave 1.44.92 Chromium: 105.0.5195.136 (Official Build) beta (arm64)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS macOS Version 12.4 (Build 21F79)
  • Verified steps from brave/brave-core#14104
  • Verified able to choose a specific RPC URL as the active one for a selected network
  • Verified able to change the active RPC URL even when the network is set as active
20516-macOS.mov

@srirambv srirambv mentioned this issue Sep 23, 2022
Open
@kjozwiak kjozwiak mentioned this issue Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@supermassive supermassive

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

Allow selecting rpc url brave/brave-core
5 participants
@supermassive @bbondy @spylogsster @srirambv @brave-builds