Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add chain validation to wallet_addEthereumChain api call #17640

Closed
spylogsster opened this issue Aug 23, 2021 · 4 comments · Fixed by brave/brave-core#11930
Closed

Add chain validation to wallet_addEthereumChain api call #17640

spylogsster opened this issue Aug 23, 2021 · 4 comments · Fixed by brave/brave-core#11930
Assignees
@spylogsster
Labels
feature/web3/wallet Integrating Ethereum+ wallet support native-change This change is on the Chromium side, usually in C++ OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@spylogsster
Copy link

spylogsster commented Aug 23, 2021 •
edited
Loading

Description

A list of known EVM networks can be found here: https://chainid.network/ we’ll make a subset of this list as our officially supported list also from https://eips.ethereum.org/EIPS/eip-3085:

The wallet SHOULD compare the specified chainId value with the eth_chainId return value from the endpoint

Additionally we have to protect users from adding broken networks
@spylogsster spylogsster added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 23, 2021
@spylogsster spylogsster self-assigned this Aug 23, 2021
@spylogsster spylogsster mentioned this issue Aug 23, 2021
Closed
@spylogsster spylogsster mentioned this issue Aug 31, 2021
Merged
24 tasks
@spylogsster spylogsster mentioned this issue Sep 7, 2021
Merged
24 tasks
@spylogsster spylogsster changed the title Add chainId validation to wallet_addEthereumChain api call Add chain validation to wallet_addEthereumChain api call Sep 7, 2021
@bbondy bbondy self-assigned this Oct 5, 2021
@bbondy
Copy link
Member

bbondy commented Oct 7, 2021

Moving this out of MVP for now

@bbondy bbondy removed their assignment Oct 12, 2021
@spylogsster
Copy link
Author

Need to add validation to this place too brave/brave-core#10641 (comment)

@spylogsster spylogsster mentioned this issue Oct 23, 2021
Merged
24 tasks
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Oct 29, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 3, 2021
@bbondy bbondy added the native-change This change is on the Chromium side, usually in C++ label Nov 8, 2021
@spylogsster spylogsster self-assigned this Jan 20, 2022
This was referenced Jan 20, 2022
Merged
Closed
@spylogsster
Copy link
Author

validation on settings page will be implemented as separate issue #20605

@spylogsster spylogsster added this to the 1.36.x - Nightly milestone Jan 22, 2022
@spylogsster spylogsster mentioned this issue Jan 24, 2022
Open
@srirambv srirambv mentioned this issue Feb 7, 2022
Closed
@srirambv
Copy link
Contributor

Brave 1.36.93 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#11930
  • Verified for valid networks, when added is shown in the network dropdown list

@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet Integrating Ethereum+ wallet support native-change This change is on the Chromium side, usually in C++ OS/Android Fixes related to Android browser functionality OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Add chain validation to wallet_addEthereumChain api call brave/brave-core
3 participants
@bbondy @spylogsster @srirambv