Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interstitial pages are missing (i) icon and have unreadable white text on light gray button #14633

Closed
stephendonner opened this issue Mar 11, 2021 · 3 comments · Fixed by brave/brave-core#8214

Comments

@stephendonner
Copy link

stephendonner commented Mar 11, 2021

Description

Interstitial pages are missing (i) icon and have unreadable white text on light gray button

Steps to Reproduce

  1. new profile
  2. open brave://flags and search for unstoppable or decentralized
  3. flip Enable decentralized DNS to Enabled
  4. relaunch
  5. load brave.crypto
  6. look at the resulting interstitial page; apologies if this is the new material design, and I just missed it?

Actual result:

Screen Shot 2021-03-10 at 5 35 29 PM

  1. There's no (i) icon
  2. The button text is very hard to read against the light gray button color

Expected result:

110041963-d6f4cb00-7cf9-11eb-8f5b-665af05560d7

Reproduces how often:

100%

Brave version (brave://version info)

Brave 1.23.31 Chromium: 89.0.4389.86 (Official Build) nightly (x86_64)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

Again, apologies, @karenkliu if I missed this; still catching up with material design/Figma assets/flow. Also, cc: @yrliou as a heads-up, on the off chance I caught a bug

@yrliou
Copy link
Member

yrliou commented Mar 11, 2021

It's regressed, I'll check.

@yrliou
Copy link
Member

yrliou commented Mar 11, 2021

Ugh, missed some CSS changes when I did a refactor during adding ENS support, will open a PR for it. Thanks for the report.

@yrliou yrliou added this to the 1.23.x - Nightly milestone Mar 11, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Mar 12, 2021
@stephendonner
Copy link
Author

Verified FIXED using nightly build

Brave 1.23.35 Chromium: 89.0.4389.86 (Official Build) nightly (x86_64)
Revision 0c2dac31bc21e806a791641316e99920f84ea52c-refs/branch-heads/4389@{#1472}
OS macOS Version 11.2.3 (Build 20D91)

Tested both light and dark themes

Light (ENS) Light (Unstoppable) Dark (ENS) Dark (Unstoppable)
Screen Shot 2021-03-12 at 8 24 30 AM Screen Shot 2021-03-12 at 8 24 33 AM Screen Shot 2021-03-12 at 8 24 59 AM Screen Shot 2021-03-12 at 8 25 07 AM

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants