Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing chrome branding from Win 8 "Welcome Page" before launch #1335

Closed
kjozwiak opened this issue Sep 28, 2018 · 2 comments
Closed

removing chrome branding from Win 8 "Welcome Page" before launch #1335

kjozwiak opened this issue Sep 28, 2018 · 2 comments

Comments

@kjozwiak
Copy link
Member

Description

We need to remove the Chrome branding from the Welcome page under Win 8.1. This only affects Win 8.1 as it's the only Win OS that has the Welcome screen before brave is launched.

Steps to Reproduce

  1. install either 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev or 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta.
  2. once installed, before brave auto launches, you'll notice the Welcome screen with the Chrome branding at the bottom

Actual result:

screen shot 2018-09-27 at 10 38 33 am

Expected result:

Should remove the Chrome icon and either replace it with a Brave icon or just remove it all together.

Reproduces how often:

100% reproducible on both dev and beta builds using the above STR.

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Windows
Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

Reproducible on current release:

Yes, currently reproducible with both 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev & 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta.

@kjozwiak kjozwiak added the bug label Sep 28, 2018
@kjozwiak kjozwiak added this to the 1.0 (0.56.x) milestone Sep 28, 2018
@rossmoody rossmoody self-assigned this Sep 28, 2018
@rossmoody rossmoody assigned petemill and rossmoody and unassigned rossmoody Oct 7, 2018
@rossmoody
Copy link
Contributor

Think I tracked this down right here.

Swapping this in should do the trick. Same size and format.
brave-logo-faded

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 1, 2018

Verification Passed on

Brave 0.56.7 Chromium: 70.0.3538.77 (Official Build) beta (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

image

Went through verification using the following build under Win 8.1 x64 - PASSED

Brave 0.56.8 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Windows

screen shot 2018-11-04 at 9 58 19 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment