Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Make getModeForRange() behave like getModeForSelection() when mode is not mixed #6975

Open
core-ai-bot opened this issue Aug 30, 2021 · 0 comments
Open

[CLOSED] Make getModeForRange() behave like getModeForSelection() when mode is not mixed #6975

core-ai-bot opened this issue Aug 30, 2021 · 0 comments

Comments

@core-ai-bot
Copy link
Member

Issue by njx
Wednesday May 07, 2014 at 19:41 GMT
Originally opened as adobe/brackets#7775

For #7764. This isn't the cleanest fix, but it exactly preserves the existing behavior for the case where getModeForRange() is called from getModeForSelection(), while fixing the behavior for the case where getModeForRange() is called directly from the commenting operations in EditorCommandHandlers.

The EditorCommandHandlers unit tests all pass with this fix.

@peterflynn /cc@TomMalbran

njx included the following code: https://github.com/adobe/brackets/pull/7775/commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot