Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] replace whitespace with tabs for consistent formatting #6622

Open
core-ai-bot opened this issue Aug 30, 2021 · 8 comments
Open

[CLOSED] replace whitespace with tabs for consistent formatting #6622

core-ai-bot opened this issue Aug 30, 2021 · 8 comments

Comments

@core-ai-bot
Copy link
Member

Issue by ingorichter
Thursday Mar 27, 2014 at 21:47 GMT
Originally opened as adobe/brackets#7339



ingorichter included the following code: https://github.com/adobe/brackets/pull/7339/commits

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Mar 27, 2014 at 22:16 GMT


I'm confused - we use spaces everywhere in the codebase; why do we want to use tabs here?

@core-ai-bot
Copy link
Member Author

Comment by njx
Thursday Mar 27, 2014 at 22:17 GMT


Oh, I see...the whole file uses tabs. That's weird. We should just convert it to spaces.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Thursday Mar 27, 2014 at 22:19 GMT


Yeah, it seems better to convert it the other direction to be consistent with all our other code (otherwise we'll repeatedly recreate this problem every time we edit this file).

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Wednesday Apr 02, 2014 at 00:07 GMT


Sorry for the mess. This time it's properly formatted.

@core-ai-bot
Copy link
Member Author

Comment by ingorichter
Monday Apr 28, 2014 at 16:49 GMT


@njx@peterflynn Would you mind to have a look? I'd like to get this off my plate. Thanks.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Monday Apr 28, 2014 at 16:53 GMT


Reviewing...

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Monday Apr 28, 2014 at 16:55 GMT


Looks good. Merging.

@core-ai-bot
Copy link
Member Author

Comment by njx
Monday Apr 28, 2014 at 17:41 GMT


Sorry, I didn't see this had been updated. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant