[CLOSED] Support ICO files in image preview

[core-ai-bot]

Issue by Denisov21
Thursday Feb 27, 2014 at 13:26 GMT
Originally opened as adobe/brackets#7017

---

I would like Brackets could also view the *. ICO, as similar with *.JPG files.
I'd like to see a preview of the ICO file on Brackets. I thought to see this image. As regards the actual size on the screen is not interested, I thought you could only see the larger image. I hope someone can implement this feature. Currently I do not know Javascript API that can do this!

[core-ai-bot]

Comment by Denisov21
Thursday Feb 27, 2014 at 13:57 GMT

---

Can you merge this #7018? Thank you. Sorry for error!!

[core-ai-bot]

Comment by peterflynn
Thursday Feb 27, 2014 at 18:22 GMT

---

If we only want to show the largest size in the ICO file, this is probably a 'starter bug' because the browser preview seems to select the largest size automatically.

I'd be concerned though that that's not very useful functionality for most people -- typically ICO files contain multiple sizes, with the largest size being one of the least frequently used. Showing all the sizes would be a big 'move to backlog' since it would require parsing the ICO binary.

[core-ai-bot]

Comment by peterflynn
Thursday Feb 27, 2014 at 18:22 GMT

---

Related forum thread: https://groups.google.com/forum/#!topic/brackets-dev/hkYFFPB4lQc

[core-ai-bot]

Comment by MarcelGerber
Thursday Feb 27, 2014 at 20:09 GMT

---

@peterflynn I'd suggest to first implement showing just the largest one - that's at least better than nothing.
We can add more functionality later on.

[core-ai-bot]

Comment by peterflynn
Thursday Feb 27, 2014 at 22:24 GMT

---

Fair enough. Marking 'starter bug' for someone to just add .ico to the image file type list and see how well it works!

[core-ai-bot]

Comment by MarcelGerber
Friday Feb 28, 2014 at 16:35 GMT

---

It works. Should we do unit tests or show a hint (only the biggest icon of the .ico is shown. There may be other ones included.)?

[core-ai-bot]

Comment by peterflynn
Friday Feb 28, 2014 at 18:31 GMT

---

We don't have unit tests for any of the other ImageViewer stuff, so probably no tests needed for now (unless you want to write a bunch of them :-)

I like the idea of adding a label explaining the size caveat (although I'd maybe say "largest" instead of "biggest"). @larz0 any thoughts on label placement, wording, etc.?

[core-ai-bot]

Comment by larz0
Friday Feb 28, 2014 at 23:23 GMT

---

@peterflynn@SAPlayer for the format we could try "256 × 256 pixels (largest) — 700 KB"

[core-ai-bot]

Comment by peterflynn
Thursday Mar 06, 2014 at 20:21 GMT

---

Cleaned up title (was "New wish in Brackets, open file ICO")

[core-ai-bot]

Comment by MarcelGerber
Sunday Mar 23, 2014 at 21:36 GMT

---

@Denisov21 The PR has been merged and you can view .ico files in the next release (Sprint 38).

[core-ai-bot]

Comment by Denisov21
Monday Mar 24, 2014 at 21:06 GMT

---

Ok, thank you guys.

[core-ai-bot]

Comment by Denisov21
Monday Mar 24, 2014 at 21:07 GMT

---

@SAPlayer Thank you, can I close it?

[core-ai-bot]

Comment by MarcelGerber
Tuesday Mar 25, 2014 at 17:43 GMT

---

I think so, yes.

[core-ai-bot]

Comment by TomMalbran
Tuesday Mar 25, 2014 at 18:07 GMT

---

Closing