-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLOSED] Correctly normalize UNC paths #5517
Comments
Comment by iwehrman Pushed one fix for the RE naming and JSDoc. I'm happy to throw an exception in case Less excited about adding a Windows flag to trim out the single colon-in-paths case of normalization, but I don't really have strong feelings either way. Just let me know what you think is best and I'll push the keys. I'm also happy if you just merge because I think both decisions are perfectly fine :) |
Comment by iwehrman I now think that, yes, we should throw if you try to normalize a path before init. Will fix tomorrow. |
Comment by iwehrman The fixing is taking a little longer than I expected. I'm in require.js hell. |
Comment by peterflynn
|
Comment by iwehrman Ready for re-review. |
Comment by iwehrman Impl documentation updated accordingly. |
Comment by gruehle Looks good. Merging. |
Issue by iwehrman
Tuesday Nov 19, 2013 at 00:39 GMT
Originally opened as adobe/brackets#6041
Add support for normalization of UNC paths in the filesystem.
_normalizePath
is now a method of theFileSystem
class. Its behavior w.r.t. UNC paths is controlled by a newFileSystemImpl
flag,normalizeUNCPaths
. If set, paths like///server//foo/bar
are normalized to//server/foo/bar/
instead of/server/foo/bar/
.AppshellFileSystemImpl.normalizeUNCPaths
is set at runtime for Windows only.Addresses #6028 and #6029.
CC
@
gruehle@
peterflynniwehrman included the following code: https://github.com/adobe/brackets/pull/6041/commits
The text was updated successfully, but these errors were encountered: