[CLOSED] Code Cleanup: Live Dev _loadedAgentNames is not accurate.

[core-ai-bot]

Issue by redmunds
Tuesday Apr 09, 2013 at 22:08 GMT
Originally opened as adobe/brackets#3390

---

This was split off of pull adobe/brackets#3203

In LiveDevelopment.js loadAgents() function, agent names are synchronously added to the _loadedAgentNames array after calling agents[name].load(). Seems like they should only be in the list if the call to load() is resolved.

This does not seem to cause any known problem. It just seems to imply that it contains a list of successfully loaded agents and someone may try to use that for something in the future. Possible solutions:

1. If it simply contains the same list as _enabledAgentNames, then the _loadedAgentNames array is not needed
2. If the _loadedAgentNames array is needed, then it should be accurate.
3. The name should be changed to describe what's actually in the array.

[core-ai-bot]

Comment by pthiess
Wednesday Apr 10, 2013 at 17:40 GMT

---

This would be a good thing for the community to look at, therefore I assign it at@dangoor but don't expect him to fix it by himself.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Apr 17, 2013 at 01:13 GMT

---

Also see@iwehrman comment about possible race conditions in loadAgents/unloadAgents here adobe/brackets#3203 (comment).

[core-ai-bot]

Comment by redmunds
Saturday Mar 08, 2014 at 01:08 GMT

---

If any agent doesn't load, then Live Preview fails, so this isn't really an issue. The race condition mentioned by Ian was fixed with _loadAgentsPromise in PR #6889. Closing.