[CLOSED] Fix chrome launching problems

[core-ai-bot]

Issue by redmunds
Monday Mar 11, 2013 at 20:23 GMT
Originally opened as adobe/brackets#3098

---

This is for adobe/brackets#2370

This changes Brackets to always set enableRemoteDebugging to true. This only seems to effect Windows, but it's changed for both Mac and Windows, so both should be tested.

There is an associated randy/starting-live-dev branch on brackets-shell.

@gruehle - there is a remaining issue that@DennisKehrig had on WinXP where he reported that his default browser was forced to be Chrome. I was prompted to change default browser on Win7, so I asked him to double-check that this is a real issue.

---

redmunds included the following code: https://github.com/adobe/brackets/pull/3098/commits

[core-ai-bot]

Comment by gruehle
Tuesday Mar 12, 2013 at 00:30 GMT

---

@redmunds@DennisKehrig - These changes work fine for me on Win7 and Mac OSX 10.8. I'll wait to merge until I get the "all clear" on WinXP.

[core-ai-bot]

Comment by redmunds
Tuesday Mar 12, 2013 at 15:00 GMT

---

@peterflynn Since Dennis' hours are limited, can you give this a try on WinXP?

You need to use randy/starting-live-dev branches on both brackets and brackets-shell. Then try starting Live Dev in these cases:

• Chrome closed
• Chrome open with 1 or more open tabs opened by you
• Chrome open with Dev Tools started from Brackets
• Chrome open with Live Dev page (i.e. switching pages in Brackets)

Also test updating CSS and HTML in Brackets.

[core-ai-bot]

Comment by redmunds
Tuesday Mar 12, 2013 at 23:00 GMT

---

@peterflynn I forgot the most important test. Before you start, set your default browser to be something other than Chrome. Dennis reported that using Brackets Live Dev caused his default browser to change to Chrome, so I want to know if you can reproduce that.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 13, 2013 at 09:45 GMT

---

All Chromes closed: works. Crashed on exit once, but that seems to be the older, hard to reproduce bug.
My Chrome open: works, but ended up at file:// URL a couple of times
My Chrome open with Dev Tools started from Brackets: works
My Chrome open with 2x live dev page (file:// and http://): works
Brackets' Chrome open with 2x live dev page (file:// and http://): works, but changes the file:// tab to localhost instead of reusing the localhost one. The localhost tab is reused if the file:// one is not there, though.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Mar 13, 2013 at 10:01 GMT

---

Changed appshell_extensions_win.cpp to use "--user-data-dir=brackets-profile2" - same thing as I said in my email: Chrome tries to import stuff from Firefox (and fails, presenting an error dialog that delays the process and causes Brackets to timeout if not dismissed soon enough), afterwards .html files open with Chrome if double-clicked.

Same thing with "--no-default-browser-check", sadly.
But "--no-first-run" solves it all: no import dialog, Firefox stays the default browser. :)

[core-ai-bot]

Comment by redmunds
Wednesday Mar 13, 2013 at 16:39 GMT

---

@DennisKehrig Thanks for testing and the solution! I added the --no-first-run flag to Windows code.

@gruehle Ready for another review.

[core-ai-bot]

Comment by gruehle
Thursday Mar 14, 2013 at 14:30 GMT

---

Glad you got the first launch problem solved! Merging.