-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mac: Throw-scrolling upward in the file sometimes jumps downward during scroll #12896
Comments
Comment by dangoor Did you switch branches or in some other way alter the Brackets code on disk while Brackets was running? I've seen this same behavior and it seemed to me to happen when CodeMirror or other editor code changed out from under the running Brackets (which is weird... I don't know why that would be a problem, and I also don't have reproducible steps so this may actually be unrelated). |
Comment by njx Nope, it happens to me all the time, and I'm not pulling master that often. |
Comment by dangoor Interesting. I'll keep an eye out for this sometime when I'm not frequently reloading Brackets. |
Comment by ingorichter
|
Comment by njx I saw it regularly on 10.9 before I upgraded to 10.10 |
Comment by soluml I'm seeing this as well. I haven't been able to pin-point exactly when it happens. Seems like it has something to do with version controlled projects though, likes to happen after a commit. |
Comment by willsteinmetz
|
Comment by willsteinmetz Right after that last post, I noticed it also happens when there is an overlay of some sorts. I use the Git Brackets extension which will put up overlays for various tasks and the jumping seems to happen with that. I'd venture to say it's not the Git Brackets extension because it will also happen with the extension manager overlay as well. Hopefully that can help narrow down part of it. |
Comment by lrebrown As I mentioned in the referenced issue #10293, I am also experiencing this issue. I'm using brackets v1.1 on Windows with git 1.9.5. My only extension is 'brackets git'. I also do not have a reliable way to reproduce the issue, but as queried by Someone needs to remove the 'mac only' tag. |
Comment by peterflynn Is anyone seeing this issue able to reproduce it without the Brackets-Git extension installed? (Try Debug > Reload Without Extensions or temporarily disable that one extension). |
Comment by willsteinmetz
|
Comment by willsteinmetz By always seen it, I mean even long before I started using Brackets got which is only in the last couple of months. I've seen this problem as long as I've used Brackets (since about late 2013). |
Comment by mikedaly I am also experiencing this issue. I do not have Brackets-Git installed, but I do frequently change the branch underneath Brackets. I strongly suspect that it has something to do with checking-out a new branch while affected files are opened in Brackets, though I can't be sure. |
Comment by peterflynn
|
Comment by mikedaly
|
Comment by sweatherall I have had this issue very often as well, very similar to how |
Comment by mikedaly I am also on Mac and have been having this problem since before the 1.0 release. It remains today with 1.2. I wonder if it is Mac-specific. Anyone NOT on a Mac experiencing this problem? |
Comment by njx It feels to me like I've been seeing it a lot more often recently as well. I've been trying to figure out steps, but haven't been able to reproduce it on purpose. I have a suspicion that it's related to switching back to a file (possibly using Quick Open) that was scrolled to the bottom the last time you looked at it, possibly combined with the file having been reloaded in between because of external changes (e.g. switching branches in git). When I have a little time I'll see if I can find a good repro case. |
Comment by njx (To |
Comment by njx One other thing I've noticed: if I get into this state and I do Cmd-Up to jump to the top of the file, then scroll down, it generally fixes the problem, but I notice that as I'm scrolling down, the bottom fourth or so of the screen is blank during the scroll. So it seems like CodeMirror is getting into some state where its idea of the size of the visible region is wrong. |
Comment by sweatherall
|
Comment by njx Okay, I think I have a set of reasonably reproducible steps (though not a handy set of test files).
If the bug doesn't show up, scroll back to the bottom of the file, then do steps 4-7 again, but switch to the branch instead of master in step 5. (I think the problem is most likely to occur when the file shrinks while it's not the current document.) I have a possible fix in #11043 - I've been running with it in Brackets today and I haven't seen the throw scroll problem, whereas if I switch back to Brackets master I can get the bug to occur pretty much immediately. However, since I'm not 100% sure of the repro steps it's still possible that the bug might occur even with the fix - I'll continue running with it over the next few days to see if it shows up again. |
Comment by zaggino adobe/brackets#11043 has been merged to master -> I've tested it and it seems to fix the issue. If anyone else can test the latest master for this, it'd be great :) |
Comment by njx
My off-the-cuff suspicion is that the problem was that we were refreshing when the editor became visible (in |
Comment by zaggino
|
Issue by njx
Wednesday Oct 22, 2014 at 16:30 GMT
Originally opened as adobe/brackets#9632
I haven't filed this because I can't come up with reproducible steps, but it happens to me frequently, so I thought we should record it. It's been happening for a long time, so it's not a 1.0 blocker or anything, but it is pretty annoying. (I think someone else filed a similar issue, but it was tangled up with a bunch of other stuff in a different bug, so I wanted to capture this separately.)
The symptom is that if I'm at the bottom of a file, and I throw-scroll upward (by swiping down on the trackpad), sometimes the scroll will go a little ways upward, then jump back downward. It will keep happening if I keep trying to scroll, though eventually it might "break through". Usually when it happens I'll refresh Brackets, hit Cmd-Up to get to the top of the file, or something similar, and eventually it fixes itself.
I can't figure out how to reliably reproduce it. Sometimes it seems to happen if I switch to a file whose previous scroll position was at or near the bottom. Sometimes it seems to happen if I start at the top of a file, hit Cmd-Down to get to the bottom, then start scrolling up.
I'd say it happens to me at least once a day.
The text was updated successfully, but these errors were encountered: