Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Fix lgtm alerts #11375

Open
core-ai-bot opened this issue Aug 30, 2021 · 2 comments
Open

[CLOSED] Fix lgtm alerts #11375

core-ai-bot opened this issue Aug 30, 2021 · 2 comments

Comments

@core-ai-bot
Copy link
Member

Issue by xiemaisi
Monday Jun 26, 2017 at 11:29 GMT
Originally opened as adobe/brackets#13483

This fixes a few minor issues found by lgtm; for more details see https://lgtm.com/projects/g/adobe/brackets/alerts/.

The fixes in the first three commits are fairly obvious, the last two commits involve some educated guessing as to the intended semantics of the code involved.

xiemaisi included the following code: https://github.com/adobe/brackets/pull/13483/commits
@core-ai-bot
Copy link
Member Author

Comment by xiemaisi
Tuesday Jun 27, 2017 at 06:56 GMT

I've removed the last two commits with the less obvious fixes; I'll put them up as a separate PR.

@core-ai-bot
Copy link
Member Author

Comment by xiemaisi
Thursday Jun 29, 2017 at 11:46 GMT

@petetnt, does this look safer now?

@core-ai-bot core-ai-bot mentioned this issue Aug 31, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot