Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Fix remove menu performance on Windows #262

Open
core-ai-bot opened this issue Aug 17, 2021 · 3 comments
Open

[CLOSED] Fix remove menu performance on Windows #262

core-ai-bot opened this issue Aug 17, 2021 · 3 comments

Comments

@core-ai-bot
Copy link
Member

Issue by redmunds
Thursday Jan 02, 2014 at 18:42 GMT
Originally opened as adobe#407

This fixes menu drawing performance for RemoveMenu() and RemoveMenuItem() in the same way that pull request adobe#377 fixed it for AddMenu().

I noticed this issue when reviewing pull request adobe/brackets#6334.

redmunds included the following code: https://github.com/adobe/brackets-shell/pull/407/commits
@core-ai-bot
Copy link
Member Author

Comment by pthiess
Friday Jan 03, 2014 at 18:24 GMT

@lkcampbell Please have a look at this and feel free to merge at your convenience.

@core-ai-bot
Copy link
Member Author

Comment by lkcampbell
Saturday Jan 04, 2014 at 18:38 GMT

@redmunds, initial code review done. Looks good, just one nit on comments. Good idea refactoring the older stable code.

@core-ai-bot
Copy link
Member Author

Comment by redmunds
Saturday Jan 04, 2014 at 20:53 GMT

Changes pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot