fix(metadata-sidebar): UnsavedChangesModal changes #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
JakubKida
force-pushed
the
unsaved-modal-changes
branch
from
f5fa8f5
to
0cde9ee
Compare
JakubKida
changed the title
JakubKida
changed the title
JakubKida
force-pushed
the
unsaved-modal-changes
branch
14 times, most recently
from
38c18dd
to
5698d74
Compare
wpiesiak
reviewed
Oct 4, 2024
| setSelectedTemplates(templateInstances); | ||
| }, [templateInstances]); | ||
| // disable only pre-existing template instances from dropdown if not editing or editing pre-exiting one | ||
| if (!editingTemplate || templateInstances.some(t => t.templateKey === editingTemplate.templateKey)) { |
There was a problem hiding this comment.
Lets's add scope attribute to the filter condition
JakubKida
force-pushed
the
unsaved-modal-changes
branch
from
5698d74
to
7376d0e
Compare
wpiesiak
previously approved these changes
Oct 4, 2024
JakubKida
force-pushed
the
unsaved-modal-changes
branch
from
0722a2e
to
036dd44
Compare
wpiesiak
previously approved these changes
Oct 4, 2024
JChan106
reviewed
Oct 4, 2024
JakubKida
force-pushed
the
unsaved-modal-changes
branch
from
036dd44
to
1c62666
Compare
JakubKida
force-pushed
the
unsaved-modal-changes
branch
from
bb9ff41
to
9d8e0a3
Compare
bfoxx1906
reviewed
Oct 7, 2024
| <AutofillContextProvider isAiSuggestionsFeatureEnabled={isBoxAiSuggestionsEnabled}> | ||
| <AutofillContextProvider | ||
| isAiSuggestionsFeatureEnabled={isBoxAiSuggestionsEnabled} | ||
| fetchSuggestions={() => Promise.resolve([])} |
There was a problem hiding this comment.
Is this going to be implemented in the future?
There was a problem hiding this comment.
this is a temporary placeholder while the feature is still being implemented in metadata-editor
| <MetadataInstanceForm | ||
| areAiSuggestionsAvailable={true} |
There was a problem hiding this comment.
can we just pass areAiSuggestionsAvailable without the explicit boolean assignment since it is always true?
There was a problem hiding this comment.
this is a temporary placeholder while the feature is still being implemented in metadata-editor
bfoxx1906
previously approved these changes
Oct 7, 2024
greg-in-a-box
requested changes
Oct 7, 2024
src/elements/content-sidebar/stories/tests/MetadataSidebarRedesign-visual.stories.tsx
Outdated
Show resolved
Hide resolved
greg-in-a-box
requested changes
Oct 7, 2024
JakubKida
force-pushed
the
unsaved-modal-changes
branch
from
2323843
to
06e03f5
Compare
JakubKida
force-pushed
the
unsaved-modal-changes
branch
from
bf03f0a
to
8f82edf
Compare
JakubKida
force-pushed
the
unsaved-modal-changes
branch
from
8f82edf
to
a821954
Compare
greg-in-a-box
approved these changes
Oct 7, 2024
JChan106
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
onUnsavedChangesModalCancelto new proponDiscardUnsavedChangesadded on UnsavedChangesModal redesignAdd storybook test for switching the templates through unsaved changes modal
move disabling the templates with
setSelectedTemplatesfor AddTemplateDropdown to ownuseEffectto avoid conflicts